[
https://issues.apache.org/jira/browse/ZOOKEEPER-2926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16324707#comment-16324707
]
ASF GitHub Bot commented on ZOOKEEPER-2926:
---
Github user lvfangmin commented
Github user lvfangmin commented on the issue:
https://github.com/apache/zookeeper/pull/447
@anmolnar I changed the code based on your comments and did amend, is this
the right process?
---
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16324503#comment-16324503
]
ASF GitHub Bot commented on ZOOKEEPER-2926:
---
Github user anmolnar commented
Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/447
@lvfangmin Have you amended your commit?
I see a lot of changes since I last reviewed this PR.
---
See https://builds.apache.org/job/ZooKeeper-trunk-openjdk7/1765/
###
## LAST 60 LINES OF THE CONSOLE
###
[...truncated 68.68 KB...]
[junit] Running org.apache.zookee
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1411/
###
## LAST 60 LINES OF THE CONSOLE
###
[...truncated 77.95 MB...]
[exec] +1 test
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16324478#comment-16324478
]
Hadoop QA commented on ZOOKEEPER-2926:
--
-1 overall. GitHub Pull Request Build
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16324396#comment-16324396
]
ASF GitHub Bot commented on ZOOKEEPER-2926:
---
Github user lvfangmin commented
Github user lvfangmin commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/447#discussion_r161296493
--- Diff:
src/java/main/org/apache/zookeeper/server/PrepRequestProcessor.java ---
@@ -579,13 +579,8 @@ protected void pRequest2Txn(int type, long zxid,
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16324397#comment-16324397
]
ASF GitHub Bot commented on ZOOKEEPER-2926:
---
Github user lvfangmin commented
Github user lvfangmin commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/447#discussion_r161296695
--- Diff: src/java/main/org/apache/zookeeper/server/SessionTrackerImpl.java
---
@@ -280,6 +278,12 @@ public synchronized boolean addSession(long id, int
Github user lvfangmin commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/447#discussion_r161300774
--- Diff: src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java ---
@@ -1187,13 +1187,8 @@ private ProcessTxnResult processTxn(Request request,
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16324395#comment-16324395
]
ASF GitHub Bot commented on ZOOKEEPER-2926:
---
Github user lvfangmin commented
See https://builds.apache.org/job/ZooKeeper-trunk-windows-cmake/2611/
###
## LAST 60 LINES OF THE CONSOLE
###
[...truncated 7.81 KB...]
[ivy:retrieve] found org.slf4j#s
See https://builds.apache.org/job/ZooKeeper_branch35_jdk8/807/
###
## LAST 60 LINES OF THE CONSOLE
###
[...truncated 59.21 KB...]
[junit] Tests run: 1, Failures: 0,
See https://builds.apache.org/job/ZooKeeper-trunk-jdk8/1336/
###
## LAST 60 LINES OF THE CONSOLE
###
[...truncated 59.09 KB...]
[junit] Tests run: 1, Failures: 0, Er
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1410/
###
## LAST 60 LINES OF THE CONSOLE
###
[...truncated 77.41 MB...]
[exec]
[exec
GitHub user kofemann opened a pull request:
https://github.com/apache/zookeeper/pull/448
client: do not try to connect to an unreachable server
Motivation:
When the client wants to connect to a server it lookups the all IP
addresses of servers in the **connectString** and ran
18 matches
Mail list logo