[jira] [Commented] (ZOOKEEPER-2999) CMake build should use target-level commands

2018-03-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16413410#comment-16413410 ] ASF GitHub Bot commented on ZOOKEEPER-2999: --- Github user andschwa commented

[GitHub] zookeeper pull request #486: ZOOKEEPER-2999: CMake build should use target-l...

2018-03-25 Thread andschwa
Github user andschwa commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/486#discussion_r176987184 --- Diff: src/c/CMakeLists.txt --- @@ -14,14 +14,13 @@ # See the License for the specific language governing permissions and # limitations under

[jira] [Commented] (ZOOKEEPER-2997) CMake should not force static CRT linking

2018-03-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16413408#comment-16413408 ] ASF GitHub Bot commented on ZOOKEEPER-2997: --- Github user andschwa commented

[GitHub] zookeeper issue #485: ZOOKEEPER-2997: CMake should not force static CRT link...

2018-03-25 Thread andschwa
Github user andschwa commented on the issue: https://github.com/apache/zookeeper/pull/485 Thanks @hanm! ---

[jira] [Commented] (ZOOKEEPER-2997) CMake should not force static CRT linking

2018-03-25 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1641#comment-1641 ] Hudson commented on ZOOKEEPER-2997: --- SUCCESS: Integrated in Jenkins build ZooKeeper-

[jira] [Commented] (ZOOKEEPER-2998) CMake declares incorrect ZooKeeper version

2018-03-25 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16413332#comment-16413332 ] Hudson commented on ZOOKEEPER-2998: --- SUCCESS: Integrated in Jenkins build ZooKeeper-

ZooKeeper_branch35_jdk7 - Build # 1335 - Failure

2018-03-25 Thread Apache Jenkins Server
See https://builds.apache.org/job/ZooKeeper_branch35_jdk7/1335/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 59.92 KB...] [junit] Running org.apache.zookeep

ZooKeeper-trunk - Build # 3777 - Failure

2018-03-25 Thread Apache Jenkins Server
See https://builds.apache.org/job/ZooKeeper-trunk/3777/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 141.59 KB...] [junit] Running org.apache.zookeeper.test

[jira] [Commented] (ZOOKEEPER-3001) Incorrect log message when try to delete container node

2018-03-25 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16413295#comment-16413295 ] Hudson commented on ZOOKEEPER-3001: --- FAILURE: Integrated in Jenkins build ZooKeeper-

[jira] [Commented] (ZOOKEEPER-3006) Potential NPE in ZKDatabase#calculateTxnLogSizeLimit

2018-03-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3006?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16413291#comment-16413291 ] ASF GitHub Bot commented on ZOOKEEPER-3006: --- Github user eribeiro commented

[GitHub] zookeeper issue #493: ZOOKEEPER-3006: Potential NPE in ZKDatabase#calculateT...

2018-03-25 Thread eribeiro
Github user eribeiro commented on the issue: https://github.com/apache/zookeeper/pull/493 Hi @hanm, Excuse me for the mess up and subsequent confusion. @edwardoliveira is me, @eribeiro (on GH and JIRA), but I inadvertedly opened the PR using my second GH account. :(

[jira] [Commented] (ZOOKEEPER-2997) CMake should not force static CRT linking

2018-03-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16413285#comment-16413285 ] ASF GitHub Bot commented on ZOOKEEPER-2997: --- Github user asfgit closed the p

[GitHub] zookeeper pull request #485: ZOOKEEPER-2997: CMake should not force static C...

2018-03-25 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/zookeeper/pull/485 ---

[jira] [Commented] (ZOOKEEPER-2998) CMake declares incorrect ZooKeeper version

2018-03-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16413281#comment-16413281 ] ASF GitHub Bot commented on ZOOKEEPER-2998: --- Github user asfgit closed the p

[GitHub] zookeeper pull request #484: ZOOKEEPER-2998: CMake declares incorrect ZooKee...

2018-03-25 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/zookeeper/pull/484 ---

[jira] [Assigned] (ZOOKEEPER-3006) Potential NPE in ZKDatabase#calculateTxnLogSizeLimit

2018-03-25 Thread Edward Ribeiro (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3006?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Edward Ribeiro reassigned ZOOKEEPER-3006: - Assignee: Edward Ribeiro > Potential NPE in ZKDatabase#calculateTxnLogSizeLim

[jira] [Commented] (ZOOKEEPER-3006) Potential NPE in ZKDatabase#calculateTxnLogSizeLimit

2018-03-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3006?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16413274#comment-16413274 ] ASF GitHub Bot commented on ZOOKEEPER-3006: --- Github user hanm commented on t

[GitHub] zookeeper issue #493: ZOOKEEPER-3006: Potential NPE in ZKDatabase#calculateT...

2018-03-25 Thread hanm
Github user hanm commented on the issue: https://github.com/apache/zookeeper/pull/493 @edwardoliveira : could you please share your email so I can put it in commit message when merge this? Also, could you please create a JIRA account if you don't have one on https://issues.apache

ZooKeeper-trunk-openjdk7 - Build # 1843 - Failure

2018-03-25 Thread Apache Jenkins Server
See https://builds.apache.org/job/ZooKeeper-trunk-openjdk7/1843/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 61.97 KB...] [junit] Running org.apache.zookee

[jira] [Assigned] (ZOOKEEPER-3001) Incorrect log message when try to delete container node

2018-03-25 Thread Michael Han (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3001?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Han reassigned ZOOKEEPER-3001: -- Assignee: Sel-fish Finch > Incorrect log message when try to delete container node

[GitHub] zookeeper pull request #492: ZOOKEEPER-3001: Incorrect log message when try ...

2018-03-25 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/zookeeper/pull/492 ---

[jira] [Commented] (ZOOKEEPER-3001) Incorrect log message when try to delete container node

2018-03-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16413271#comment-16413271 ] ASF GitHub Bot commented on ZOOKEEPER-3001: --- Github user asfgit closed the p

[jira] [Resolved] (ZOOKEEPER-3001) Incorrect log message when try to delete container node

2018-03-25 Thread Michael Han (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3001?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Han resolved ZOOKEEPER-3001. Resolution: Fixed Fix Version/s: 3.5.4 3.6.0 Issue resolved by

Re: Let's cut a ZK 3.5.4-beta release

2018-03-25 Thread Michael Han
+1 on 3.5.4 release planning. >> There are 10 open blocker issues marked for 3.5.4. Can I get some help to sort out those issues? The url posted does not work for me, here is the query I use: https://goo.gl/3MJZMN Just had a chance to go through the JIRA and did some clean ups. - 1159: lower the

[jira] [Updated] (ZOOKEEPER-1159) ClientCnxn does not propagate session expiration indication

2018-03-25 Thread Michael Han (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1159?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Han updated ZOOKEEPER-1159: --- Priority: Major (was: Blocker) > ClientCnxn does not propagate session expiration indicat

[jira] [Commented] (ZOOKEEPER-761) Remove *synchronous* calls from the *single-threaded* C clieant API, since they are documented not to work

2018-03-25 Thread Michael Han (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16413265#comment-16413265 ] Michael Han commented on ZOOKEEPER-761: --- The patch was merged in 3.5 (and release

[jira] [Resolved] (ZOOKEEPER-761) Remove *synchronous* calls from the *single-threaded* C clieant API, since they are documented not to work

2018-03-25 Thread Michael Han (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-761?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Han resolved ZOOKEEPER-761. --- Resolution: Fixed Fix Version/s: (was: 3.5.4) 3.5.3 > Remove

Re: [VOTE] Upgrade 3.5 and trunk to Java8

2018-03-25 Thread Camille Fournier
+1 On Sun, Mar 25, 2018, 9:16 PM Michael Han wrote: > +1. > > On Sat, Mar 24, 2018 at 9:53 AM, Edward Ribeiro > wrote: > > > +1 (non-binding) > > > > On Sat, Mar 24, 2018 at 1:42 PM, Brian Nixon > > wrote: > > > > > +1 (non-binding) > > > > > > On Fri, Mar 23, 2018 at 2:15 AM, Mark Fenes > wr

Re: [VOTE] Upgrade 3.5 and trunk to Java8

2018-03-25 Thread Michael Han
+1. On Sat, Mar 24, 2018 at 9:53 AM, Edward Ribeiro wrote: > +1 (non-binding) > > On Sat, Mar 24, 2018 at 1:42 PM, Brian Nixon > wrote: > > > +1 (non-binding) > > > > On Fri, Mar 23, 2018 at 2:15 AM, Mark Fenes wrote: > > > > > +1 > > > > > > > > > On Thu, Mar 22, 2018 at 6:57 PM, Andor Molnar

Re: [VOTE] Apache ZooKeeper release 3.4.12 candidate 0

2018-03-25 Thread Michael Han
-1 because release note is not correct. ZOOKEEPER-2948 and ZOOKEEPER-2806 should be included in release notes and corresponding JIRA needs update. Other than this, rc0 looks good. - verified xsum/sig - go through release notes. - verified cluster with different sizes. - verified with few 4lw comm

Success: ZOOKEEPER- PreCommit Build #1548

2018-03-25 Thread Apache Jenkins Server
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1548/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 79.16 MB...] [exec] [exec

Failed: ZOOKEEPER- PreCommit Build #1547

2018-03-25 Thread Apache Jenkins Server
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1547/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 78.99 MB...] [exec] +1 java

[jira] [Commented] (ZOOKEEPER-3006) Potential NPE in ZKDatabase#calculateTxnLogSizeLimit

2018-03-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3006?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16413181#comment-16413181 ] ASF GitHub Bot commented on ZOOKEEPER-3006: --- Github user edwardoliveira comm

[GitHub] zookeeper issue #493: ZOOKEEPER-3006: Potential NPE in ZKDatabase#calculateT...

2018-03-25 Thread edwardoliveira
Github user edwardoliveira commented on the issue: https://github.com/apache/zookeeper/pull/493 Hey, @LJ1043041006, I have just added a unit test. Cheers! ---

ZooKeeper-trunk-jdk8 - Build # 1419 - Failure

2018-03-25 Thread Apache Jenkins Server
See https://builds.apache.org/job/ZooKeeper-trunk-jdk8/1419/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 60.38 KB...] [junit] Running org.apache.zookeeper.

[jira] [Commented] (ZOOKEEPER-3006) Potential NPE in ZKDatabase#calculateTxnLogSizeLimit

2018-03-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3006?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16412977#comment-16412977 ] ASF GitHub Bot commented on ZOOKEEPER-3006: --- Github user maoling commented o

[GitHub] zookeeper issue #493: ZOOKEEPER-3006: Potential NPE in ZKDatabase#calculateT...

2018-03-25 Thread maoling
Github user maoling commented on the issue: https://github.com/apache/zookeeper/pull/493 +1,LGTM ---