[jira] [Commented] (ZOOKEEPER-3019) Add a metric to track number of slow fsyncs

2018-04-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3019?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16451876#comment-16451876 ] ASF GitHub Bot commented on ZOOKEEPER-3019: --- Github user nkalmar commented o

[GitHub] zookeeper pull request #501: ZOOKEEPER-3019 add metric for slow fsyncs count

2018-04-25 Thread nkalmar
Github user nkalmar commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/501#discussion_r183980318 --- Diff: src/java/test/org/apache/zookeeper/test/FourLetterWordsTest.java --- @@ -167,6 +167,8 @@ public void testValidateStatOutput() throws Exception {

[GitHub] zookeeper issue #508: ZOOKEEPER-2994 Tool required to recover log and snapsh...

2018-04-25 Thread anmolnar
Github user anmolnar commented on the issue: https://github.com/apache/zookeeper/pull/508 I will rather remove the dependency and change the implementation to behave similarly without it, so that we can merge this safely. ---

[GitHub] zookeeper pull request #506: ZOOKEEPER-2415 SessionTest is using Thread depr...

2018-04-25 Thread anmolnar
Github user anmolnar closed the pull request at: https://github.com/apache/zookeeper/pull/506 ---

[jira] [Commented] (ZOOKEEPER-2994) Tool required to recover log and snapshot entries with CRC errors

2018-04-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16451931#comment-16451931 ] ASF GitHub Bot commented on ZOOKEEPER-2994: --- Github user anmolnar commented

[jira] [Commented] (ZOOKEEPER-2415) SessionTest is using Thread deprecated API.

2018-04-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16451932#comment-16451932 ] ASF GitHub Bot commented on ZOOKEEPER-2415: --- Github user anmolnar closed the

Failed: ZOOKEEPER- PreCommit Build #1629

2018-04-25 Thread Apache Jenkins Server
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1629/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 2.23 KB...] stderr: Also: hudson

[GitHub] zookeeper issue #501: ZOOKEEPER-3019 add metric for slow fsyncs count

2018-04-25 Thread nkalmar
Github user nkalmar commented on the issue: https://github.com/apache/zookeeper/pull/501 Removed fsyncExceed from stats command, but the tracking variable still remains in ServerStats. I was thinking of moving it to for example zkDb, but that wouldn't make any more sense in my opinion

[jira] [Commented] (ZOOKEEPER-3019) Add a metric to track number of slow fsyncs

2018-04-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3019?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16452134#comment-16452134 ] ASF GitHub Bot commented on ZOOKEEPER-3019: --- Github user nkalmar commented o

[GitHub] zookeeper issue #508: ZOOKEEPER-2994 Tool required to recover log and snapsh...

2018-04-25 Thread anmolnar
Github user anmolnar commented on the issue: https://github.com/apache/zookeeper/pull/508 @phunt Done. Now it's using a custom parser and no additional dependency requirement. ---

[jira] [Commented] (ZOOKEEPER-2994) Tool required to recover log and snapshot entries with CRC errors

2018-04-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16452162#comment-16452162 ] ASF GitHub Bot commented on ZOOKEEPER-2994: --- Github user anmolnar commented

[jira] [Commented] (ZOOKEEPER-3026) ReadOnlyModeTest is using Thread deprecated API.

2018-04-25 Thread Andor Molnar (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16452171#comment-16452171 ] Andor Molnar commented on ZOOKEEPER-3026: - [~phunt] Sure, no problem. Thanks f

Failed: ZOOKEEPER- PreCommit Build #1631

2018-04-25 Thread Apache Jenkins Server
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1631/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 2.82 KB...] at hudso

[jira] [Commented] (ZOOKEEPER-2994) Tool required to recover log and snapshot entries with CRC errors

2018-04-25 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16452229#comment-16452229 ] Hadoop QA commented on ZOOKEEPER-2994: -- +1 overall. GitHub Pull Request Build

Success: ZOOKEEPER- PreCommit Build #1630

2018-04-25 Thread Apache Jenkins Server
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1630/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 41.08 MB...] [exec] +1 @aut

[jira] [Commented] (ZOOKEEPER-3026) ReadOnlyModeTest is using Thread deprecated API.

2018-04-25 Thread Patrick Hunt (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16452343#comment-16452343 ] Patrick Hunt commented on ZOOKEEPER-3026: - Ah, sorry about that! I will update

[jira] [Updated] (ZOOKEEPER-3026) ReadOnlyModeTest is using Thread deprecated API.

2018-04-25 Thread Patrick Hunt (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3026?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt updated ZOOKEEPER-3026: Description: Same issue as ZOOKEEPER-2415   Suspend and resume are being called on pee

Re: Please add your release data for 'zookeeper'

2018-04-25 Thread Patrick Hunt
I took care of this. Thanks Abe! Patrick On Tue, Apr 24, 2018 at 8:40 PM, Abraham Fine wrote: > Hello PMC Members- > > Would one of you please help me with this part of the release process? > > Thanks, > Abe > > - Original message - > From: Apache Reporter Service > To: afine > Subjec

Fw: Re: [osgi-dev] Invalid version in bundle org.apache.hadoop.zookeeper=: 3.5.3-beta

2018-04-25 Thread Kevin Boyle
Hello,I'm attempting to use the curator-recipes version 4.0.1 in an OSGi application.   The curator version is dependent on zookeeper 3.5.3-beta but the version format isn't compatible with OSGI, see the reply from the osgi developers forum below, is it possible to replace the "-beta" with ".be

[jira] [Commented] (ZOOKEEPER-1752) Download area contains obsolete releases

2018-04-25 Thread Dave (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16453002#comment-16453002 ] Dave commented on ZOOKEEPER-1752: - It looks like zookeeper-3.4.11 was removed instead

[jira] [Commented] (ZOOKEEPER-1752) Download area contains obsolete releases

2018-04-25 Thread Patrick Hunt (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16453010#comment-16453010 ] Patrick Hunt commented on ZOOKEEPER-1752: - 3.4.11 has a very serious regressio

[jira] [Commented] (ZOOKEEPER-1752) Download area contains obsolete releases

2018-04-25 Thread Dave (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16453011#comment-16453011 ] Dave commented on ZOOKEEPER-1752: - Ok. It's still linked to as the single 3.4.x releas

[jira] [Commented] (ZOOKEEPER-1752) Download area contains obsolete releases

2018-04-25 Thread Patrick Hunt (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16453027#comment-16453027 ] Patrick Hunt commented on ZOOKEEPER-1752: - The release is being finalized curr

Re: Fw: Re: [osgi-dev] Invalid version in bundle org.apache.hadoop.zookeeper=: 3.5.3-beta

2018-04-25 Thread Patrick Hunt
Hi Kevin. Is it the same issue as this? https://issues.apache.org/jira/browse/ZOOKEEPER-2317 If so perhaps you could take on that JIRA and help drive a solution. I think the biggest issue is that no-one on our end has sufficient experience on OSGI to verify a fix. Regards, Patrick On Wed, Apr 2

[jira] [Commented] (ZOOKEEPER-1752) Download area contains obsolete releases

2018-04-25 Thread Dave (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16453074#comment-16453074 ] Dave commented on ZOOKEEPER-1752: - Gotcha. No worries. Was a little confusing during t

[GitHub] zookeeper pull request #469: ZOOKEEPER-2983: Print the classpath when runnin...

2018-04-25 Thread mfenes
Github user mfenes closed the pull request at: https://github.com/apache/zookeeper/pull/469 ---

[jira] [Commented] (ZOOKEEPER-2983) Print the classpath when running compile and test ant targets

2018-04-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16453086#comment-16453086 ] ASF GitHub Bot commented on ZOOKEEPER-2983: --- Github user mfenes closed the p

[GitHub] zookeeper pull request #470: ZOOKEEPER-2983: Print the classpath when runnin...

2018-04-25 Thread mfenes
Github user mfenes closed the pull request at: https://github.com/apache/zookeeper/pull/470 ---

[jira] [Commented] (ZOOKEEPER-2983) Print the classpath when running compile and test ant targets

2018-04-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16453087#comment-16453087 ] ASF GitHub Bot commented on ZOOKEEPER-2983: --- Github user mfenes closed the p

[GitHub] zookeeper pull request #471: ZOOKEEPER-2983: Print the classpath when runnin...

2018-04-25 Thread mfenes
Github user mfenes closed the pull request at: https://github.com/apache/zookeeper/pull/471 ---

[jira] [Commented] (ZOOKEEPER-2983) Print the classpath when running compile and test ant targets

2018-04-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16453090#comment-16453090 ] ASF GitHub Bot commented on ZOOKEEPER-2983: --- Github user mfenes closed the p

[GitHub] zookeeper issue #495: ZOOKEEPER-3007:Potential NPE in ReferenceCountedACLCac...

2018-04-25 Thread phunt
Github user phunt commented on the issue: https://github.com/apache/zookeeper/pull/495 Ok, that (call site analysis) makes sense. I'm afraid I was unclear, when I said "You don't need an ERROR in the text here or on the next line." What I mean is that the tex

[jira] [Commented] (ZOOKEEPER-3007) Potential NPE in ReferenceCountedACLCache#deserialize

2018-04-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16453098#comment-16453098 ] ASF GitHub Bot commented on ZOOKEEPER-3007: --- Github user phunt commented on

[GitHub] zookeeper issue #501: ZOOKEEPER-3019 add metric for slow fsyncs count

2018-04-25 Thread phunt
Github user phunt commented on the issue: https://github.com/apache/zookeeper/pull/501 I'm afraid this is no longer auto-merging, also the PR build failed on jenkins with similar: > Automatic merge failed; fix conflicts and then commit the result. @nkalmar could you r

[jira] [Commented] (ZOOKEEPER-3019) Add a metric to track number of slow fsyncs

2018-04-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3019?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16453113#comment-16453113 ] ASF GitHub Bot commented on ZOOKEEPER-3019: --- Github user phunt commented on

[jira] [Updated] (ZOOKEEPER-2994) Tool required to recover log and snapshot entries with CRC errors

2018-04-25 Thread Patrick Hunt (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2994?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt updated ZOOKEEPER-2994: Affects Version/s: 3.4.13 > Tool required to recover log and snapshot entries with CRC e

[jira] [Updated] (ZOOKEEPER-2994) Tool required to recover log and snapshot entries with CRC errors

2018-04-25 Thread Patrick Hunt (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2994?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt updated ZOOKEEPER-2994: Fix Version/s: 3.4.13 > Tool required to recover log and snapshot entries with CRC error

[GitHub] zookeeper issue #508: ZOOKEEPER-2994 Tool required to recover log and snapsh...

2018-04-25 Thread phunt
Github user phunt commented on the issue: https://github.com/apache/zookeeper/pull/508 +1. Great. Thanks @anmolnar . I've committed for 3.4.13. ---

[jira] [Commented] (ZOOKEEPER-2994) Tool required to recover log and snapshot entries with CRC errors

2018-04-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16453134#comment-16453134 ] ASF GitHub Bot commented on ZOOKEEPER-2994: --- Github user phunt commented on

[jira] [Commented] (ZOOKEEPER-2994) Tool required to recover log and snapshot entries with CRC errors

2018-04-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16453143#comment-16453143 ] ASF GitHub Bot commented on ZOOKEEPER-2994: --- Github user phunt commented on

[GitHub] zookeeper issue #508: ZOOKEEPER-2994 Tool required to recover log and snapsh...

2018-04-25 Thread phunt
Github user phunt commented on the issue: https://github.com/apache/zookeeper/pull/508 @anmolnar you will have to close this manually as it's not master branch. ---

[GitHub] zookeeper pull request #496: ZOOKEEPER-3008: Potential NPE in SaslQuorumAuth...

2018-04-25 Thread phunt
Github user phunt commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/496#discussion_r184218439 --- Diff: src/java/main/org/apache/zookeeper/server/quorum/auth/SaslQuorumAuthLearner.java --- @@ -94,7 +94,10 @@ public void authenticate(Socket sock, Str

[jira] [Commented] (ZOOKEEPER-3008) Potential NPE in SaslQuorumAuthLearner#authenticate and SaslQuorumAuthServer#authenticate

2018-04-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16453159#comment-16453159 ] ASF GitHub Bot commented on ZOOKEEPER-3008: --- Github user phunt commented on

[GitHub] zookeeper pull request #443: ZOOKEEPER-2955: Enable Clover code coverage rep...

2018-04-25 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/zookeeper/pull/443 ---

[GitHub] zookeeper issue #443: ZOOKEEPER-2955: Enable Clover code coverage report

2018-04-25 Thread phunt
Github user phunt commented on the issue: https://github.com/apache/zookeeper/pull/443 +1, lgtm. I've committed this to master. Thanks @mfenes ! ---

[jira] [Commented] (ZOOKEEPER-2955) Enable Clover code coverage report

2018-04-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16453180#comment-16453180 ] ASF GitHub Bot commented on ZOOKEEPER-2955: --- Github user asfgit closed the p

[GitHub] zookeeper issue #445: ZOOKEEPER-2955: Enable Clover code coverage report

2018-04-25 Thread phunt
Github user phunt commented on the issue: https://github.com/apache/zookeeper/pull/445 Does this need to be updated to reflect #443 ? ---

[jira] [Commented] (ZOOKEEPER-2955) Enable Clover code coverage report

2018-04-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16453185#comment-16453185 ] ASF GitHub Bot commented on ZOOKEEPER-2955: --- Github user phunt commented on

[GitHub] zookeeper issue #444: ZOOKEEPER-2955: Enable Clover code coverage report

2018-04-25 Thread phunt
Github user phunt commented on the issue: https://github.com/apache/zookeeper/pull/444 Does this need to be updated to reflect #443 ? ---

[jira] [Commented] (ZOOKEEPER-2955) Enable Clover code coverage report

2018-04-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16453181#comment-16453181 ] ASF GitHub Bot commented on ZOOKEEPER-2955: --- Github user phunt commented on

[jira] [Commented] (ZOOKEEPER-2955) Enable Clover code coverage report

2018-04-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16453183#comment-16453183 ] ASF GitHub Bot commented on ZOOKEEPER-2955: --- Github user phunt commented on

[jira] [Commented] (ZOOKEEPER-2955) Enable Clover code coverage report

2018-04-25 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16453213#comment-16453213 ] Hudson commented on ZOOKEEPER-2955: --- SUCCESS: Integrated in Jenkins build ZooKeeper-

[jira] [Commented] (ZOOKEEPER-3008) Potential NPE in SaslQuorumAuthLearner#authenticate and SaslQuorumAuthServer#authenticate

2018-04-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16453346#comment-16453346 ] ASF GitHub Bot commented on ZOOKEEPER-3008: --- Github user lujiefsi commented

[GitHub] zookeeper pull request #496: ZOOKEEPER-3008: Potential NPE in SaslQuorumAuth...

2018-04-25 Thread lujiefsi
Github user lujiefsi commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/496#discussion_r184251756 --- Diff: src/java/main/org/apache/zookeeper/server/quorum/auth/SaslQuorumAuthLearner.java --- @@ -94,7 +94,10 @@ public void authenticate(Socket sock,

[jira] [Commented] (ZOOKEEPER-3007) Potential NPE in ReferenceCountedACLCache#deserialize

2018-04-25 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16453380#comment-16453380 ] Hadoop QA commented on ZOOKEEPER-3007: -- -1 overall. GitHub Pull Request Build

Failed: ZOOKEEPER- PreCommit Build #1632

2018-04-25 Thread Apache Jenkins Server
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1632/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 75.44 MB...] [exec] [exec

[GitHub] zookeeper pull request #508: ZOOKEEPER-2994 Tool required to recover log and...

2018-04-25 Thread anmolnar
Github user anmolnar closed the pull request at: https://github.com/apache/zookeeper/pull/508 ---

[jira] [Commented] (ZOOKEEPER-2994) Tool required to recover log and snapshot entries with CRC errors

2018-04-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16453500#comment-16453500 ] ASF GitHub Bot commented on ZOOKEEPER-2994: --- Github user anmolnar closed the