[jira] [Commented] (ZOOKEEPER-3056) Fails to load database with missing snapshot file but valid transaction log file

2018-06-05 Thread Michael Han (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16502830#comment-16502830 ] Michael Han commented on ZOOKEEPER-3056: I think we just need to differentiat

[GitHub] zookeeper pull request #538: Don't merge. Experimental test to collect extra...

2018-06-05 Thread lavacat
Github user lavacat closed the pull request at: https://github.com/apache/zookeeper/pull/538 ---

Failed: ZOOKEEPER- PreCommit Build #1791

2018-06-05 Thread Apache Jenkins Server
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1791/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 86.82 MB...] [exec] [exec

ZooKeeper-trunk - Build # 52 - Failure

2018-06-05 Thread Apache Jenkins Server
See https://builds.apache.org/job/ZooKeeper-trunk/52/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 141.97 KB...] [junit] Tests run: 1, Failures: 0, Errors:

Failed: ZOOKEEPER- PreCommit Build #1790

2018-06-05 Thread Apache Jenkins Server
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1790/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 85.05 MB...] [exec] [exec

[GitHub] zookeeper pull request #538: Don't merge. Experimental test to collect extra...

2018-06-05 Thread lavacat
GitHub user lavacat opened a pull request: https://github.com/apache/zookeeper/pull/538 Don't merge. Experimental test to collect extra data when creating 10K nodes You can merge this pull request into a Git repository by running: $ git pull https://github.com/lavacat/zookeepe

Re: ZooKeeper 3.4 to 3.5.x upgrade: "No snapshot found, but there are log entries. Something is broken!"

2018-06-05 Thread Sijie Guo
Do you think it is worth reverting that change first? Or maybe put the validation in a if-else branch and controlled by a configuration setting. So people who is using 3.4.6 can turn the flag off for upgrading and turn the flag on after upgrade. On 2018/06/05 14:32:42, Michael Han wrote: > A

[jira] [Commented] (ZOOKEEPER-3056) Fails to load database with missing snapshot file but valid transaction log file

2018-06-05 Thread Sijie Guo (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16502527#comment-16502527 ] Sijie Guo commented on ZOOKEEPER-3056: -- [~hanm] [~nixon] [~breed]     Do you

Re: ZooKeeper 3.4 to 3.5.x upgrade: "No snapshot found, but there are log entries. Something is broken!"

2018-06-05 Thread Sijie Guo
On 2018/06/05 04:36:55, Michael Han wrote: > Hi Sijie, > > >> I am just curious why the change was made in such way. > > It's a safety guarantee. Consider this case: > > * An ensemble of server A, B, and C. A and B have most up to date > transactions (let's say zxid + 1) while C is lagging

[jira] [Commented] (ZOOKEEPER-705) Fails to Build due to unknown opcode 'lock' in mt_adaptor.c

2018-06-05 Thread Emmanuel Bourg (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16502422#comment-16502422 ] Emmanuel Bourg commented on ZOOKEEPER-705: -- This has been fixed in 3.4.11. >

[jira] [Commented] (ZOOKEEPER-3056) Fails to load database with missing snapshot file but valid transaction log file

2018-06-05 Thread Michael Han (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16501920#comment-16501920 ] Michael Han commented on ZOOKEEPER-3056: cc [~nixon], [~breed] who introduced

[jira] [Created] (ZOOKEEPER-3056) Fails to load database with missing snapshot file but valid transaction log file

2018-06-05 Thread Michael Han (JIRA)
Michael Han created ZOOKEEPER-3056: -- Summary: Fails to load database with missing snapshot file but valid transaction log file Key: ZOOKEEPER-3056 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3056

Re: ZooKeeper 3.4 to 3.5.x upgrade: "No snapshot found, but there are log entries. Something is broken!"

2018-06-05 Thread Michael Han
Thanks Andor for reproducing this. I don't think back porting of ZOOKEEPER-2325 will solve the issue reported here, since the key issue here is that ZK would not load if there is no snapshot file. I'll create a JIRA for this. On Tue, Jun 5, 2018 at 1:56 AM, Andor Molnar wrote: > Hi Matteo / Mic

Re: ZooKeeper 3.4 to 3.5.x upgrade: "No snapshot found, but there are log entries. Something is broken!"

2018-06-05 Thread Michael Han
A simple workaround is to make sure we always have at least one snapshot file before upgrading (e.g. we can use a small snapCount to force snap generation). Though from user perspective this is not ideal, but at least this would unblock the upgrade. I'll create a JIRA so we can discuss what's the

Re: Should we cut a 3.4.13 release?

2018-06-05 Thread Michael Han
>> Perhaps you can commit the 3.5/trunk changes for 2184 prior to the 3.4 release? Sounds good, I'll take another look at the port and commit it this week if no other issues. On Tue, Jun 5, 2018 at 12:44 AM, Patrick Hunt wrote: > +1 - sounds good. 2959 and 2184 will be good to get out to users.

ZooKeeper_branch35_jdk8 - Build # 993 - Failure

2018-06-05 Thread Apache Jenkins Server
See https://builds.apache.org/job/ZooKeeper_branch35_jdk8/993/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 62.13 KB...] [junit] Running org.apache.zookeepe

Re: ZooKeeper 3.4 to 3.5.x upgrade: "No snapshot found, but there are log entries. Something is broken!"

2018-06-05 Thread Andor Molnar
Hi Matteo / Michael, I confirmed that ZK cannot be upgraded to 3.5.4-beta if there's no snapshot file in the datadir. I get the same error message as Matteo reported. This could be a critical / blocker for the 3.5 release. Michael, how should we track this? I've seen you reopened ZOOKEEPER-2325 a

Re: Should we cut a 3.4.13 release?

2018-06-05 Thread Patrick Hunt
+1 - sounds good. 2959 and 2184 will be good to get out to users. Perhaps you can commit the 3.5/trunk changes for 2184 prior to the 3.4 release? Just to ensure that we didn't miss anything and the releases are consistent, at least initially. Regards, Patrick On Sat, Jun 2, 2018 at 12:59 AM Mi