[GitHub] zookeeper pull request #184: ZOOKEEPER-236: SSL Support for Atomic Broadcast...

2018-06-17 Thread anmolnar
Github user anmolnar commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/184#discussion_r195935031 --- Diff: src/java/main/org/apache/zookeeper/server/quorum/Leader.java --- @@ -227,19 +229,36 @@ public boolean isQuorumSynced(QuorumVerifier qv) {

Failed: ZOOKEEPER- PreCommit Build #1838

2018-06-17 Thread Apache Jenkins Server
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1838/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 3.15 KB...] at hudso

ZooKeeper_branch34_openjdk7 - Build # 1962 - Still Failing

2018-06-17 Thread Apache Jenkins Server
See https://builds.apache.org/job/ZooKeeper_branch34_openjdk7/1962/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 40.81 KB...] [junit] Running org.apache.zoo

[jira] [Commented] (ZOOKEEPER-2886) Permanent session moved error in multi-op only connections

2018-06-17 Thread Fangmin Lv (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16515234#comment-16515234 ] Fangmin Lv commented on ZOOKEEPER-2886: --- Thanks [~dbenediktson], let's discuss

Failed: ZOOKEEPER- PreCommit Build #1839

2018-06-17 Thread Apache Jenkins Server
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1839/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 97.25 MB...] [exec] [exec

[jira] [Commented] (ZOOKEEPER-2886) Permanent session moved error in multi-op only connections

2018-06-17 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16515238#comment-16515238 ] Hadoop QA commented on ZOOKEEPER-2886: -- -1 overall. GitHub Pull Request Build

[GitHub] zookeeper pull request #529: [ZOOKEEPER-2368] Send a watch event is when a c...

2018-06-17 Thread enixon
Github user enixon commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/529#discussion_r195949390 --- Diff: src/java/main/org/apache/zookeeper/ClientCnxn.java --- @@ -1260,10 +1260,8 @@ public void run() { cleanup();

[GitHub] zookeeper pull request #529: [ZOOKEEPER-2368] Send a watch event is when a c...

2018-06-17 Thread enixon
Github user enixon commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/529#discussion_r195949453 --- Diff: src/java/main/org/apache/zookeeper/Watcher.java --- @@ -84,7 +84,14 @@ * client connection (the session) is no longer valid. You

[GitHub] zookeeper pull request #529: [ZOOKEEPER-2368] Send a watch event is when a c...

2018-06-17 Thread enixon
Github user enixon commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/529#discussion_r195949397 --- Diff: src/java/main/org/apache/zookeeper/ClientCnxn.java --- @@ -1438,6 +1436,11 @@ public void disconnect() { } sendThr

[GitHub] zookeeper pull request #544: ZOOKEEPER-3009 : fix the related bugs in branch...

2018-06-17 Thread hanm
Github user hanm commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/544#discussion_r195958750 --- Diff: src/java/main/org/apache/zookeeper/server/NIOServerCnxnFactory.java --- @@ -165,9 +168,13 @@ public void removeCnxn(NIOServerCnxn cnxn) {

[GitHub] zookeeper issue #534: ZOOKEEPER-2184 Zookeeper Client should re-resolve host...

2018-06-17 Thread hanm
Github user hanm commented on the issue: https://github.com/apache/zookeeper/pull/534 @anmolnar do you have a chance to address the issues from code review? Please let me know if you plan to work on this in next few days - otherwise I'll just go ahead and do the 3.4 release without wa

[jira] [Updated] (ZOOKEEPER-2319) UnresolvedAddressException cause the QuorumCnxManager.Listener exit

2018-06-17 Thread Michael Han (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2319?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Han updated ZOOKEEPER-2319: --- Fix Version/s: (was: 3.5.5) 3.4.7 3.5.0 > Unres

[jira] [Commented] (ZOOKEEPER-2319) UnresolvedAddressException cause the QuorumCnxManager.Listener exit

2018-06-17 Thread Michael Han (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16515324#comment-16515324 ] Michael Han commented on ZOOKEEPER-2319: This issue should be fixed ZOOKEEPER

[jira] [Resolved] (ZOOKEEPER-2319) UnresolvedAddressException cause the QuorumCnxManager.Listener exit

2018-06-17 Thread Michael Han (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2319?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Han resolved ZOOKEEPER-2319. Resolution: Fixed Assignee: Michael Han > UnresolvedAddressException cause the Qu

[GitHub] zookeeper issue #348: ZOOKEEPER-2319:UnresolvedAddressException cause the Qu...

2018-06-17 Thread hanm
Github user hanm commented on the issue: https://github.com/apache/zookeeper/pull/348 @maoling please see my comments on the JIRA, I think this can be closed. ---

[jira] [Updated] (ZOOKEEPER-2319) UnresolvedAddressException cause the QuorumCnxManager.Listener exit

2018-06-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2319?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated ZOOKEEPER-2319: -- Labels: pull-request-available (was: ) > UnresolvedAddressException cause the Quor

[GitHub] zookeeper issue #534: ZOOKEEPER-2184 Zookeeper Client should re-resolve host...

2018-06-17 Thread anmolnar
Github user anmolnar commented on the issue: https://github.com/apache/zookeeper/pull/534 @hanm Sorry for the delay. I'll work on it today. ---

[GitHub] zookeeper pull request #534: ZOOKEEPER-2184 Zookeeper Client should re-resol...

2018-06-17 Thread anmolnar
Github user anmolnar commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/534#discussion_r195964179 --- Diff: src/java/main/org/apache/zookeeper/client/StaticHostProvider.java --- @@ -149,15 +185,12 @@ public StaticHostProvider(Collection serverAddress

[GitHub] zookeeper pull request #544: ZOOKEEPER-3009 : fix the related bugs in branch...

2018-06-17 Thread lujiefsi
Github user lujiefsi commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/544#discussion_r195967959 --- Diff: src/java/main/org/apache/zookeeper/server/NIOServerCnxnFactory.java --- @@ -165,9 +168,13 @@ public void removeCnxn(NIOServerCnxn cnxn) {

Failed: ZOOKEEPER- PreCommit Build #1840

2018-06-17 Thread Apache Jenkins Server
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1840/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 2.98 MB...] [exec] +1 javad

[jira] [Commented] (ZOOKEEPER-3009) Potential NPE in NIOServerCnxnFactory

2018-06-17 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16515364#comment-16515364 ] Hadoop QA commented on ZOOKEEPER-3009: -- -1 overall. GitHub Pull Request Build

[jira] [Commented] (ZOOKEEPER-3009) Potential NPE in NIOServerCnxnFactory

2018-06-17 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16515365#comment-16515365 ] Hadoop QA commented on ZOOKEEPER-3009: -- -1 overall. GitHub Pull Request Build

Failed: ZOOKEEPER- PreCommit Build #1841

2018-06-17 Thread Apache Jenkins Server
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1841/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 31.23 KB...] [exec] +1 java

[GitHub] zookeeper pull request #489: ZOOKEEPER-2989: IPv6 literal address causes pro...

2018-06-17 Thread lvfangmin
Github user lvfangmin commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/489#discussion_r195968969 --- Diff: src/java/main/org/apache/zookeeper/server/quorum/QuorumCnxManager.java --- @@ -222,15 +222,15 @@ static public InitialMessage parse(Long prot