Github user lvfangmin commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/555#discussion_r202508110
--- Diff:
src/java/main/org/apache/zookeeper/server/quorum/LearnerHandler.java ---
@@ -792,7 +792,14 @@ public boolean syncFollower(long peerLastZxid,
Github user lvfangmin commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/566#discussion_r202507971
--- Diff:
src/java/main/org/apache/zookeeper/server/persistence/FileTxnLog.java ---
@@ -99,6 +99,9 @@
public static final String LOG_FILE
Github user lvfangmin commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/566#discussion_r202508017
--- Diff:
src/java/main/org/apache/zookeeper/server/persistence/FileTxnLog.java ---
@@ -339,7 +342,8 @@ public synchronized void commit() throws IOExcep
Github user jpeach commented on the issue:
https://github.com/apache/zookeeper/pull/565
Unrelated test failure
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1936/testReport/org.apache.zookeeper.server.quorum/QuorumPeerMainTest/testFailedTxnAsPartOfQuorumLoss/
---
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3067?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16543952#comment-16543952
]
Hadoop QA commented on ZOOKEEPER-3067:
--
-1 overall. GitHub Pull Request Build
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1936/
###
## LAST 60 LINES OF THE CONSOLE
###
[...truncated 85.20 MB...]
[exec]
[exec
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3067?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16543916#comment-16543916
]
Hadoop QA commented on ZOOKEEPER-3067:
--
-1 overall. GitHub Pull Request Build
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1935/
###
## LAST 60 LINES OF THE CONSOLE
###
[...truncated 85.75 MB...]
[exec]
[exec
Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/565
@jpeach Issue was on master, but it's already fixed.
Please trigger another build by amending your latest commit.
---
Github user jpeach commented on the issue:
https://github.com/apache/zookeeper/pull/565
AFAICT the test failure is from findbugs, which shouldn't have been
affected in this commit. I couldn't find what it was happy about in the test
output.
---
See https://builds.apache.org/job/ZooKeeper_branch34_openjdk7/1989/
###
## LAST 60 LINES OF THE CONSOLE
###
[...truncated 39.82 KB...]
[junit] Tests run: 1, Failures
Github user anmolnar commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/567#discussion_r202364176
--- Diff:
src/java/main/org/apache/zookeeper/server/persistence/FileTxnLog.java ---
@@ -347,6 +397,13 @@ public synchronized void commit() throws IOExcep
Github user anmolnar commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/567#discussion_r202363134
--- Diff:
src/java/main/org/apache/zookeeper/server/persistence/FileTxnLog.java ---
@@ -102,6 +102,20 @@
/** Maximum time we allow for elapsed f
Github user anmolnar commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/567#discussion_r202364713
--- Diff:
src/java/main/org/apache/zookeeper/server/persistence/FileTxnLog.java ---
@@ -347,6 +397,13 @@ public synchronized void commit() throws IOExcep
Github user anmolnar commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/567#discussion_r202363520
--- Diff:
src/java/main/org/apache/zookeeper/server/persistence/FileTxnLog.java ---
@@ -110,6 +124,18 @@
if ((fsyncWarningThreshold =
Long.
Github user anmolnar commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/567#discussion_r202362761
--- Diff:
src/java/main/org/apache/zookeeper/server/persistence/FileTxnLog.java ---
@@ -110,6 +124,18 @@
if ((fsyncWarningThreshold =
Long.
Github user anmolnar commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/567#discussion_r202364057
--- Diff:
src/java/main/org/apache/zookeeper/server/persistence/FileTxnLog.java ---
@@ -347,6 +397,13 @@ public synchronized void commit() throws IOExcep
See https://builds.apache.org/job/ZooKeeper_branch35_jdk8/1038/
###
## LAST 60 LINES OF THE CONSOLE
###
[...truncated 62.43 KB...]
[junit] Running org.apache.zookeep
See https://builds.apache.org/job/ZooKeeper-trunk/100/
###
## LAST 60 LINES OF THE CONSOLE
###
[...truncated 3.94 KB...]
at
com.google.common.util.concurrent.Fo
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3033?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andor Molnar resolved ZOOKEEPER-3033.
-
Resolution: Fixed
Fix Version/s: 3.5.5
3.6.0
Issue resolved
Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/564
Merged. Thanks @nkalmar
---
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3033?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Norbert Kalmar updated ZOOKEEPER-3033:
--
Affects Version/s: 3.5.4
3.4.12
> Step 1.2 - Create zk-recip
Github user asfgit closed the pull request at:
https://github.com/apache/zookeeper/pull/564
---
See https://builds.apache.org/job/ZooKeeper-trunk/99/
###
## LAST 60 LINES OF THE CONSOLE
###
[...truncated 142.58 KB...]
[junit] Tests run: 1, Failures: 0, Errors:
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1934/
###
## LAST 60 LINES OF THE CONSOLE
###
[...truncated 85.97 MB...]
[exec] +1 @aut
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16542903#comment-16542903
]
Hadoop QA commented on ZOOKEEPER-2184:
--
+1 overall. GitHub Pull Request Build
Github user maoling commented on the issue:
https://github.com/apache/zookeeper/pull/556
It seems that Jenkins doesn't like me, even doesn't reject me,let me wait
and wait ,just like some girls I chase.
---
Github user maoling commented on the issue:
https://github.com/apache/zookeeper/pull/553
@a470577391
it's useful and enough to change `continue` to `break`,especially when call
`getLogFiles(logDir.listFiles(), 0)`
It's better to create a
[JIRA](https://issues.apache.org/jira/
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3087?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andor Molnar resolved ZOOKEEPER-3087.
-
Resolution: Fixed
Fix Version/s: 3.6.0
Issue resolved by pull request 568
[htt
Github user asfgit closed the pull request at:
https://github.com/apache/zookeeper/pull/568
---
30 matches
Mail list logo
