Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/609
@nkalmar Looks like this is ready for commit. Would you please try to kick
a Jenkins build?
---
Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/184
@hanm @breed pinging again ...
---
Github user eolivelli commented on the issue:
https://github.com/apache/zookeeper/pull/601
Thank you @lvfangmin .
I will add tests for QuorumPeer. I hope I will have some cycle on Friday
---
Github user lvfangmin commented on the issue:
https://github.com/apache/zookeeper/pull/580
@jtuple do you have time to resolve the comments and rebase this onto
latest branch? It would be great if we can get this in this week.
---
Github user lvfangmin commented on the issue:
https://github.com/apache/zookeeper/pull/601
Thanks @eolivelli, the updated diff LGTM, let's keep this open for a few
more days to see if there is any other comments, I'll accept it if there is
none.
---
Github user lvfangmin commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/601#discussion_r214131563
--- Diff:
src/java/test/org/apache/zookeeper/server/ZooKeeperServerMainTest.java ---
@@ -346,6 +353,211 @@ public void
testWithMinSessionTimeoutGreater
Github user lvfangmin commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/601#discussion_r214131395
--- Diff:
src/java/main/org/apache/zookeeper/metrics/impl/NullMetricsProvider.java ---
@@ -0,0 +1,100 @@
+/**
+ * Licensed to the Apache Softwar
Github user lvfangmin commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/601#discussion_r214131287
--- Diff:
src/java/main/org/apache/zookeeper/server/quorum/QuorumPeerConfig.java ---
@@ -325,6 +327,8 @@ public void parseProperties(Properties zkProp)
Github user lvfangmin commented on the issue:
https://github.com/apache/zookeeper/pull/610
@nkalmar the child node deletion problem is still there, which should be
solved in the other PR I sent out recently:
https://github.com/apache/zookeeper/pull/605.
When revisit that, I
Github user lvfangmin commented on the issue:
https://github.com/apache/zookeeper/pull/611
@wangchaod just send another PR for removing the watcher when closing netty
cnxn: https://github.com/apache/zookeeper/pull/612.
As I mentioned, this will also be fixed in PR of ZOOKEEPER
GitHub user lvfangmin opened a pull request:
https://github.com/apache/zookeeper/pull/612
[ZOOKEEPER-3131] Remove watcher when session closed in NettyServerCnxn
Currently, it doesn't remove itself from ZK server when the cnxn is closed,
which
will leak watchers, close it to make
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16597594#comment-16597594
]
Fangmin Lv commented on ZOOKEEPER-3131:
---
This one will be fixed if the ongoing
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3131?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Fangmin Lv updated ZOOKEEPER-3131:
--
Affects Version/s: 3.6.0
> org.apache.zookeeper.server.WatchManager resource leak
> ---
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16597590#comment-16597590
]
Fangmin Lv commented on ZOOKEEPER-3131:
---
[~hw_wangchao] it was by design to lea
Github user lordofkey commented on the issue:
https://github.com/apache/zookeeper/pull/586
utf-8 encoding is now implemented before passed to a char pointer.
---
Hi Michael,
Yes, there is a plan to have one more step, which will introduce
zookeeper-server and zookeeper-common top level directory, and
zookeeper-client-java under zookeeper-client.
See ZOOKEEPER-3032 for an outlined final structure.
Regards,
Norbert
On Wed, Aug 29, 2018 at 10:15 PM Michael
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16597194#comment-16597194
]
maoling commented on ZOOKEEPER-2284:
[~arshad.mohammad]
Are you still working on
17 matches
Mail list logo
