anmolnar commented on issue #735: ZOOKEEPER-3209: New `getEphemerals` api to
get all the ephemeral nodes created by the session
URL: https://github.com/apache/zookeeper/pull/735#issuecomment-452978553
@dineshappavoo Feel free to skip updating the C client if you don't feel
confidence
anmolnar commented on issue #760: ZOOKEEPER-3215: Handle Java 9/11 additions of
covariant return types …
URL: https://github.com/apache/zookeeper/pull/760#issuecomment-452977671
@vivekpatani I tested it (cross-building with `--release 8` flag) on all
major branches:
- branch-3.4 works
First of all, these questions are more related to implementation details
rather than the Zab protocol itself. My answer thus is a reflection of the
current ZK implementation. Zab itself could be implemented differently
though.
>> When will the leader delete the message from its FIFO queue?
A
vivekpatani commented on issue #760: ZOOKEEPER-3215: Handle Java 9/11 additions
of covariant return types …
URL: https://github.com/apache/zookeeper/pull/760#issuecomment-452933177
@anmolnar it builds just fine, passes tests, it's more about return types
discrepancy post JDK9. Were you
dineshappavoo commented on issue #735: ZOOKEEPER-3209: New `getEphemerals` api
to get all the ephemeral nodes created by the session
URL: https://github.com/apache/zookeeper/pull/735#issuecomment-452926317
@anmolnar Thanks. We do not have the C implementation for this API yet. I do
feel
All updates to data in Zookeeper are modified to be idempotent before they
are accepted into the leader's queue. That means that items in the queue
can be committed in groups and once each group is acknowledged by a quorum
of servers, it can be deleted from the queue. Any server not in the
eolivelli commented on issue #764: WIP - ZOOKEEPER-3223: Configure Spotbugs -
on branch 3.4
URL: https://github.com/apache/zookeeper/pull/764#issuecomment-452883304
This patch is still not ready, on branch-3.4 we have new "bugs" not present
on 3.5 and 3.6.
I have to fix all of them
eolivelli opened a new pull request #764: WIP - ZOOKEEPER-3223: Configure
Spotbugs - on branch 3.4
URL: https://github.com/apache/zookeeper/pull/764
- add spotbugs configuration (default)
- make build pass spotbugs
Author: Enrico Olivelli
Reviewers: an...@apache.org
eolivelli opened a new pull request #763: ZOOKEEPER-3223: Configure Spotbugs
URL: https://github.com/apache/zookeeper/pull/763
- add spotbugs configuration (default)
- make build pass spotbugs
Author: Enrico Olivelli
Reviewers: an...@apache.org
Thank you guys for your support.
I leave this open for the community to decide, but if none of the
binding voters (committers, PMCs) respond in 1 week, I'll take
responsibility and commit the patches. I know holidays are still going
on, but 3.5 release is important we should make progress.
I agree with backporting Netty 4 and the related patches to 3.5.5.
+1 (non binding) (and I might have already voted)
If it took so long to release a stable 3.5, I don't think we should leave a
known bug in the system, which has such an impact (not supporting current
LTS java).
The PRs shouldn't
Il giorno mer 9 gen 2019 alle ore 21:16 Andor Molnar
ha scritto:
>
> So, you guys saying we should upgrade to Netty 4 and backport the following
> patches too:
>
> ZOOKEEPER-3131 org.apache.zookeeper.server.WatchManager resource leak
> ZOOKEEPER-3163 Use session map to improve the performance
So, you guys saying we should upgrade to Netty 4 and backport the following
patches too:
ZOOKEEPER-3131 org.apache.zookeeper.server.WatchManager resource leak
ZOOKEEPER-3163 Use session map to improve the performance when closing session
in Netty
ZOOKEEPER-3146 Limit the maximum client
anmolnar commented on issue #753: ZOOKEEPER-3204: Reconfig tests are constantly
failing on 3.5 after applying Java 11 fix
URL: https://github.com/apache/zookeeper/pull/753#issuecomment-452838938
retest this please
This is an
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16738575#comment-16738575
]
Hudson commented on ZOOKEEPER-3235:
---
SUCCESS: Integrated in Jenkins build
Hi,
I have a question about the leader-based atomic broadcast used in ZooKeeper.
According to the Zab paper "A simple totally ordered broadcast
protocol"[1], the protocol has the requirement of reliable delivery:
If a message is delivered to one server, it will be eventually
delivered by all
Jie Huang created ZOOKEEPER-3239:
Summary: Adding EnsembleAuthProvider to verify the ensemble name
Key: ZOOKEEPER-3239
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3239
Project: ZooKeeper
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16738456#comment-16738456
]
Hudson commented on ZOOKEEPER-3235:
---
SUCCESS: Integrated in Jenkins build ZooKeeper-trunk #343 (See
anmolnar commented on issue #760: ZOOKEEPER-3215: Handle Java 9/11 additions of
covariant return types …
URL: https://github.com/apache/zookeeper/pull/760#issuecomment-452735551
https://openjdk.java.net/jeps/247
This is an
anmolnar edited a comment on issue #760: ZOOKEEPER-3215: Handle Java 9/11
additions of covariant return types …
URL: https://github.com/apache/zookeeper/pull/760#issuecomment-452734142
@vivekpatani Since Java 9 there's a `--release` switch for the javac
compiler which sets the "source",
anmolnar commented on issue #760: ZOOKEEPER-3215: Handle Java 9/11 additions of
covariant return types …
URL: https://github.com/apache/zookeeper/pull/760#issuecomment-452734142
@vivekpatani Since Java 1.9 there's a `--release` switch for the javac
compiler which sets the "source",
nkalmar closed pull request #759: MAVEN MIGRATION - 3.4 - ZOOKEEPER-3226
URL: https://github.com/apache/zookeeper/pull/759
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull
anmolnar commented on issue #716: Enable secure processing and disallow DTDs in
the SAXParserFactory
URL: https://github.com/apache/zookeeper/pull/716#issuecomment-452709048
Committed to 3.5 and master branches.
Thanks @coheigea !
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3235?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andor Molnar resolved ZOOKEEPER-3235.
-
Resolution: Fixed
Fix Version/s: 3.5.5
3.6.0
Issue
asfgit closed pull request #716: Enable secure processing and disallow DTDs in
the SAXParserFactory
URL: https://github.com/apache/zookeeper/pull/716
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of
anmolnar commented on issue #759: MAVEN MIGRATION - 3.4 - ZOOKEEPER-3226
URL: https://github.com/apache/zookeeper/pull/759#issuecomment-452707628
Merged to 3.4 branch. Please close this PR.
Thanks @nkalmar !
This is an
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3238?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated ZOOKEEPER-3238:
--
Labels: pull-request-available (was: )
> Add rel="noopener noreferrer" to target
coheigea opened a new pull request #762: ZOOKEEPER-3238 - Adding noreferrer to
target blank link
URL: https://github.com/apache/zookeeper/pull/762
In zookeeper-contrib-huebrowser, there is a link that uses target="_blank".
Best security practise is to also add rel="noopener noreferrer".
Colm O hEigeartaigh created ZOOKEEPER-3238:
--
Summary: Add rel="noopener noreferrer" to target blank link in
zookeeper-contrib-huebrowser
Key: ZOOKEEPER-3238
URL:
nkalmar closed pull request #758: MAVEN MIGRATION - 3.5 - ZOOKEEPER-3226
URL: https://github.com/apache/zookeeper/pull/758
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull
anmolnar commented on issue #630: ZOOKEEPER-2284:LogFormatter and
SnapshotFormatter does not handle FileNotFoundException gracefully
URL: https://github.com/apache/zookeeper/pull/630#issuecomment-452650187
Thanks for the heads-up @maoling .
Please move the test file to
31 matches
Mail list logo
