[GitHub] tamaashu commented on a change in pull request #801: Fix ZOOKEEPER-2625: Introduce explicit end-of-line setting for shell scripts

tamaashu commented on a change in pull request #801: Fix ZOOKEEPER-2625: Introduce explicit end-of-line setting for shell scripts URL: https://github.com/apache/zookeeper/pull/801#discussion_r253795508 ## File path: bin/.gitattributes ## @@ -0,0 +1 @@ +*.sh eol=lf Revie

[GitHub] nkalmar commented on issue #802: ZOOKEEPER-3122 - Bugfix - Change maven java target versions to 1.6

nkalmar commented on issue #802: ZOOKEEPER-3122 - Bugfix - Change maven java target versions to 1.6 URL: https://github.com/apache/zookeeper/pull/802#issuecomment-460577667 Ooh, I'm looking into this... This is an automated m

Re: Error in windows build

Sorry, I wasn’t clear: I saw it happened in a failing windows Jenkins job. Since then it has already been recovered, so maybe it’s not a big deal. Thanks, Andor > On 2019. Feb 4., at 23:39, Enrico Olivelli wrote: > > No, sorry > I will check. > > If we are supporting Windows build we should

[jira] [Assigned] (ZOOKEEPER-3034) Facing issues while building from source

[ https://issues.apache.org/jira/browse/ZOOKEEPER-3034?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Balazs Meszaros reassigned ZOOKEEPER-3034: -- Assignee: Balazs Meszaros (was: Andor Molnar) > Facing issues while build

[jira] [Reopened] (ZOOKEEPER-3034) Facing issues while building from source

[ https://issues.apache.org/jira/browse/ZOOKEEPER-3034?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Balazs Meszaros reopened ZOOKEEPER-3034: > Facing issues while building from source > --

[GitHub] meszibalu opened a new pull request #803: ZOOKEEPER-3034: Facing issues while building from source

meszibalu opened a new pull request #803: ZOOKEEPER-3034: Facing issues while building from source URL: https://github.com/apache/zookeeper/pull/803 Added a new macro (CHECK_CPPUNIT) which tries to use AM_PATH_CPPUNIT or PKG_CHECK_MODULES. ---

[GitHub] anmolnar commented on issue #803: ZOOKEEPER-3034: Facing issues while building from source

anmolnar commented on issue #803: ZOOKEEPER-3034: Facing issues while building from source URL: https://github.com/apache/zookeeper/pull/803#issuecomment-460624439 Thanks @meszibalu for the contribution. @phunt You might want to take a look at this issue: I failed to fix Ubuntu 18.

[GitHub] nkalmar commented on issue #802: ZOOKEEPER-3122 - Bugfix - Change maven java target versions to 1.6

nkalmar commented on issue #802: ZOOKEEPER-3122 - Bugfix - Change maven java target versions to 1.6 URL: https://github.com/apache/zookeeper/pull/802#issuecomment-460624551 Right, so on 3.4 we only run the tests on 1 thread. Modified the pom. --

[GitHub] asfgit commented on issue #802: ZOOKEEPER-3122 - Bugfix - Change maven java target versions to 1.6

asfgit commented on issue #802: ZOOKEEPER-3122 - Bugfix - Change maven java target versions to 1.6 URL: https://github.com/apache/zookeeper/pull/802#issuecomment-460655148 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/PreCom

[GitHub] anmolnar commented on issue #803: ZOOKEEPER-3034: Facing issues while building from source

anmolnar commented on issue #803: ZOOKEEPER-3034: Facing issues while building from source URL: https://github.com/apache/zookeeper/pull/803#issuecomment-460661098 retest this please This is an automated message from the Apac

[GitHub] anmolnar commented on a change in pull request #753: ZOOKEEPER-3204: Reconfig tests are constantly failing on 3.5 after applying Java 11 fix

anmolnar commented on a change in pull request #753: ZOOKEEPER-3204: Reconfig tests are constantly failing on 3.5 after applying Java 11 fix URL: https://github.com/apache/zookeeper/pull/753#discussion_r253893080 ## File path: zookeeper-server/src/main/java/org/apache/zookeeper/Cli

Re: Pull requests validation - Maven is active - heads up!

Great, thanks! One question: 3.4 builds are failing. It's because we run the tests on 1 thread. I modified the main pom.xml's fork count to 1, but it looks like it is still running parallel. Do you override forkcount on the job? (I can't see Jenkins config). It should be changed to 1, as PortAssig

[GitHub] anmolnar commented on a change in pull request #753: ZOOKEEPER-3204: Reconfig tests are constantly failing on 3.5 after applying Java 11 fix

anmolnar commented on a change in pull request #753: ZOOKEEPER-3204: Reconfig tests are constantly failing on 3.5 after applying Java 11 fix URL: https://github.com/apache/zookeeper/pull/753#discussion_r253894010 ## File path: zookeeper-server/src/main/java/org/apache/zookeeper/ser

[GitHub] anmolnar commented on a change in pull request #753: ZOOKEEPER-3204: Reconfig tests are constantly failing on 3.5 after applying Java 11 fix

anmolnar commented on a change in pull request #753: ZOOKEEPER-3204: Reconfig tests are constantly failing on 3.5 after applying Java 11 fix URL: https://github.com/apache/zookeeper/pull/753#discussion_r253894823 ## File path: zookeeper-server/src/main/java/org/apache/zookeeper/ser

[GitHub] anmolnar commented on a change in pull request #753: ZOOKEEPER-3204: Reconfig tests are constantly failing on 3.5 after applying Java 11 fix

anmolnar commented on a change in pull request #753: ZOOKEEPER-3204: Reconfig tests are constantly failing on 3.5 after applying Java 11 fix URL: https://github.com/apache/zookeeper/pull/753#discussion_r253896039 ## File path: zookeeper-server/src/main/java/org/apache/zookeeper/ser

[GitHub] anmolnar commented on a change in pull request #753: ZOOKEEPER-3204: Reconfig tests are constantly failing on 3.5 after applying Java 11 fix

anmolnar commented on a change in pull request #753: ZOOKEEPER-3204: Reconfig tests are constantly failing on 3.5 after applying Java 11 fix URL: https://github.com/apache/zookeeper/pull/753#discussion_r253897324 ## File path: zookeeper-server/src/main/java/org/apache/zookeeper/ser

[GitHub] anmolnar commented on a change in pull request #753: ZOOKEEPER-3204: Reconfig tests are constantly failing on 3.5 after applying Java 11 fix

anmolnar commented on a change in pull request #753: ZOOKEEPER-3204: Reconfig tests are constantly failing on 3.5 after applying Java 11 fix URL: https://github.com/apache/zookeeper/pull/753#discussion_r253897440 ## File path: zookeeper-server/src/main/java/org/apache/zookeeper/ser

[GitHub] anmolnar commented on a change in pull request #753: ZOOKEEPER-3204: Reconfig tests are constantly failing on 3.5 after applying Java 11 fix

anmolnar commented on a change in pull request #753: ZOOKEEPER-3204: Reconfig tests are constantly failing on 3.5 after applying Java 11 fix URL: https://github.com/apache/zookeeper/pull/753#discussion_r253897619 ## File path: zookeeper-server/src/main/java/org/apache/zookeeper/ser

[GitHub] anmolnar commented on a change in pull request #753: ZOOKEEPER-3204: Reconfig tests are constantly failing on 3.5 after applying Java 11 fix

anmolnar commented on a change in pull request #753: ZOOKEEPER-3204: Reconfig tests are constantly failing on 3.5 after applying Java 11 fix URL: https://github.com/apache/zookeeper/pull/753#discussion_r253897553 ## File path: zookeeper-server/src/main/java/org/apache/zookeeper/ser

[GitHub] anmolnar commented on a change in pull request #753: ZOOKEEPER-3204: Reconfig tests are constantly failing on 3.5 after applying Java 11 fix

anmolnar commented on a change in pull request #753: ZOOKEEPER-3204: Reconfig tests are constantly failing on 3.5 after applying Java 11 fix URL: https://github.com/apache/zookeeper/pull/753#discussion_r253898138 ## File path: zookeeper-server/src/main/java/org/apache/zookeeper/ser

[GitHub] anmolnar edited a comment on issue #753: ZOOKEEPER-3204: Reconfig tests are constantly failing on 3.5 after applying Java 11 fix

anmolnar edited a comment on issue #753: ZOOKEEPER-3204: Reconfig tests are constantly failing on 3.5 after applying Java 11 fix URL: https://github.com/apache/zookeeper/pull/753#issuecomment-460668746 @ivmaykov I've addressed your comments. Please review. -

[GitHub] anmolnar commented on issue #753: ZOOKEEPER-3204: Reconfig tests are constantly failing on 3.5 after applying Java 11 fix

anmolnar commented on issue #753: ZOOKEEPER-3204: Reconfig tests are constantly failing on 3.5 after applying Java 11 fix URL: https://github.com/apache/zookeeper/pull/753#issuecomment-460668746 @ivmaykov I've address your comments. Please review. --

Re: Pull requests validation - Maven is active - heads up!

Il giorno mar 5 feb 2019, 15:47 Norbert Kalmar ha scritto: > Great, thanks! > > One question: 3.4 builds are failing. It's because we run the tests on 1 > thread. I modified the main pom.xml's fork count to 1, but it looks like it > is still running parallel. Do you override forkcount on the job?

[GitHub] asfgit commented on issue #799: ZOOKEEPER-3269 - Add queueEvent to the Testable facade

asfgit commented on issue #799: ZOOKEEPER-3269 - Add queueEvent to the Testable facade URL: https://github.com/apache/zookeeper/pull/799#issuecomment-460682271 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/PreCommit-ZOOKEEPE

[GitHub] anmolnar commented on issue #753: ZOOKEEPER-3204: Reconfig tests are constantly failing on 3.5 after applying Java 11 fix

anmolnar commented on issue #753: ZOOKEEPER-3204: Reconfig tests are constantly failing on 3.5 after applying Java 11 fix URL: https://github.com/apache/zookeeper/pull/753#issuecomment-460685586 retest this please This is an

[GitHub] asfgit commented on issue #753: ZOOKEEPER-3204: Reconfig tests are constantly failing on 3.5 after applying Java 11 fix

asfgit commented on issue #753: ZOOKEEPER-3204: Reconfig tests are constantly failing on 3.5 after applying Java 11 fix URL: https://github.com/apache/zookeeper/pull/753#issuecomment-460692018 Refer to this link for build results (access rights to CI server needed): https://builds.

[GitHub] maoling commented on issue #790: ZOOKEEPER-3167:add an API and the corresponding CLI to get total count of recursive sub nodes under a specific path

maoling commented on issue #790: ZOOKEEPER-3167:add an API and the corresponding CLI to get total count of recursive sub nodes under a specific path URL: https://github.com/apache/zookeeper/pull/790#issuecomment-460693109 @dineshappavoo Yes,We should doc this new API,just as I said in

[GitHub] Randgalt commented on issue #799: ZOOKEEPER-3269 - Add queueEvent to the Testable facade

Randgalt commented on issue #799: ZOOKEEPER-3269 - Add queueEvent to the Testable facade URL: https://github.com/apache/zookeeper/pull/799#issuecomment-460693894 That test failure has nothing to do with this PR BTW This is an

ZooKeeper_branch34_openjdk7 - Build # 2202 - Still Failing

See https://builds.apache.org/job/ZooKeeper_branch34_openjdk7/2202/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 8.71 KB...] hudson.plugins.git.GitException: Fa

[GitHub] eolivelli commented on issue #799: ZOOKEEPER-3269 - Add queueEvent to the Testable facade

eolivelli commented on issue #799: ZOOKEEPER-3269 - Add queueEvent to the Testable facade URL: https://github.com/apache/zookeeper/pull/799#issuecomment-460708290 Off topic: @anmolnar @nkalmar should we disable "contrib" tests ? the 'full-build' profile runs java + contribs + cpp

[GitHub] anmolnar commented on issue #753: ZOOKEEPER-3204: Reconfig tests are constantly failing on 3.5 after applying Java 11 fix

anmolnar commented on issue #753: ZOOKEEPER-3204: Reconfig tests are constantly failing on 3.5 after applying Java 11 fix URL: https://github.com/apache/zookeeper/pull/753#issuecomment-460712366 @ivmaykov Not specific to this pull request, but I'm trying to set up and SSL enabled quorum lo

[GitHub] anmolnar commented on issue #753: ZOOKEEPER-3204: Reconfig tests are constantly failing on 3.5 after applying Java 11 fix

anmolnar commented on issue #753: ZOOKEEPER-3204: Reconfig tests are constantly failing on 3.5 after applying Java 11 fix URL: https://github.com/apache/zookeeper/pull/753#issuecomment-460727808 I'll probably open a separate Jira/pull request for this, but I've just come up with this durin

[GitHub] anmolnar commented on issue #799: ZOOKEEPER-3269 - Add queueEvent to the Testable facade

anmolnar commented on issue #799: ZOOKEEPER-3269 - Add queueEvent to the Testable facade URL: https://github.com/apache/zookeeper/pull/799#issuecomment-460728441 @Randgalt use the brand new magic words: retest this please to kick off a new build @eolivelli Yes please. java + cp

[GitHub] Randgalt commented on issue #799: ZOOKEEPER-3269 - Add queueEvent to the Testable facade

Randgalt commented on issue #799: ZOOKEEPER-3269 - Add queueEvent to the Testable facade URL: https://github.com/apache/zookeeper/pull/799#issuecomment-460728759 retest this please This is an automated message from the Apache

[GitHub] Randgalt removed a comment on issue #799: ZOOKEEPER-3269 - Add queueEvent to the Testable facade

Randgalt removed a comment on issue #799: ZOOKEEPER-3269 - Add queueEvent to the Testable facade URL: https://github.com/apache/zookeeper/pull/799#issuecomment-460728759 retest this please This is an automated message from th

[GitHub] asfgit commented on issue #799: ZOOKEEPER-3269 - Add queueEvent to the Testable facade

asfgit commented on issue #799: ZOOKEEPER-3269 - Add queueEvent to the Testable facade URL: https://github.com/apache/zookeeper/pull/799#issuecomment-460737044 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/PreCommit-ZOOKEEPE

ZooKeeper-trunk-windows-cmake - Build # 3169 - Failure

See https://builds.apache.org/job/ZooKeeper-trunk-windows-cmake/3169/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 8.57 KB...] [ivy:retrieve] found log4j#log4j

[GitHub] ivmaykov commented on a change in pull request #753: ZOOKEEPER-3204: Reconfig tests are constantly failing on 3.5 after applying Java 11 fix

ivmaykov commented on a change in pull request #753: ZOOKEEPER-3204: Reconfig tests are constantly failing on 3.5 after applying Java 11 fix URL: https://github.com/apache/zookeeper/pull/753#discussion_r254014628 ## File path: zookeeper-server/src/main/java/org/apache/zookeeper/ser

[GitHub] ivmaykov commented on issue #753: ZOOKEEPER-3204: Reconfig tests are constantly failing on 3.5 after applying Java 11 fix

ivmaykov commented on issue #753: ZOOKEEPER-3204: Reconfig tests are constantly failing on 3.5 after applying Java 11 fix URL: https://github.com/apache/zookeeper/pull/753#issuecomment-460773536 > @ivmaykov Not specific to this pull request, but I'm trying to set up and SSL enabled quorum

[GitHub] eolivelli commented on issue #799: ZOOKEEPER-3269 - Add queueEvent to the Testable facade

eolivelli commented on issue #799: ZOOKEEPER-3269 - Add queueEvent to the Testable facade URL: https://github.com/apache/zookeeper/pull/799#issuecomment-460777508 @anmolnar we have new magic words.. https://cwiki.apache.org/confluence/display/ZOOKEEPER/HowToContribute retest maven

[GitHub] normanmaurer commented on issue #753: ZOOKEEPER-3204: Reconfig tests are constantly failing on 3.5 after applying Java 11 fix

normanmaurer commented on issue #753: ZOOKEEPER-3204: Reconfig tests are constantly failing on 3.5 after applying Java 11 fix URL: https://github.com/apache/zookeeper/pull/753#issuecomment-460778431 Just a heads-up... I have blocked time for tomorrow to review this and give some feedback.

[GitHub] asfgit commented on issue #799: ZOOKEEPER-3269 - Add queueEvent to the Testable facade

asfgit commented on issue #799: ZOOKEEPER-3269 - Add queueEvent to the Testable facade URL: https://github.com/apache/zookeeper/pull/799#issuecomment-460779989 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/PreCommit-ZOOKEEPE

[GitHub] ivmaykov commented on issue #753: ZOOKEEPER-3204: Reconfig tests are constantly failing on 3.5 after applying Java 11 fix

ivmaykov commented on issue #753: ZOOKEEPER-3204: Reconfig tests are constantly failing on 3.5 after applying Java 11 fix URL: https://github.com/apache/zookeeper/pull/753#issuecomment-460790256 @anmolnar this looks fine to me but let's wait for @normanmaurer since he is going to review to

[GitHub] ivmaykov edited a comment on issue #753: ZOOKEEPER-3204: Reconfig tests are constantly failing on 3.5 after applying Java 11 fix

ivmaykov edited a comment on issue #753: ZOOKEEPER-3204: Reconfig tests are constantly failing on 3.5 after applying Java 11 fix URL: https://github.com/apache/zookeeper/pull/753#issuecomment-460790256 @anmolnar this looks fine to me but let's wait for @normanmaurer since he is going to re

[GitHub] anmolnar commented on a change in pull request #753: ZOOKEEPER-3204: Reconfig tests are constantly failing on 3.5 after applying Java 11 fix

anmolnar commented on a change in pull request #753: ZOOKEEPER-3204: Reconfig tests are constantly failing on 3.5 after applying Java 11 fix URL: https://github.com/apache/zookeeper/pull/753#discussion_r254036966 ## File path: zookeeper-server/src/main/java/org/apache/zookeeper/ser

[GitHub] ivmaykov commented on issue #753: ZOOKEEPER-3204: Reconfig tests are constantly failing on 3.5 after applying Java 11 fix

ivmaykov commented on issue #753: ZOOKEEPER-3204: Reconfig tests are constantly failing on 3.5 after applying Java 11 fix URL: https://github.com/apache/zookeeper/pull/753#issuecomment-460798745 +1 (non-binding) This is an au

[GitHub] ivmaykov edited a comment on issue #753: ZOOKEEPER-3204: Reconfig tests are constantly failing on 3.5 after applying Java 11 fix

ivmaykov edited a comment on issue #753: ZOOKEEPER-3204: Reconfig tests are constantly failing on 3.5 after applying Java 11 fix URL: https://github.com/apache/zookeeper/pull/753#issuecomment-460798745 +1 (non-binding), assuming ZOOKEEPER-3131 gets backported as well --

[GitHub] anmolnar opened a new pull request #804: ZOOKEEPER-3131: Remove watcher when session closed in NettyServerCnxn

anmolnar opened a new pull request #804: ZOOKEEPER-3131: Remove watcher when session closed in NettyServerCnxn URL: https://github.com/apache/zookeeper/pull/804 Backport of https://github.com/apache/zookeeper/commit/95557a30edbdfdf4479a1cb142e0d82a4ba6061d

[GitHub] anmolnar commented on issue #804: ZOOKEEPER-3131: Remove watcher when session closed in NettyServerCnxn

anmolnar commented on issue #804: ZOOKEEPER-3131: Remove watcher when session closed in NettyServerCnxn URL: https://github.com/apache/zookeeper/pull/804#issuecomment-460807025 @ivmaykov Here you are. This is an automated mes

[GitHub] ivmaykov commented on issue #804: ZOOKEEPER-3131: Remove watcher when session closed in NettyServerCnxn

ivmaykov commented on issue #804: ZOOKEEPER-3131: Remove watcher when session closed in NettyServerCnxn URL: https://github.com/apache/zookeeper/pull/804#issuecomment-460811736 +1. If this is merged before #753 you will have to resolve merge conflicts, but that should be pretty simple to d

[GitHub] maoling commented on issue #361: ZOOKEEPER-2892: Improve lazy initialize and close stream for `PrepRequestProcessor`

maoling commented on issue #361: ZOOKEEPER-2892: Improve lazy initialize and close stream for `PrepRequestProcessor` URL: https://github.com/apache/zookeeper/pull/361#issuecomment-460911469 ping @anmolnar This is an automate