[GitHub] eolivelli commented on a change in pull request #796: ZOOKEEPER-3267: Add watcher metrics

2019-02-11 Thread GitBox
eolivelli commented on a change in pull request #796: ZOOKEEPER-3267: Add watcher metrics URL: https://github.com/apache/zookeeper/pull/796#discussion_r255818297 ## File path: zookeeper-server/src/main/java/org/apache/zookeeper/server/watch/WatcherCleaner.java ## @@ -106,

A big refactor for the documetations

2019-02-11 Thread Justin Ling Mao
Hi gugs:I'am working on doing a big refactor for the documetations.it aims to - 1.make a better reading experiences and help users know more about zookeeper quickly,as good as other projects' doc(e.g redis,hbase). - 2.have less changes to diff with the original docs as far as possible. - 3.solv

[GitHub] jhuan31 commented on issue #796: ZOOKEEPER-3267: Add watcher metrics

2019-02-11 Thread GitBox
jhuan31 commented on issue #796: ZOOKEEPER-3267: Add watcher metrics URL: https://github.com/apache/zookeeper/pull/796#issuecomment-462593340 Unit tests added. This is an automated message from the Apache Git Service. To respo

[jira] [Updated] (ZOOKEEPER-3276) Make X509UtilTest.testCreateSSLServerSocketWithPort less flaky

2019-02-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3276?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated ZOOKEEPER-3276: -- Labels: pull-request-available (was: ) > Make X509UtilTest.testCreateSSLServerSock

[GitHub] ivmaykov commented on issue #810: ZOOKEEPER-3274: Use CompositeByteBuf to queue data in NettyServerCnxn

2019-02-11 Thread GitBox
ivmaykov commented on issue #810: ZOOKEEPER-3274: Use CompositeByteBuf to queue data in NettyServerCnxn URL: https://github.com/apache/zookeeper/pull/810#issuecomment-462549994 @normanmaurer I modified the code to use the same CompositeByteBuf and just clear out the components. Would appre

[GitHub] ivmaykov opened a new pull request #816: ZOOKEEPER-3276: Make X509UtilTest.testCreateSSLServerSocketWithPort less flaky

2019-02-11 Thread GitBox
ivmaykov opened a new pull request #816: ZOOKEEPER-3276: Make X509UtilTest.testCreateSSLServerSocketWithPort less flaky URL: https://github.com/apache/zookeeper/pull/816 Pick the free port right before using it, so there is less time for another thread/process to grab it from under us. --

[jira] [Created] (ZOOKEEPER-3276) Make X509UtilTest.testCreateSSLServerSocketWithPort less flaky

2019-02-11 Thread Ilya Maykov (JIRA)
Ilya Maykov created ZOOKEEPER-3276: -- Summary: Make X509UtilTest.testCreateSSLServerSocketWithPort less flaky Key: ZOOKEEPER-3276 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3276 Project: Zoo

[GitHub] ivmaykov commented on issue #809: ZOOKEEPER-3272: Clean up netty4 code per Norman Maurer's review comments

2019-02-11 Thread GitBox
ivmaykov commented on issue #809: ZOOKEEPER-3272: Clean up netty4 code per Norman Maurer's review comments URL: https://github.com/apache/zookeeper/pull/809#issuecomment-462546183 Flaky test failure is unrelated ... can we just merge this? --

[GitHub] ivmaykov closed pull request #809: ZOOKEEPER-3272: Clean up netty4 code per Norman Maurer's review comments

2019-02-11 Thread GitBox
ivmaykov closed pull request #809: ZOOKEEPER-3272: Clean up netty4 code per Norman Maurer's review comments URL: https://github.com/apache/zookeeper/pull/809 This is an automated message from the Apache Git Service. To respo

[GitHub] ivmaykov opened a new pull request #809: ZOOKEEPER-3272: Clean up netty4 code per Norman Maurer's review comments

2019-02-11 Thread GitBox
ivmaykov opened a new pull request #809: ZOOKEEPER-3272: Clean up netty4 code per Norman Maurer's review comments URL: https://github.com/apache/zookeeper/pull/809 Netty4 code clean-up per the discussion in PR #753. This is a

[jira] [Commented] (ZOOKEEPER-3275) Fix release targets: package, tar, mvn-deploy

2019-02-11 Thread Nora B Clark (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16765460#comment-16765460 ] Nora B Clark commented on ZOOKEEPER-3275: - I can't close netbeans 8,1 updates

[GitHub] eolivelli commented on issue #815: ZOOKEEPER-3234: Add Travis-CI configuration file

2019-02-11 Thread GitBox
eolivelli commented on issue #815: ZOOKEEPER-3234: Add Travis-CI configuration file URL: https://github.com/apache/zookeeper/pull/815#issuecomment-462517462 @anmolnar @nkalmar I am trying to refine the configuration file. I have never seen a Travis build complete with success: - t

[GitHub] eolivelli opened a new pull request #815: ZOOKEEPER-3234: Add Travis-CI configuration file

2019-02-11 Thread GitBox
eolivelli opened a new pull request #815: ZOOKEEPER-3234: Add Travis-CI configuration file URL: https://github.com/apache/zookeeper/pull/815 This is a second trial to make the build pass on Travis This is an automated message

ZooKeeper and checkstyle

2019-02-11 Thread Enrico Olivelli
Hi, I did not notice that we already have checkstyle configuration in the ANT build. This is the command ant checkstyle Unfortunately we have hundreds of violations I think it will be a great step to re-enable checkstyle on master after we get a "stable" release of the 3.5 branch. I expect

Re: ZooKeeper_branch34_openjdk7 - Build # 2208 - Still Failing

2019-02-11 Thread Enrico Olivelli
Since we are going to release 3.4... Better to take a look to this error. Does any ring bell? It seems a Jenkins issue Enrico Il giorno lun 11 feb 2019, 19:09 Apache Jenkins Server < jenk...@builds.apache.org> ha scritto: > See https://builds.apache.org/job/ZooKeeper_branch34_openjdk7/2208/ >

ZooKeeper-trunk-windows-cmake - Build # 3185 - Failure

2019-02-11 Thread Apache Jenkins Server
See https://builds.apache.org/job/ZooKeeper-trunk-windows-cmake/3185/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 14.69 KB...] [move] Moving 1 file to f:

ZooKeeper_branch34_openjdk7 - Build # 2208 - Still Failing

2019-02-11 Thread Apache Jenkins Server
See https://builds.apache.org/job/ZooKeeper_branch34_openjdk7/2208/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 8.72 KB...] hudson.plugins.git.GitException: Fa

[GitHub] anmolnar commented on issue #809: ZOOKEEPER-3272: Clean up netty4 code per Norman Maurer's review comments

2019-02-11 Thread GitBox
anmolnar commented on issue #809: ZOOKEEPER-3272: Clean up netty4 code per Norman Maurer's review comments URL: https://github.com/apache/zookeeper/pull/809#issuecomment-462377690 @ivmaykov Now it's a unit test failure. Try to retest ant build --

[GitHub] anmolnar commented on issue #809: ZOOKEEPER-3272: Clean up netty4 code per Norman Maurer's review comments

2019-02-11 Thread GitBox
anmolnar commented on issue #809: ZOOKEEPER-3272: Clean up netty4 code per Norman Maurer's review comments URL: https://github.com/apache/zookeeper/pull/809#issuecomment-462377784 retest ant build This is an automated message

[jira] [Commented] (ZOOKEEPER-3028) Create assembly in pom.xml

2019-02-11 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16765072#comment-16765072 ] Hudson commented on ZOOKEEPER-3028: --- SUCCESS: Integrated in Jenkins build ZooKeeper

[jira] [Commented] (ZOOKEEPER-3028) Create assembly in pom.xml

2019-02-11 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16764935#comment-16764935 ] Hudson commented on ZOOKEEPER-3028: --- FAILURE: Integrated in Jenkins build Zookeeper

[GitHub] nkalmar opened a new pull request #814: ZOOKEEPER-3028: MAVEN MIGRATION - - Create maven assembly

2019-02-11 Thread GitBox
nkalmar opened a new pull request #814: ZOOKEEPER-3028: MAVEN MIGRATION - - Create maven assembly URL: https://github.com/apache/zookeeper/pull/814 Author: Norbert Kalmar Reviewers: an...@apache.org Closes #776 from nkalmar/ZK-3028 and squashes the following commits: c

[GitHub] nkalmar opened a new pull request #813: ZOOKEEPER-3028: MAVEN MIGRATION - 3.5 - Create maven assembly

2019-02-11 Thread GitBox
nkalmar opened a new pull request #813: ZOOKEEPER-3028: MAVEN MIGRATION - 3.5 - Create maven assembly URL: https://github.com/apache/zookeeper/pull/813 Author: Norbert Kalmar Reviewers: an...@apache.org Closes #776 from nkalmar/ZK-3028 and squashes the following commits:

[GitHub] anmolnar commented on issue #787: ZOOKEEPER-3253: client should not send requests with cxid=-4, -2, or -1

2019-02-11 Thread GitBox
anmolnar commented on issue #787: ZOOKEEPER-3253: client should not send requests with cxid=-4, -2, or -1 URL: https://github.com/apache/zookeeper/pull/787#issuecomment-462297767 @eolivelli 3.5.5 is fine, but 3.4.14 is already cut, I wouldn't touch it anymore. We can make an excepti

[GitHub] anmolnar commented on issue #776: MAVEN MIGRATION - ZOOKEEPER-3028 - Create maven assembly

2019-02-11 Thread GitBox
anmolnar commented on issue #776: MAVEN MIGRATION - ZOOKEEPER-3028 - Create maven assembly URL: https://github.com/apache/zookeeper/pull/776#issuecomment-462297430 Committed to master. Thanks @nkalmar ! This is an automated m

[GitHub] asfgit closed pull request #776: MAVEN MIGRATION - ZOOKEEPER-3028 - Create maven assembly

2019-02-11 Thread GitBox
asfgit closed pull request #776: MAVEN MIGRATION - ZOOKEEPER-3028 - Create maven assembly URL: https://github.com/apache/zookeeper/pull/776 This is an automated message from the Apache Git Service. To respond to the message,