[GitHub] eolivelli commented on issue #815: ZOOKEEPER-3234: Add Travis-CI configuration file

2019-02-22 Thread GitBox
eolivelli commented on issue #815: ZOOKEEPER-3234: Add Travis-CI configuration file URL: https://github.com/apache/zookeeper/pull/815#issuecomment-466309010 skip ci This is an automated message from the Apache Git Service. To

[GitHub] eolivelli commented on issue #815: ZOOKEEPER-3234: Add Travis-CI configuration file

2019-02-22 Thread GitBox
eolivelli commented on issue #815: ZOOKEEPER-3234: Add Travis-CI configuration file URL: https://github.com/apache/zookeeper/pull/815#issuecomment-466372386 @anmolnar @hanm Can you commit this patch, this way all of the pending PRs will have Travis green. cc @maoling -

[GitHub] eolivelli edited a comment on issue #815: ZOOKEEPER-3234: Add Travis-CI configuration file

2019-02-22 Thread GitBox
eolivelli edited a comment on issue #815: ZOOKEEPER-3234: Add Travis-CI configuration file URL: https://github.com/apache/zookeeper/pull/815#issuecomment-466372386 @anmolnar @hanm Can you commit this patch, this way all of the pending PRs will have Travis green. cc @maoling

[GitHub] eolivelli commented on issue #815: ZOOKEEPER-3234: Add Travis-CI configuration file

2019-02-22 Thread GitBox
eolivelli commented on issue #815: ZOOKEEPER-3234: Add Travis-CI configuration file URL: https://github.com/apache/zookeeper/pull/815#issuecomment-466372745 I can follow up with a new patch which builds the C client, on linux and MacOs, for Windows we need something else, like AppVeyor --

[GitHub] anmolnar closed pull request #718: ZOOKEEPER-1818: Correctly handle potentially inconsistent zxid/electionEpoch…

2019-02-22 Thread GitBox
anmolnar closed pull request #718: ZOOKEEPER-1818: Correctly handle potentially inconsistent zxid/electionEpoch… URL: https://github.com/apache/zookeeper/pull/718 This is an automated message from the Apache Git Service. To

[GitHub] asfgit closed pull request #815: ZOOKEEPER-3234: Add Travis-CI configuration file

2019-02-22 Thread GitBox
asfgit closed pull request #815: ZOOKEEPER-3234: Add Travis-CI configuration file URL: https://github.com/apache/zookeeper/pull/815 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] anmolnar commented on issue #815: ZOOKEEPER-3234: Add Travis-CI configuration file

2019-02-22 Thread GitBox
anmolnar commented on issue #815: ZOOKEEPER-3234: Add Travis-CI configuration file URL: https://github.com/apache/zookeeper/pull/815#issuecomment-46634 Committed to master. This is an automated message from the Apache Git

[GitHub] eolivelli opened a new pull request #829: ZOOKEEPER-3234: Add Travis-CI configuration file

2019-02-22 Thread GitBox
eolivelli opened a new pull request #829: ZOOKEEPER-3234: Add Travis-CI configuration file URL: https://github.com/apache/zookeeper/pull/829 Use Travis-CI in order to build ZooKeeper on multiple JDKs and run spotbugs on every supported JDK -

[GitHub] nkalmar commented on a change in pull request #828: Maven migration - ZOOKEEPER-3285 add convenience tar, assembly module and sha512 generation

2019-02-22 Thread GitBox
nkalmar commented on a change in pull request #828: Maven migration - ZOOKEEPER-3285 add convenience tar, assembly module and sha512 generation URL: https://github.com/apache/zookeeper/pull/828#discussion_r259322056 ## File path: zookeeper-assembly/src/main/assembly/source-package.x

[GitHub] nkalmar commented on a change in pull request #828: Maven migration - ZOOKEEPER-3285 add convenience tar, assembly module and sha512 generation

2019-02-22 Thread GitBox
nkalmar commented on a change in pull request #828: Maven migration - ZOOKEEPER-3285 add convenience tar, assembly module and sha512 generation URL: https://github.com/apache/zookeeper/pull/828#discussion_r259322056 ## File path: zookeeper-assembly/src/main/assembly/source-package.x

[GitHub] nkalmar commented on a change in pull request #828: Maven migration - ZOOKEEPER-3285 add convenience tar, assembly module and sha512 generation

2019-02-22 Thread GitBox
nkalmar commented on a change in pull request #828: Maven migration - ZOOKEEPER-3285 add convenience tar, assembly module and sha512 generation URL: https://github.com/apache/zookeeper/pull/828#discussion_r259322286 ## File path: zookeeper-assembly/src/main/assembly/bin-package.xml

[GitHub] anmolnar commented on a change in pull request #828: Maven migration - ZOOKEEPER-3285 add convenience tar, assembly module and sha512 generation

2019-02-22 Thread GitBox
anmolnar commented on a change in pull request #828: Maven migration - ZOOKEEPER-3285 add convenience tar, assembly module and sha512 generation URL: https://github.com/apache/zookeeper/pull/828#discussion_r259324240 ## File path: zookeeper-assembly/src/main/assembly/source-package.

[jira] [Commented] (ZOOKEEPER-95) There is no need to include the code generators in the zookeeper jar

2019-02-22 Thread Norbert Kalmar (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-95?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16775112#comment-16775112 ] Norbert Kalmar commented on ZOOKEEPER-95: - This is no longer an issue, plus mav

[jira] [Resolved] (ZOOKEEPER-95) There is no need to include the code generators in the zookeeper jar

2019-02-22 Thread Norbert Kalmar (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-95?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Norbert Kalmar resolved ZOOKEEPER-95. - Resolution: Done > There is no need to include the code generators in the zookeeper jar

[jira] [Commented] (ZOOKEEPER-98) Make the ZooKeeper optional bits seperate jars.

2019-02-22 Thread Norbert Kalmar (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-98?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16775116#comment-16775116 ] Norbert Kalmar commented on ZOOKEEPER-98: - As maven migration is just about to

[jira] [Resolved] (ZOOKEEPER-98) Make the ZooKeeper optional bits seperate jars.

2019-02-22 Thread Norbert Kalmar (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-98?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Norbert Kalmar resolved ZOOKEEPER-98. - Resolution: Done > Make the ZooKeeper optional bits seperate jars. > --

[GitHub] nkalmar commented on a change in pull request #828: Maven migration - ZOOKEEPER-3285 add convenience tar, assembly module and sha512 generation

2019-02-22 Thread GitBox
nkalmar commented on a change in pull request #828: Maven migration - ZOOKEEPER-3285 add convenience tar, assembly module and sha512 generation URL: https://github.com/apache/zookeeper/pull/828#discussion_r259322286 ## File path: zookeeper-assembly/src/main/assembly/bin-package.xml

[GitHub] anmolnar closed pull request #829: ZOOKEEPER-3234: Add Travis-CI configuration file

2019-02-22 Thread GitBox
anmolnar closed pull request #829: ZOOKEEPER-3234: Add Travis-CI configuration file URL: https://github.com/apache/zookeeper/pull/829 This is an automated message from the Apache Git Service. To respond to the message, pleas

[GitHub] anmolnar commented on issue #829: ZOOKEEPER-3234: Add Travis-CI configuration file

2019-02-22 Thread GitBox
anmolnar commented on issue #829: ZOOKEEPER-3234: Add Travis-CI configuration file URL: https://github.com/apache/zookeeper/pull/829#issuecomment-466422749 Merged to 3.5 and 3.4 branches. Thanks @eolivelli ! This is an automa

[GitHub] eolivelli opened a new pull request #830: ZOOKEEPER-3234: Add Travis-CI configuration file

2019-02-22 Thread GitBox
eolivelli opened a new pull request #830: ZOOKEEPER-3234: Add Travis-CI configuration file URL: https://github.com/apache/zookeeper/pull/830 This is an automated message from the Apache Git Service. To respond to the message

[GitHub] eolivelli commented on a change in pull request #830: ZOOKEEPER-3234: Add Travis-CI configuration file

2019-02-22 Thread GitBox
eolivelli commented on a change in pull request #830: ZOOKEEPER-3234: Add Travis-CI configuration file URL: https://github.com/apache/zookeeper/pull/830#discussion_r259381134 ## File path: .travis.yml ## @@ -13,3 +13,5 @@ script: mvn clean install -DskipTests spotbugs:chec

Re: [VOTE] Apache ZooKeeper release 3.4.14 candidate 3

2019-02-22 Thread Norbert Kalmar
Thanks Andor, +1 ! Signatures: OK ant package : OK ant bin-package - OK ant tar : OK Tests (test-core): OK Running ZooKeeper from untared artifact and doing some basic commands - OK Building ZooKeeper from source - OK Running ZooKeeper from built source and doing basic commands - OK Al

[GitHub] asfgit closed pull request #830: ZOOKEEPER-3234: Add Travis-CI configuration file

2019-02-22 Thread GitBox
asfgit closed pull request #830: ZOOKEEPER-3234: Add Travis-CI configuration file URL: https://github.com/apache/zookeeper/pull/830 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] anmolnar commented on issue #830: ZOOKEEPER-3234: Add Travis-CI configuration file

2019-02-22 Thread GitBox
anmolnar commented on issue #830: ZOOKEEPER-3234: Add Travis-CI configuration file URL: https://github.com/apache/zookeeper/pull/830#issuecomment-466435403 Merged to master. Thanks @eolivelli ! This is an automated message fr

Re: [VOTE] Apache ZooKeeper release 3.4.14 candidate 3

2019-02-22 Thread Enrico Olivelli
+1 (non binding) Built with Ant on Fedora 28 and Oracle JDK 8 Java test OK (Oracke JDK 8) verified checksums and signatures (even the one inside the tarball) run smoke tests with a cluster of 3 servers and two clients, bouncing the leader a couple of times all seems running as expected from logs

Travis is Up an running

2019-02-22 Thread Enrico Olivelli
Hi folks, Andor merged the patch about Travis configuration, let me recap the status quo about Pull Requests. 1) We are using Travis to test the build on JDK8 and JDK11 + spotbugs (which has differents results on different JDK versions), using Maven - in order to make Travis restart you have to lo

Re: Travis is Up an running

2019-02-22 Thread Norbert Kalmar
Great work Enrico, thank you! I really like these additions, especially that they show up as seperate checks on the PR, and can be restarted individually. Regards, Norbert On Fri, Feb 22, 2019 at 4:42 PM Enrico Olivelli wrote: > Hi folks, > Andor merged the patch about Travis configuration, let

[jira] [Commented] (ZOOKEEPER-3234) Add Travis-CI configuration file

2019-02-22 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16775291#comment-16775291 ] Hudson commented on ZOOKEEPER-3234: --- SUCCESS: Integrated in Jenkins build Zookeeper

[jira] [Commented] (ZOOKEEPER-3234) Add Travis-CI configuration file

2019-02-22 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16775315#comment-16775315 ] Hudson commented on ZOOKEEPER-3234: --- SUCCESS: Integrated in Jenkins build ZooKeeper

Re: Travis is Up an running

2019-02-22 Thread Andor Molnar
Awesome work Enrico! Thanks Andor On Fri, Feb 22, 2019 at 4:46 PM Norbert Kalmar wrote: > Great work Enrico, thank you! > I really like these additions, especially that they show up as seperate > checks on the PR, and can be restarted individually. > > Regards, > Norbert > > On Fri, Feb 22, 2

[GitHub] ccma14 opened a new pull request #831: ZOOKEEPER-3286: xid wrap-around causes connection loss/segfault when hitting predefined XIDs

2019-02-22 Thread GitBox
ccma14 opened a new pull request #831: ZOOKEEPER-3286: xid wrap-around causes connection loss/segfault when hitting predefined XIDs URL: https://github.com/apache/zookeeper/pull/831 I just saw ZOOKEEPER-3253, which seems to fix the issue for the Java client. This fixes the issue for the

[jira] [Updated] (ZOOKEEPER-3286) xid wrap-around causes connection loss/segfault when hitting predefined XIDs

2019-02-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3286?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated ZOOKEEPER-3286: -- Labels: pull-request-available (was: ) > xid wrap-around causes connection loss/se

[GitHub] ccma14 commented on issue #831: ZOOKEEPER-3286: xid wrap-around causes connection loss/segfault when hitting predefined XIDs

2019-02-22 Thread GitBox
ccma14 commented on issue #831: ZOOKEEPER-3286: xid wrap-around causes connection loss/segfault when hitting predefined XIDs URL: https://github.com/apache/zookeeper/pull/831#issuecomment-466559790 Regarding an automated test case: In the C client the XID counter is stored in a stati

[jira] [Commented] (ZOOKEEPER-3234) Add Travis-CI configuration file

2019-02-22 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16775725#comment-16775725 ] Hudson commented on ZOOKEEPER-3234: --- SUCCESS: Integrated in Jenkins build Zookeeper