[GitHub] [zookeeper] ZWShuai91 closed pull request #864: ZOOKEEPER-3299:'setquota -n|-b val path' needs a brackets

2019-03-21 Thread GitBox
ZWShuai91 closed pull request #864: ZOOKEEPER-3299:'setquota -n|-b val path' needs a brackets URL: https://github.com/apache/zookeeper/pull/864 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [zookeeper] ZWShuai91 commented on a change in pull request #864: ZOOKEEPER-3299:'setquota -n|-b val path' needs a brackets

2019-03-21 Thread GitBox
ZWShuai91 commented on a change in pull request #864: ZOOKEEPER-3299:'setquota -n|-b val path' needs a brackets URL: https://github.com/apache/zookeeper/pull/864#discussion_r268022907 ## File path: zookeeper-docs/src/main/resources/markdown/zookeeperStarted.md ## @@

[GitHub] [zookeeper] maoling commented on a change in pull request #864: ZOOKEEPER-3299:'setquota -n|-b val path' needs a brackets

2019-03-21 Thread GitBox
maoling commented on a change in pull request #864: ZOOKEEPER-3299:'setquota -n|-b val path' needs a brackets URL: https://github.com/apache/zookeeper/pull/864#discussion_r268017149 ## File path: zookeeper-docs/src/main/resources/markdown/zookeeperStarted.md ## @@ -166,7

[GitHub] [zookeeper] maoling commented on issue #865: zoo_sample.cfg: enable autopurge and change dataDir

2019-03-21 Thread GitBox
maoling commented on issue #865: zoo_sample.cfg: enable autopurge and change dataDir URL: https://github.com/apache/zookeeper/pull/865#issuecomment-475473548 - `autopurge.purgeInterval` should be turned off by default, otherwise it will have a very serious side effect(especially disk io)

[GitHub] [zookeeper] maoling commented on a change in pull request #864: ZOOKEEPER-3299:'setquota -n|-b val path' needs a brackets

2019-03-21 Thread GitBox
maoling commented on a change in pull request #864: ZOOKEEPER-3299:'setquota -n|-b val path' needs a brackets URL: https://github.com/apache/zookeeper/pull/864#discussion_r268017149 ## File path: zookeeper-docs/src/main/resources/markdown/zookeeperStarted.md ## @@ -166,7

[GitHub] [zookeeper] enixon commented on a change in pull request #863: ZOOKEEPER-3320: Leader election port stop listen when hostname unresolvable for some time

2019-03-21 Thread GitBox
enixon commented on a change in pull request #863: ZOOKEEPER-3320: Leader election port stop listen when hostname unresolvable for some time URL: https://github.com/apache/zookeeper/pull/863#discussion_r267946154 ## File path:

[jira] [Commented] (ZOOKEEPER-3327) Add unrecoverable error count

2019-03-21 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16798388#comment-16798388 ] Hudson commented on ZOOKEEPER-3327: --- SUCCESS: Integrated in Jenkins build ZooKeeper-trunk #449 (See

[jira] [Commented] (ZOOKEEPER-3327) Add unrecoverable error count

2019-03-21 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16798365#comment-16798365 ] Hudson commented on ZOOKEEPER-3327: --- SUCCESS: Integrated in Jenkins build

[GitHub] [zookeeper] kshvakov opened a new pull request #865: zoo_sample.cfg: enable autopurge and change dataDir

2019-03-21 Thread GitBox
kshvakov opened a new pull request #865: zoo_sample.cfg: enable autopurge and change dataDir URL: https://github.com/apache/zookeeper/pull/865 I think it's a very important changes, because I encountered a lot of production installations with "default" config. It's not joke, people don't

[GitHub] [zookeeper] eolivelli commented on a change in pull request #861: ZOOKEEPER-3326: Add session/connection related metrics

2019-03-21 Thread GitBox
eolivelli commented on a change in pull request #861: ZOOKEEPER-3326: Add session/connection related metrics URL: https://github.com/apache/zookeeper/pull/861#discussion_r267910974 ## File path: zookeeper-server/src/test/java/org/apache/zookeeper/server/ConnectionMetricsTest.java

[GitHub] [zookeeper] eolivelli commented on a change in pull request #854: ZOOKEEPER-3143 Pluggable metrics system for ZooKeeper - Data Collection on Server

2019-03-21 Thread GitBox
eolivelli commented on a change in pull request #854: ZOOKEEPER-3143 Pluggable metrics system for ZooKeeper - Data Collection on Server URL: https://github.com/apache/zookeeper/pull/854#discussion_r267904684 ## File path:

[GitHub] [zookeeper] eolivelli commented on a change in pull request #854: ZOOKEEPER-3143 Pluggable metrics system for ZooKeeper - Data Collection on Server

2019-03-21 Thread GitBox
eolivelli commented on a change in pull request #854: ZOOKEEPER-3143 Pluggable metrics system for ZooKeeper - Data Collection on Server URL: https://github.com/apache/zookeeper/pull/854#discussion_r267903443 ## File path:

[jira] [Resolved] (ZOOKEEPER-3327) Add unrecoverable error count

2019-03-21 Thread Fangmin Lv (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3327?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fangmin Lv resolved ZOOKEEPER-3327. --- Resolution: Fixed Issue resolved by pull request 862

[GitHub] [zookeeper] asfgit closed pull request #862: ZOOKEEPER-3327: Add unrecoverable error count

2019-03-21 Thread GitBox
asfgit closed pull request #862: ZOOKEEPER-3327: Add unrecoverable error count URL: https://github.com/apache/zookeeper/pull/862 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [zookeeper] lvfangmin commented on a change in pull request #854: ZOOKEEPER-3143 Pluggable metrics system for ZooKeeper - Data Collection on Server

2019-03-21 Thread GitBox
lvfangmin commented on a change in pull request #854: ZOOKEEPER-3143 Pluggable metrics system for ZooKeeper - Data Collection on Server URL: https://github.com/apache/zookeeper/pull/854#discussion_r267889436 ## File path:

[GitHub] [zookeeper] lvfangmin commented on a change in pull request #854: ZOOKEEPER-3143 Pluggable metrics system for ZooKeeper - Data Collection on Server

2019-03-21 Thread GitBox
lvfangmin commented on a change in pull request #854: ZOOKEEPER-3143 Pluggable metrics system for ZooKeeper - Data Collection on Server URL: https://github.com/apache/zookeeper/pull/854#discussion_r267890440 ## File path:

[GitHub] [zookeeper] lvfangmin commented on a change in pull request #854: ZOOKEEPER-3143 Pluggable metrics system for ZooKeeper - Data Collection on Server

2019-03-21 Thread GitBox
lvfangmin commented on a change in pull request #854: ZOOKEEPER-3143 Pluggable metrics system for ZooKeeper - Data Collection on Server URL: https://github.com/apache/zookeeper/pull/854#discussion_r267888583 ## File path:

[GitHub] [zookeeper] lvfangmin commented on issue #853: ZOOKEEPER-3316: Remove unused code in SyncRequestProcessor

2019-03-21 Thread GitBox
lvfangmin commented on issue #853: ZOOKEEPER-3316: Remove unused code in SyncRequestProcessor URL: https://github.com/apache/zookeeper/pull/853#issuecomment-475337352 @anmolnar it's from spotbugs, and we know SyncRequestProcessor is not processing read as well. Will wait @phunt to

Re: Opening 'retest maven/ant build' to the public

2019-03-21 Thread Brian Nixon
Dropping the constraint would be much appreciated :) On Thu, Mar 21, 2019 at 10:32 AM Patrick Hunt wrote: > Seems reasonable. If it's abused we can always revert. > > Patrick > > On Thu, Mar 21, 2019 at 9:59 AM Enrico Olivelli > wrote: > > > Hi Zookeepers, > > Currently only apache committers

Re: Opening 'retest maven/ant build' to the public

2019-03-21 Thread Patrick Hunt
Seems reasonable. If it's abused we can always revert. Patrick On Thu, Mar 21, 2019 at 9:59 AM Enrico Olivelli wrote: > Hi Zookeepers, > Currently only apache committers are allowed to restart pre commit builds > withon the 'magic phrase'. > But anyone can close/reopen his PR in order to

Opening 'retest maven/ant build' to the public

2019-03-21 Thread Enrico Olivelli
Hi Zookeepers, Currently only apache committers are allowed to restart pre commit builds withon the 'magic phrase'. But anyone can close/reopen his PR in order to achieve the same result. I would like to drop the 'committers only' constraint which seems useless Opinions? Enrico

[GitHub] [zookeeper] phunt commented on a change in pull request #864: ZOOKEEPER-3299:'setquota -n|-b val path' needs a brackets

2019-03-21 Thread GitBox
phunt commented on a change in pull request #864: ZOOKEEPER-3299:'setquota -n|-b val path' needs a brackets URL: https://github.com/apache/zookeeper/pull/864#discussion_r267859530 ## File path: zookeeper-docs/src/main/resources/markdown/zookeeperStarted.md ## @@ -166,7

[GitHub] [zookeeper] jhuan31 opened a new pull request #859: ZOOKEEPER-3323: Add TxnSnapLog metrics

2019-03-21 Thread GitBox
jhuan31 opened a new pull request #859: ZOOKEEPER-3323: Add TxnSnapLog metrics URL: https://github.com/apache/zookeeper/pull/859 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [zookeeper] jhuan31 closed pull request #859: ZOOKEEPER-3323: Add TxnSnapLog metrics

2019-03-21 Thread GitBox
jhuan31 closed pull request #859: ZOOKEEPER-3323: Add TxnSnapLog metrics URL: https://github.com/apache/zookeeper/pull/859 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [zookeeper] jhuan31 commented on issue #862: ZOOKEEPER-3327: Add unrecoverable error count

2019-03-21 Thread GitBox
jhuan31 commented on issue #862: ZOOKEEPER-3327: Add unrecoverable error count URL: https://github.com/apache/zookeeper/pull/862#issuecomment-475277696 > What about adding a test only around zookeeper-server/src/main/java/org/apache/zookeeper/server/ZooKeeperCriticalThread.java

[GitHub] [zookeeper] jhuan31 commented on a change in pull request #862: ZOOKEEPER-3327: Add unrecoverable error count

2019-03-21 Thread GitBox
jhuan31 commented on a change in pull request #862: ZOOKEEPER-3327: Add unrecoverable error count URL: https://github.com/apache/zookeeper/pull/862#discussion_r267814583 ## File path:

[GitHub] [zookeeper] eolivelli commented on a change in pull request #862: ZOOKEEPER-3327: Add unrecoverable error count

2019-03-21 Thread GitBox
eolivelli commented on a change in pull request #862: ZOOKEEPER-3327: Add unrecoverable error count URL: https://github.com/apache/zookeeper/pull/862#discussion_r267757745 ## File path:

[jira] [Updated] (ZOOKEEPER-3299) "setquota -n|-b val path" need a brackets

2019-03-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3299?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated ZOOKEEPER-3299: -- Labels: pull-request-available (was: ) > "setquota -n|-b val path" need a

[GitHub] [zookeeper] ZWShuai91 opened a new pull request #864: ZOOKEEPER-3299:'setquota -n|-b val path' needs a brackets

2019-03-21 Thread GitBox
ZWShuai91 opened a new pull request #864: ZOOKEEPER-3299:'setquota -n|-b val path' needs a brackets URL: https://github.com/apache/zookeeper/pull/864 Look at https://issues.apache.org/jira/browse/ZOOKEEPER-3299 This is an

[jira] [Commented] (ZOOKEEPER-3320) Leader election port stop listen when hostname unresolvable for some time

2019-03-21 Thread Igor Skokov (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16797880#comment-16797880 ] Igor Skokov commented on ZOOKEEPER-3320: I attach link to pull request. It based on

[jira] [Updated] (ZOOKEEPER-3320) Leader election port stop listen when hostname unresolvable for some time

2019-03-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3320?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated ZOOKEEPER-3320: -- Labels: pull-request-available (was: ) > Leader election port stop listen when

[GitHub] [zookeeper] Lagrang opened a new pull request #863: ZOOKEEPER-3320: Leader election port stop listen when hostname unresolvable for some time

2019-03-21 Thread GitBox
Lagrang opened a new pull request #863: ZOOKEEPER-3320: Leader election port stop listen when hostname unresolvable for some time URL: https://github.com/apache/zookeeper/pull/863 This is an automated message from the

[GitHub] [zookeeper] lvfangmin commented on issue #848: ZOOKEEPER-3306: Fixing node not accessible issue due the inconsistent ACL reference map after SNAP sync

2019-03-21 Thread GitBox
lvfangmin commented on issue #848: ZOOKEEPER-3306: Fixing node not accessible issue due the inconsistent ACL reference map after SNAP sync URL: https://github.com/apache/zookeeper/pull/848#issuecomment-475125918 @anmolnar currently, we cannot tell if the ACL reference is already added or