[GitHub] [zookeeper] eolivelli commented on issue #869: ZOOKEEPER-3020: Review of SyncRequestProcessor

eolivelli commented on issue #869: ZOOKEEPER-3020: Review of SyncRequestProcessor URL: https://github.com/apache/zookeeper/pull/869#issuecomment-476987352 @BELUGABEHR Yes, having separate commits will help a lot the reviews. Thank you very much for your efforts in improving ZK

[GitHub] [zookeeper] BELUGABEHR commented on issue #870: ZOOKEEPER-3335: Prefer ArrayList over LinkedList

BELUGABEHR commented on issue #870: ZOOKEEPER-3335: Prefer ArrayList over LinkedList URL: https://github.com/apache/zookeeper/pull/870#issuecomment-476962318 Array-based collections are generally faster and consume less memory. https://stackoverflow.com/questions/322715/when-to-use-

[GitHub] [zookeeper] maoling commented on a change in pull request #870: ZOOKEEPER-3335: Prefer ArrayList over LinkedList

maoling commented on a change in pull request #870: ZOOKEEPER-3335: Prefer ArrayList over LinkedList URL: https://github.com/apache/zookeeper/pull/870#discussion_r269386992 ## File path: zookeeper-server/src/main/java/org/apache/zookeeper/server/PrepRequestProcessor.java #

[GitHub] [zookeeper] maoling edited a comment on issue #833: ZOOKEEPER-3288:add a new doc:ZookeeperCLI.md

maoling edited a comment on issue #833: ZOOKEEPER-3288:add a new doc:ZookeeperCLI.md URL: https://github.com/apache/zookeeper/pull/833#issuecomment-476926276 Done @phunt @anmolnar @lvfangmin . now you can review this PR formally. The preview is [here](https://github.com/maoling/zookeep

[GitHub] [zookeeper] BELUGABEHR commented on issue #869: ZOOKEEPER-3020: Review of SyncRequestProcessor

BELUGABEHR commented on issue #869: ZOOKEEPER-3020: Review of SyncRequestProcessor URL: https://github.com/apache/zookeeper/pull/869#issuecomment-476933909 @enixon Thanks for the feedback and thank you for providing a path forward. I put some significant time into this to try to really ti

[GitHub] [zookeeper] BELUGABEHR commented on a change in pull request #870: ZOOKEEPER-3335: Prefer ArrayList over LinkedList

BELUGABEHR commented on a change in pull request #870: ZOOKEEPER-3335: Prefer ArrayList over LinkedList URL: https://github.com/apache/zookeeper/pull/870#discussion_r269381357 ## File path: zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/CommitProcessor.java

[GitHub] [zookeeper] BELUGABEHR commented on a change in pull request #870: ZOOKEEPER-3335: Prefer ArrayList over LinkedList

BELUGABEHR commented on a change in pull request #870: ZOOKEEPER-3335: Prefer ArrayList over LinkedList URL: https://github.com/apache/zookeeper/pull/870#discussion_r269381061 ## File path: zookeeper-server/src/main/java/org/apache/zookeeper/server/ZKDatabase.java ## @@ -

[GitHub] [zookeeper] BELUGABEHR commented on a change in pull request #870: ZOOKEEPER-3335: Prefer ArrayList over LinkedList

BELUGABEHR commented on a change in pull request #870: ZOOKEEPER-3335: Prefer ArrayList over LinkedList URL: https://github.com/apache/zookeeper/pull/870#discussion_r269381061 ## File path: zookeeper-server/src/main/java/org/apache/zookeeper/server/ZKDatabase.java ## @@ -

[GitHub] [zookeeper] BELUGABEHR commented on a change in pull request #870: ZOOKEEPER-3335: Prefer ArrayList over LinkedList

BELUGABEHR commented on a change in pull request #870: ZOOKEEPER-3335: Prefer ArrayList over LinkedList URL: https://github.com/apache/zookeeper/pull/870#discussion_r269380411 ## File path: zookeeper-server/src/main/java/org/apache/zookeeper/server/ZKDatabase.java ## @@ -

[GitHub] [zookeeper] maoling commented on issue #833: ZOOKEEPER-3288:add a new doc:ZookeeperCLI.md

maoling commented on issue #833: ZOOKEEPER-3288:add a new doc:ZookeeperCLI.md URL: https://github.com/apache/zookeeper/pull/833#issuecomment-476926276 Done @phunt @anmolnar @lvfangmin . now you can review this PR formally. Th

[GitHub] [zookeeper] enixon commented on a change in pull request #870: ZOOKEEPER-3335: Prefer ArrayList over LinkedList

enixon commented on a change in pull request #870: ZOOKEEPER-3335: Prefer ArrayList over LinkedList URL: https://github.com/apache/zookeeper/pull/870#discussion_r269365587 ## File path: zookeeper-server/src/main/java/org/apache/zookeeper/server/ZKDatabase.java ## @@ -187,

[GitHub] [zookeeper] enixon commented on issue #869: ZOOKEEPER-3020: Review of SyncRequestProcessor

enixon commented on issue #869: ZOOKEEPER-3020: Review of SyncRequestProcessor URL: https://github.com/apache/zookeeper/pull/869#issuecomment-476903563 One way to proceed might be to separate the logic changes into separate commits in a single PR. At a brief glance, it doesn't look like imp

[jira] [Updated] (ZOOKEEPER-3335) Prefer ArrayList over LinkedList

[ https://issues.apache.org/jira/browse/ZOOKEEPER-3335?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated ZOOKEEPER-3335: -- Labels: pull-request-available (was: ) > Prefer ArrayList over LinkedList > --

[GitHub] [zookeeper] BELUGABEHR opened a new pull request #870: ZOOKEEPER-3335: Prefer ArrayList over LinkedList

BELUGABEHR opened a new pull request #870: ZOOKEEPER-3335: Prefer ArrayList over LinkedList URL: https://github.com/apache/zookeeper/pull/870 This is an automated message from the Apache Git Service. To respond to the messag

[jira] [Created] (ZOOKEEPER-3335) Prefer ArrayList over LinkedList

David Mollitor created ZOOKEEPER-3335: - Summary: Prefer ArrayList over LinkedList Key: ZOOKEEPER-3335 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3335 Project: ZooKeeper Issue Ty

Failed: ZOOKEEPER-3020 PreCommit Build #3739

Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-3020 Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3739/ ### ## LAST 60 LINES OF THE CONSOLE ### [

[jira] [Updated] (ZOOKEEPER-3020) Review of SyncRequestProcessor

[ https://issues.apache.org/jira/browse/ZOOKEEPER-3020?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated ZOOKEEPER-3020: -- Labels: pull-request-available (was: ) > Review of SyncRequestProcessor >

[GitHub] [zookeeper] BELUGABEHR opened a new pull request #869: ZOOKEEPER-3020: Review of SyncRequestProcessor

BELUGABEHR opened a new pull request #869: ZOOKEEPER-3020: Review of SyncRequestProcessor URL: https://github.com/apache/zookeeper/pull/869 This is an automated message from the Apache Git Service. To respond to the message,

[jira] [Commented] (ZOOKEEPER-2938) Server is unable to join quorum after connection broken to other peers

[ https://issues.apache.org/jira/browse/ZOOKEEPER-2938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16801785#comment-16801785 ] Josh Elser commented on ZOOKEEPER-2938: --- FWIW, a group of us have observed this

[jira] [Updated] (ZOOKEEPER-3333) Detect if txnlogs and / or snapshots is deleted under a running ZK instance

[ https://issues.apache.org/jira/browse/ZOOKEEPER-?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Norbert Kalmar updated ZOOKEEPER-: -- Affects Version/s: (was: 3.6.0) > Detect if txnlogs and / or snapshots is delet

[jira] [Updated] (ZOOKEEPER-3318) Add a complete backup mechanism for zookeeper internal

[ https://issues.apache.org/jira/browse/ZOOKEEPER-3318?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] maoling updated ZOOKEEPER-3318: --- Description: we already had some workaround ways for the backup, e.g scenario 1: just write a cro

[jira] [Created] (ZOOKEEPER-3334) ./zkCli.sh cannot create the node

maoling created ZOOKEEPER-3334: -- Summary: ./zkCli.sh cannot create the node Key: ZOOKEEPER-3334 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3334 Project: ZooKeeper Issue Type: Bug