Re: [VOTE] Apache ZooKeeper release 3.5.5 candidate 3

Hi team, Just to wrap up the votes so far: We got +1 from - Enrico - Norbert Do we have +1 from Maoling by any chance? ZooKeeper PMCs, We need you one more time here to release stable 3.5! Please vote! Thanks, Andor > On 2019. Apr 9., at 21:13, Andor Molnár > wr

Build failed in Jenkins: ZooKeeper-trunk-owasp #330

See -- [...truncated 31.62 KB...] [ivy:retrieve] found joda-time#joda-time;1.6 in maven2 [ivy:retrieve] found org.slf4j#slf4j-api;1.7.25 in maven2 [ivy:retrieve] found org.owasp#de

[GitHub] [zookeeper] asfgit closed pull request #860: ZOOKEEPER-3324: Add read/write metrics for top level znodes

asfgit closed pull request #860: ZOOKEEPER-3324: Add read/write metrics for top level znodes URL: https://github.com/apache/zookeeper/pull/860 This is an automated message from the Apache Git Service. To respond to the messa

[jira] [Resolved] (ZOOKEEPER-3324) Add read/write metrics for top level znodes

[ https://issues.apache.org/jira/browse/ZOOKEEPER-3324?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andor Molnar resolved ZOOKEEPER-3324. - Resolution: Fixed Issue resolved by pull request 860 [https://github.com/apache/zooke

[GitHub] [zookeeper] anmolnar commented on issue #860: ZOOKEEPER-3324: Add read/write metrics for top level znodes

anmolnar commented on issue #860: ZOOKEEPER-3324: Add read/write metrics for top level znodes URL: https://github.com/apache/zookeeper/pull/860#issuecomment-482525577 Committed to master branch. Thanks @jhuan31 ! This is an a

[jira] [Assigned] (ZOOKEEPER-3324) Add read/write metrics for top level znodes

[ https://issues.apache.org/jira/browse/ZOOKEEPER-3324?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andor Molnar reassigned ZOOKEEPER-3324: --- Assignee: Jie Huang > Add read/write metrics for top level znodes >

ZooKeeper-trunk - Build # 473 - Failure

See https://builds.apache.org/job/ZooKeeper-trunk/473/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 188.46 KB...] [junit] Tests run: 2, Failures: 0, Errors:

[jira] [Commented] (ZOOKEEPER-3324) Add read/write metrics for top level znodes

[ https://issues.apache.org/jira/browse/ZOOKEEPER-3324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16816174#comment-16816174 ] Hudson commented on ZOOKEEPER-3324: --- FAILURE: Integrated in Jenkins build ZooKeeper

Re: [VOTE] Apache ZooKeeper release 3.5.5 candidate 3

(just to be clear) +1 (non binding) checked signatures, checksums built with Maven, run tests on Java 8 on Linux 64bit Fedora 28 Configuration of Maven plugins for Rat and Spotbugs fails, but this is not a blocker for the release Super great work Andor ! Enrico Il giorno ven 12 apr 2019 alle

[GitHub] [zookeeper] eolivelli commented on a change in pull request #899: ZOOKEEPER-3354: Improve efficiency of DeleteAllCommand

eolivelli commented on a change in pull request #899: ZOOKEEPER-3354: Improve efficiency of DeleteAllCommand URL: https://github.com/apache/zookeeper/pull/899#discussion_r274867355 ## File path: zookeeper-server/src/main/java/org/apache/zookeeper/ZKUtil.java ## @@ -45,20 +

[GitHub] [zookeeper] eolivelli commented on a change in pull request #899: ZOOKEEPER-3354: Improve efficiency of DeleteAllCommand

eolivelli commented on a change in pull request #899: ZOOKEEPER-3354: Improve efficiency of DeleteAllCommand URL: https://github.com/apache/zookeeper/pull/899#discussion_r274867532 ## File path: zookeeper-server/src/main/java/org/apache/zookeeper/ZKUtil.java ## @@ -45,20 +

[GitHub] [zookeeper] anmolnar commented on a change in pull request #904: ZOOKEEPER-3037 - Add JVMPauseMonitor

anmolnar commented on a change in pull request #904: ZOOKEEPER-3037 - Add JVMPauseMonitor URL: https://github.com/apache/zookeeper/pull/904#discussion_r274872856 ## File path: zookeeper-server/src/main/java/org/apache/zookeeper/server/util/JvmPauseMonitor.java ## @@ -0,0

[GitHub] [zookeeper] anmolnar commented on a change in pull request #904: ZOOKEEPER-3037 - Add JVMPauseMonitor

anmolnar commented on a change in pull request #904: ZOOKEEPER-3037 - Add JVMPauseMonitor URL: https://github.com/apache/zookeeper/pull/904#discussion_r274872554 ## File path: zookeeper-server/src/test/java/org/apache/zookeeper/server/util/JvmPauseMonitorTest.java ## @@ -

[GitHub] [zookeeper] anmolnar commented on a change in pull request #904: ZOOKEEPER-3037 - Add JVMPauseMonitor

anmolnar commented on a change in pull request #904: ZOOKEEPER-3037 - Add JVMPauseMonitor URL: https://github.com/apache/zookeeper/pull/904#discussion_r274872394 ## File path: zookeeper-server/src/test/java/org/apache/zookeeper/server/quorum/QuorumPeerConfigTest.java ## @

[GitHub] [zookeeper] anmolnar commented on a change in pull request #904: ZOOKEEPER-3037 - Add JVMPauseMonitor

anmolnar commented on a change in pull request #904: ZOOKEEPER-3037 - Add JVMPauseMonitor URL: https://github.com/apache/zookeeper/pull/904#discussion_r274872243 ## File path: zookeeper-server/src/main/java/org/apache/zookeeper/server/util/JvmPauseMonitor.java ## @@ -0,0

[jira] [Created] (ZOOKEEPER-3361) Add multi version of getChildren request

Peter Szecsi created ZOOKEEPER-3361: --- Summary: Add multi version of getChildren request Key: ZOOKEEPER-3361 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3361 Project: ZooKeeper Issu

Re: [VOTE] Apache ZooKeeper release 3.5.5 candidate 3

Hi Enrico / Norbert, -1 During my testing I’ve realised that Maven checksum plugin doesn’t add the filename to sha512 checksum files. It only contains the hash. As a consequence one is no longer able to verify the checksum, because ’shasum’ doesn’t recognise the contents. Please configure the

Re: [VOTE] Apache ZooKeeper release 3.5.5 candidate 3

Hi Andor, It is possible to add the filename to the generated sha512, we need to add  true to checksum-plugin. I tested it works this way. I can do a PR for this, the sportbug exclude and the rat excludes so you can do another RC having these fixed. Regards,Norbert On Friday, April 12, 2019,

Re: [VOTE] Apache ZooKeeper release 3.5.5 candidate 3

Awesome! Thanks. > On 2019. Apr 12., at 15:06, Norbert Kalmár wrote: > > Hi Andor, > It is possible to add the filename to the generated sha512, we need to add > true to checksum-plugin. I tested it works > this way. > I can do a PR for this, the sportbug exclude and the rat excludes so you c

[GitHub] [zookeeper] nkalmar commented on issue #904: ZOOKEEPER-3037 - Add JVMPauseMonitor

nkalmar commented on issue #904: ZOOKEEPER-3037 - Add JVMPauseMonitor URL: https://github.com/apache/zookeeper/pull/904#issuecomment-482583085 retest this please This is an automated message from the Apache Git Service. To res

[GitHub] [zookeeper] nkalmar opened a new pull request #907: ZOOKEEPER-3351 - add rat exceptions and fix sha generation

nkalmar opened a new pull request #907: ZOOKEEPER-3351 - add rat exceptions and fix sha generation URL: https://github.com/apache/zookeeper/pull/907 Note: this is only for master, for 3.5 branch it needs a different PR! This

[jira] [Updated] (ZOOKEEPER-3351) Migrate qa-test-pullrequest ant task to maven

[ https://issues.apache.org/jira/browse/ZOOKEEPER-3351?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated ZOOKEEPER-3351: -- Labels: pull-request-available (was: ) > Migrate qa-test-pullrequest ant task to m

[GitHub] [zookeeper] anmolnar commented on issue #907: ZOOKEEPER-3351 - add rat exceptions and fix sha generation

anmolnar commented on issue #907: ZOOKEEPER-3351 - add rat exceptions and fix sha generation URL: https://github.com/apache/zookeeper/pull/907#issuecomment-482587545 Looks good. Please add the spotbugs ignore. This is an auto

[GitHub] [zookeeper] nkalmar commented on issue #907: ZOOKEEPER-3351 - add rat exceptions and fix sha generation

nkalmar commented on issue #907: ZOOKEEPER-3351 - add rat exceptions and fix sha generation URL: https://github.com/apache/zookeeper/pull/907#issuecomment-482597474 Tested spotBugs, it now passes with versions without SNAPSHOT as well. --

[GitHub] [zookeeper] nkalmar edited a comment on issue #907: ZOOKEEPER-3351 - add rat exceptions and fix sha generation

nkalmar edited a comment on issue #907: ZOOKEEPER-3351 - add rat exceptions and fix sha generation URL: https://github.com/apache/zookeeper/pull/907#issuecomment-482597474 Tested spotBugs, it now passes with versions without SNAPSHOT as well. Testing this patch on 3.5 branch to see i

[GitHub] [zookeeper] nkalmar edited a comment on issue #907: ZOOKEEPER-3351 - add rat exceptions and fix sha generation

nkalmar edited a comment on issue #907: ZOOKEEPER-3351 - add rat exceptions and fix sha generation URL: https://github.com/apache/zookeeper/pull/907#issuecomment-482597474 Tested spotBugs, it now passes with versions without SNAPSHOT as well. Testing this patch on 3.5 branch to see i

[GitHub] [zookeeper] nkalmar opened a new pull request #908: ZOOKEEPER-3351 - 3.5 - Fix findBugs and rat check, add filename to sha

nkalmar opened a new pull request #908: ZOOKEEPER-3351 - 3.5 - Fix findBugs and rat check, add filename to sha URL: https://github.com/apache/zookeeper/pull/908 This is an automated message from the Apache Git Service. To re

[GitHub] [zookeeper] anmolnar commented on a change in pull request #907: ZOOKEEPER-3351 - Fix findBugs and rat check, add filename to sha

anmolnar commented on a change in pull request #907: ZOOKEEPER-3351 - Fix findBugs and rat check, add filename to sha URL: https://github.com/apache/zookeeper/pull/907#discussion_r274939800 ## File path: zookeeper-server/src/main/java/org/apache/zookeeper/Version.java ## @

Re: [VOTE] Apache ZooKeeper release 3.5.5 candidate 3

Il giorno ven 12 apr 2019 alle ore 15:02 Andor Molnar ha scritto: > > Hi Enrico / Norbert, > > -1 > > During my testing I’ve realised that Maven checksum plugin doesn’t add the > filename to sha512 checksum files. It only contains the hash. As a > consequence one is no longer able to verify the

[GitHub] [zookeeper] nkalmar commented on a change in pull request #907: ZOOKEEPER-3351 - Fix findBugs and rat check, add filename to sha

nkalmar commented on a change in pull request #907: ZOOKEEPER-3351 - Fix findBugs and rat check, add filename to sha URL: https://github.com/apache/zookeeper/pull/907#discussion_r274944544 ## File path: zookeeper-server/src/main/java/org/apache/zookeeper/Version.java ## @@

[GitHub] [zookeeper] anmolnar commented on a change in pull request #770: ZOOKEEPER-3244: Add option to snapshot based on log size

anmolnar commented on a change in pull request #770: ZOOKEEPER-3244: Add option to snapshot based on log size URL: https://github.com/apache/zookeeper/pull/770#discussion_r274944660 ## File path: zookeeper-docs/src/main/resources/markdown/zookeeperAdmin.md ## @@ -625,16 +6

Re: [VOTE] Apache ZooKeeper release 3.5.5 candidate 3

Andor, you previously said "None of the issues are showstopper for the RC, but let's fix them to get a clean sheet." Which meant to me that you are cutting a new RC, as such I haven't looked. What's the plan? Patrick On Fri, Apr 12, 2019 at 2:12 AM Andor Molnar wrote: > Hi team, > > Just to

[GitHub] [zookeeper] szepet commented on a change in pull request #899: ZOOKEEPER-3354: Improve efficiency of DeleteAllCommand

szepet commented on a change in pull request #899: ZOOKEEPER-3354: Improve efficiency of DeleteAllCommand URL: https://github.com/apache/zookeeper/pull/899#discussion_r274944586 ## File path: zookeeper-server/src/main/java/org/apache/zookeeper/ZKUtil.java ## @@ -45,20 +48,

Re: [VOTE] Apache ZooKeeper release 3.5.5 candidate 3

Sorry for being misleading. I’m cutting a new RC once PR#907 is committed. Please wait for it with your testing. Thanks, Andor > On 2019. Apr 12., at 16:59, Patrick Hunt > wrote: > > Andor, you previously said > > "None of the issues are showstopper for the RC, bu

[jira] [Commented] (ZOOKEEPER-3324) Add read/write metrics for top level znodes

[ https://issues.apache.org/jira/browse/ZOOKEEPER-3324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16816399#comment-16816399 ] Hudson commented on ZOOKEEPER-3324: --- FAILURE: Integrated in Jenkins build Zookeeper

[GitHub] [zookeeper] nkalmar commented on issue #908: ZOOKEEPER-3351 - 3.5 - Fix findBugs and rat check, add filename to sha

nkalmar commented on issue #908: ZOOKEEPER-3351 - 3.5 - Fix findBugs and rat check, add filename to sha URL: https://github.com/apache/zookeeper/pull/908#issuecomment-482632656 retest maven build This is an automated message

[GitHub] [zookeeper] nkalmar commented on issue #907: ZOOKEEPER-3351 - Fix findBugs and rat check, add filename to sha

nkalmar commented on issue #907: ZOOKEEPER-3351 - Fix findBugs and rat check, add filename to sha URL: https://github.com/apache/zookeeper/pull/907#issuecomment-482633091 retest ant build This is an automated message from the

[GitHub] [zookeeper] asfgit closed pull request #854: ZOOKEEPER-3143 Pluggable metrics system for ZooKeeper - Data Collection on Server

asfgit closed pull request #854: ZOOKEEPER-3143 Pluggable metrics system for ZooKeeper - Data Collection on Server URL: https://github.com/apache/zookeeper/pull/854 This is an automated message from the Apache Git Service. T

[GitHub] [zookeeper] anmolnar commented on issue #854: ZOOKEEPER-3143 Pluggable metrics system for ZooKeeper - Data Collection on Server

anmolnar commented on issue #854: ZOOKEEPER-3143 Pluggable metrics system for ZooKeeper - Data Collection on Server URL: https://github.com/apache/zookeeper/pull/854#issuecomment-482649311 Committed to master branch. Great work @eolivelli ! -

[jira] [Assigned] (ZOOKEEPER-3143) Pluggable metrics system for ZooKeeper - Data Collection on Server

[ https://issues.apache.org/jira/browse/ZOOKEEPER-3143?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andor Molnar reassigned ZOOKEEPER-3143: --- Assignee: Enrico Olivelli > Pluggable metrics system for ZooKeeper - Data Collec

[jira] [Resolved] (ZOOKEEPER-3143) Pluggable metrics system for ZooKeeper - Data Collection on Server

[ https://issues.apache.org/jira/browse/ZOOKEEPER-3143?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andor Molnar resolved ZOOKEEPER-3143. - Resolution: Fixed Fix Version/s: 3.6.0 Issue resolved by pull request 854 [htt

[GitHub] [zookeeper] asfgit closed pull request #894: ZOOKEEPER-3348: Make TxnLog and TxnLog Iterator Closable

asfgit closed pull request #894: ZOOKEEPER-3348: Make TxnLog and TxnLog Iterator Closable URL: https://github.com/apache/zookeeper/pull/894 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [zookeeper] anmolnar commented on issue #894: ZOOKEEPER-3348: Make TxnLog and TxnLog Iterator Closable

anmolnar commented on issue #894: ZOOKEEPER-3348: Make TxnLog and TxnLog Iterator Closable URL: https://github.com/apache/zookeeper/pull/894#issuecomment-482650692 Good catch. Thanks @BELUGABEHR ! This is an automated message

[jira] [Resolved] (ZOOKEEPER-3348) Make TxnLog and TxnLog Iterator Closable

[ https://issues.apache.org/jira/browse/ZOOKEEPER-3348?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andor Molnar resolved ZOOKEEPER-3348. - Resolution: Fixed Issue resolved by pull request 894 [https://github.com/apache/zooke

[GitHub] [zookeeper] anmolnar commented on issue #868: ZOOKEEPER-3332:TxnLogToolkit should print multi transactions readably

anmolnar commented on issue #868: ZOOKEEPER-3332:TxnLogToolkit should print multi transactions readably URL: https://github.com/apache/zookeeper/pull/868#issuecomment-482651176 Merged to master. Thanks @maoling ! This is an a

[jira] [Resolved] (ZOOKEEPER-3332) TxnLogToolkit should print multi transactions readably

[ https://issues.apache.org/jira/browse/ZOOKEEPER-3332?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andor Molnar resolved ZOOKEEPER-3332. - Resolution: Fixed Fix Version/s: 3.6.0 Issue resolved by pull request 868 [htt

[GitHub] [zookeeper] asfgit closed pull request #868: ZOOKEEPER-3332:TxnLogToolkit should print multi transactions readably

asfgit closed pull request #868: ZOOKEEPER-3332:TxnLogToolkit should print multi transactions readably URL: https://github.com/apache/zookeeper/pull/868 This is an automated message from the Apache Git Service. To respond to

[GitHub] [zookeeper] eolivelli commented on issue #854: ZOOKEEPER-3143 Pluggable metrics system for ZooKeeper - Data Collection on Server

eolivelli commented on issue #854: ZOOKEEPER-3143 Pluggable metrics system for ZooKeeper - Data Collection on Server URL: https://github.com/apache/zookeeper/pull/854#issuecomment-482654543 Thank you @anmolnar @lvfangmin @enixon. ! I will send next patch soon ---

ZooKeeper_branch34_openjdk8 - Build # 292 - Failure

See https://builds.apache.org/job/ZooKeeper_branch34_openjdk8/292/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 45.29 KB...] [junit] Running org.apache.zook

[GitHub] [zookeeper] enixon commented on a change in pull request #770: ZOOKEEPER-3244: Add option to snapshot based on log size

enixon commented on a change in pull request #770: ZOOKEEPER-3244: Add option to snapshot based on log size URL: https://github.com/apache/zookeeper/pull/770#discussion_r275023882 ## File path: zookeeper-docs/src/main/resources/markdown/zookeeperAdmin.md ## @@ -625,16 +625

[jira] [Created] (ZOOKEEPER-3362) Create a simple checkstyle file

Enrico Olivelli created ZOOKEEPER-3362: -- Summary: Create a simple checkstyle file Key: ZOOKEEPER-3362 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3362 Project: ZooKeeper Issue T

[GitHub] [zookeeper] eolivelli opened a new pull request #909: ZOOKEEPER-3362 Create a simple checkstyle file

eolivelli opened a new pull request #909: ZOOKEEPER-3362 Create a simple checkstyle file URL: https://github.com/apache/zookeeper/pull/909 This is an automated message from the Apache Git Service. To respond to the message,

[jira] [Updated] (ZOOKEEPER-3362) Create a simple checkstyle file

[ https://issues.apache.org/jira/browse/ZOOKEEPER-3362?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated ZOOKEEPER-3362: -- Labels: pull-request-available (was: ) > Create a simple checkstyle file > ---

ZK Smoke Screen Test

Hello, I am not sure if this is novel or perhaps old news, but I forked Patrick Hunt's ZK smoketest project and updated the docker components. I am able to pretty easily start a quorum (3x) using the latest ZK image and run the smoke test against it. https://github.com/BELUGABEHR/zk-smoketest I

[GitHub] [zookeeper] asfgit closed pull request #907: ZOOKEEPER-3351 - Fix findBugs and rat check, add filename to sha

asfgit closed pull request #907: ZOOKEEPER-3351 - Fix findBugs and rat check, add filename to sha URL: https://github.com/apache/zookeeper/pull/907 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [zookeeper] anmolnar commented on issue #907: ZOOKEEPER-3351 - Fix findBugs and rat check, add filename to sha

anmolnar commented on issue #907: ZOOKEEPER-3351 - Fix findBugs and rat check, add filename to sha URL: https://github.com/apache/zookeeper/pull/907#issuecomment-482700663 Committed to master branch. Thanks @nkalmar ! This is

[GitHub] [zookeeper] anmolnar commented on a change in pull request #770: ZOOKEEPER-3244: Add option to snapshot based on log size

anmolnar commented on a change in pull request #770: ZOOKEEPER-3244: Add option to snapshot based on log size URL: https://github.com/apache/zookeeper/pull/770#discussion_r275043509 ## File path: zookeeper-server/src/main/java/org/apache/zookeeper/server/ZooKeeperServer.java #

[GitHub] [zookeeper] eolivelli commented on issue #909: ZOOKEEPER-3362 Create a simple checkstyle file

eolivelli commented on issue #909: ZOOKEEPER-3362 Create a simple checkstyle file URL: https://github.com/apache/zookeeper/pull/909#issuecomment-482716984 this is still work-in-progress This is an automated message from the A

[GitHub] [zookeeper] eolivelli edited a comment on issue #909: ZOOKEEPER-3362 Create a simple checkstyle file

eolivelli edited a comment on issue #909: ZOOKEEPER-3362 Create a simple checkstyle file URL: https://github.com/apache/zookeeper/pull/909#issuecomment-482716984 Create a basic checkstyle file, in order to cover the minimal check abount @author tags. This is needed in order to drop

[jira] [Updated] (ZOOKEEPER-3362) Create a simple checkstyle file

[ https://issues.apache.org/jira/browse/ZOOKEEPER-3362?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Enrico Olivelli updated ZOOKEEPER-3362: --- Description: Create a basic checkstyle file, in order to cover the minimal check

[GitHub] [zookeeper] eolivelli edited a comment on issue #909: ZOOKEEPER-3362 Create a simple checkstyle file

eolivelli edited a comment on issue #909: ZOOKEEPER-3362 Create a simple checkstyle file URL: https://github.com/apache/zookeeper/pull/909#issuecomment-482716984 Create a basic checkstyle file, in order to cover the minimal check on @author tags. This is needed in order to drop old

[jira] [Updated] (ZOOKEEPER-3362) Create a simple checkstyle file

[ https://issues.apache.org/jira/browse/ZOOKEEPER-3362?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Enrico Olivelli updated ZOOKEEPER-3362: --- Description: Create a basic checkstyle file, in order to cover the minimal check

[GitHub] [zookeeper] eolivelli removed a comment on issue #909: ZOOKEEPER-3362 Create a simple checkstyle file

eolivelli removed a comment on issue #909: ZOOKEEPER-3362 Create a simple checkstyle file URL: https://github.com/apache/zookeeper/pull/909#issuecomment-482716984 Create a basic checkstyle file, in order to cover the minimal check on @author tags. This is needed in order to drop old

[GitHub] [zookeeper] eolivelli commented on issue #909: ZOOKEEPER-3362 Create a simple checkstyle file

eolivelli commented on issue #909: ZOOKEEPER-3362 Create a simple checkstyle file URL: https://github.com/apache/zookeeper/pull/909#issuecomment-482728164 I am also adding checkstyle to Travis. I need to add cppunit in order to run "full build" --

[GitHub] [zookeeper] lvfangmin commented on issue #905: ZOOKEEPER-3359: Batch commits in the CommitProcessor

lvfangmin commented on issue #905: ZOOKEEPER-3359: Batch commits in the CommitProcessor URL: https://github.com/apache/zookeeper/pull/905#issuecomment-482760988 @enixon can you check if we still have any performance number for this improvement, also some suggested number for the batch se

[jira] [Commented] (ZOOKEEPER-3143) Pluggable metrics system for ZooKeeper - Data Collection on Server

[ https://issues.apache.org/jira/browse/ZOOKEEPER-3143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16816765#comment-16816765 ] Hudson commented on ZOOKEEPER-3143: --- SUCCESS: Integrated in Jenkins build Zookeeper

[jira] [Commented] (ZOOKEEPER-3348) Make TxnLog and TxnLog Iterator Closable

[ https://issues.apache.org/jira/browse/ZOOKEEPER-3348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16816766#comment-16816766 ] Hudson commented on ZOOKEEPER-3348: --- SUCCESS: Integrated in Jenkins build Zookeeper

[jira] [Commented] (ZOOKEEPER-3332) TxnLogToolkit should print multi transactions readably

[ https://issues.apache.org/jira/browse/ZOOKEEPER-3332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16816767#comment-16816767 ] Hudson commented on ZOOKEEPER-3332: --- SUCCESS: Integrated in Jenkins build Zookeeper

[jira] [Commented] (ZOOKEEPER-3351) Migrate qa-test-pullrequest ant task to maven

[ https://issues.apache.org/jira/browse/ZOOKEEPER-3351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16816768#comment-16816768 ] Hudson commented on ZOOKEEPER-3351: --- SUCCESS: Integrated in Jenkins build Zookeeper

[GitHub] [zookeeper] lvfangmin commented on issue #880: ZOOKEEPER-3340: Improve Queue Usage in QuorumCnxManager.java

lvfangmin commented on issue #880: ZOOKEEPER-3340: Improve Queue Usage in QuorumCnxManager.java URL: https://github.com/apache/zookeeper/pull/880#issuecomment-482761706 Thanks @BELUGABEHR for improving this, this is cool, we may use CircularBlockingQueue in other places as well. Bes

[jira] [Commented] (ZOOKEEPER-3348) Make TxnLog and TxnLog Iterator Closable

[ https://issues.apache.org/jira/browse/ZOOKEEPER-3348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16816810#comment-16816810 ] Hudson commented on ZOOKEEPER-3348: --- SUCCESS: Integrated in Jenkins build ZooKeeper

[jira] [Commented] (ZOOKEEPER-3351) Migrate qa-test-pullrequest ant task to maven

[ https://issues.apache.org/jira/browse/ZOOKEEPER-3351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16816812#comment-16816812 ] Hudson commented on ZOOKEEPER-3351: --- SUCCESS: Integrated in Jenkins build ZooKeeper

[jira] [Commented] (ZOOKEEPER-3143) Pluggable metrics system for ZooKeeper - Data Collection on Server

[ https://issues.apache.org/jira/browse/ZOOKEEPER-3143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16816809#comment-16816809 ] Hudson commented on ZOOKEEPER-3143: --- SUCCESS: Integrated in Jenkins build ZooKeeper

[jira] [Commented] (ZOOKEEPER-3332) TxnLogToolkit should print multi transactions readably

[ https://issues.apache.org/jira/browse/ZOOKEEPER-3332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16816811#comment-16816811 ] Hudson commented on ZOOKEEPER-3332: --- SUCCESS: Integrated in Jenkins build ZooKeeper

[GitHub] [zookeeper] eolivelli commented on issue #909: ZOOKEEPER-3362 Create a simple checkstyle file

eolivelli commented on issue #909: ZOOKEEPER-3362 Create a simple checkstyle file URL: https://github.com/apache/zookeeper/pull/909#issuecomment-482777416 retest ant build This is an automated message from the Apache Git Serv

Re: ZK Smoke Screen Test

Good job,Thanks for this:https://github.com/BELUGABEHR/zk-smoketest#running-under-dockerYou can give a PR to phunt's repo,let more people benefit from it.Look at ZOOKEEPER-3264 which is aimed to implement a better benchmark tool for zookeeper internal.Stay tuned! :D - Original Message -

Re: Re: [VOTE] Apache ZooKeeper release 3.5.5 candidate 3

+1, no bindingLook at my previous jepsen, benchmark and zkCli test, 3.5.5 works well. - Original Message - From: Andor Molnar To: DevZooKeeper Subject: Re: [VOTE] Apache ZooKeeper release 3.5.5 candidate 3 Date: 2019-04-12 19:58 Hi team, Just to wrap up the votes so far: We got +1 from

[jira] [Commented] (ZOOKEEPER-3351) Migrate qa-test-pullrequest ant task to maven

[ https://issues.apache.org/jira/browse/ZOOKEEPER-3351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16816853#comment-16816853 ] TisonKun commented on ZOOKEEPER-3351: - [~eolivelli] is there an umbrella issue ab