why not disable sync API in libzkst.a?

Hi,     I'm new to C API lib. I accidentally use single-thread lib (i.e. libzkst.a) and it took me quit a while before I realize all sync functions in the libzkst.a is not usable at all. I'm wondering why not just disable them in libztst.a. It would otherwise be pretty confusing and error-pro

[GitHub] [zookeeper] enixon commented on issue #851: ZOOKEEPER-3311: Allow a delay to the transaction log flush

enixon commented on issue #851: ZOOKEEPER-3311: Allow a delay to the transaction log flush URL: https://github.com/apache/zookeeper/pull/851#issuecomment-489902877 retest ant build This is an automated message from the Apache

[GitHub] [zookeeper] kabike commented on issue #931: ZOOKEEPER-3373:need change description for "Single System Image" guarantee in document

kabike commented on issue #931: ZOOKEEPER-3373:need change description for "Single System Image" guarantee in document URL: https://github.com/apache/zookeeper/pull/931#issuecomment-489897367 funny story, I just changed some MD documents, why checks faild? -

[GitHub] [zookeeper] enixon commented on issue #851: ZOOKEEPER-3311: Allow a delay to the transaction log flush

enixon commented on issue #851: ZOOKEEPER-3311: Allow a delay to the transaction log flush URL: https://github.com/apache/zookeeper/pull/851#issuecomment-489865136 Force pushing to fix merge conflicts with #876 This is an aut

[GitHub] [zookeeper] enixon commented on issue #851: ZOOKEEPER-3311: Allow a delay to the transaction log flush

enixon commented on issue #851: ZOOKEEPER-3311: Allow a delay to the transaction log flush URL: https://github.com/apache/zookeeper/pull/851#issuecomment-489862774 Internally, we ran a test that starts with no flush delay configured (eg. the default which has no flush delay and a max batch

[GitHub] [zookeeper] BELUGABEHR commented on issue #878: ZOOKEEPER-3339: Improve Debug and Trace Log Statements

BELUGABEHR commented on issue #878: ZOOKEEPER-3339: Improve Debug and Trace Log Statements URL: https://github.com/apache/zookeeper/pull/878#issuecomment-489782635 @anmolnar Can you please have the tests run once more on this? Thanks!

[GitHub] [zookeeper] BELUGABEHR commented on issue #912: ZOOKEEPER-3365: Use Concurrent HashMap with Counter in NettyServerCnxnFactory

BELUGABEHR commented on issue #912: ZOOKEEPER-3365: Use Concurrent HashMap with Counter in NettyServerCnxnFactory URL: https://github.com/apache/zookeeper/pull/912#issuecomment-489766744 @anmolnar Added a unit test for this feature. -

[jira] [Commented] (ZOOKEEPER-3331) Automatically add IP authorization for Netty connections

[ https://issues.apache.org/jira/browse/ZOOKEEPER-3331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16834148#comment-16834148 ] Hudson commented on ZOOKEEPER-3331: --- SUCCESS: Integrated in Jenkins build ZooKeeper

[jira] [Commented] (ZOOKEEPER-3305) Add Quorum Packet metrics

[ https://issues.apache.org/jira/browse/ZOOKEEPER-3305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16834147#comment-16834147 ] Hudson commented on ZOOKEEPER-3305: --- SUCCESS: Integrated in Jenkins build ZooKeeper

[jira] [Commented] (ZOOKEEPER-3331) Automatically add IP authorization for Netty connections

[ https://issues.apache.org/jira/browse/ZOOKEEPER-3331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16834132#comment-16834132 ] Hudson commented on ZOOKEEPER-3331: --- FAILURE: Integrated in Jenkins build Zookeeper

[jira] [Commented] (ZOOKEEPER-3305) Add Quorum Packet metrics

[ https://issues.apache.org/jira/browse/ZOOKEEPER-3305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16834131#comment-16834131 ] Hudson commented on ZOOKEEPER-3305: --- FAILURE: Integrated in Jenkins build Zookeeper

[GitHub] [zookeeper] enixon commented on issue #895: ZOOKEEPER-3349: QuorumCnxManager socketTimeout unused

enixon commented on issue #895: ZOOKEEPER-3349: QuorumCnxManager socketTimeout unused URL: https://github.com/apache/zookeeper/pull/895#issuecomment-489711179 @lvfangmin I considered that as an option but, since the sync limit can be changed by jmx, I think it's better for the QuorumCxnMan

[GitHub] [zookeeper] jhuan31 closed pull request #850: ZOOKEEPER-3309: Add sync processor metrics

jhuan31 closed pull request #850: ZOOKEEPER-3309: Add sync processor metrics URL: https://github.com/apache/zookeeper/pull/850 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [zookeeper] jhuan31 opened a new pull request #850: ZOOKEEPER-3309: Add sync processor metrics

jhuan31 opened a new pull request #850: ZOOKEEPER-3309: Add sync processor metrics URL: https://github.com/apache/zookeeper/pull/850 This is an automated message from the Apache Git Service. To respond to the message, please

[jira] [Resolved] (ZOOKEEPER-3331) Automatically add IP authorization for Netty connections

[ https://issues.apache.org/jira/browse/ZOOKEEPER-3331?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fangmin Lv resolved ZOOKEEPER-3331. --- Resolution: Fixed Fix Version/s: 3.6.0 Issue resolved by pull request 867 [https:/

[GitHub] [zookeeper] asfgit closed pull request #867: ZOOKEEPER-3331: Automatically add IP authorization for Netty connections

asfgit closed pull request #867: ZOOKEEPER-3331: Automatically add IP authorization for Netty connections URL: https://github.com/apache/zookeeper/pull/867 This is an automated message from the Apache Git Service. To respond

[GitHub] [zookeeper] asfgit closed pull request #849: ZOOKEEPER-3305: Add Quorum Packet metrics

asfgit closed pull request #849: ZOOKEEPER-3305: Add Quorum Packet metrics URL: https://github.com/apache/zookeeper/pull/849 This is an automated message from the Apache Git Service. To respond to the message, please log on t

[jira] [Resolved] (ZOOKEEPER-3305) Add Quorum Packet metrics

[ https://issues.apache.org/jira/browse/ZOOKEEPER-3305?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fangmin Lv resolved ZOOKEEPER-3305. --- Resolution: Fixed Issue resolved by pull request 849 [https://github.com/apache/zookeeper

[GitHub] [zookeeper] lvfangmin commented on issue #895: ZOOKEEPER-3349: QuorumCnxManager socketTimeout unused

lvfangmin commented on issue #895: ZOOKEEPER-3349: QuorumCnxManager socketTimeout unused URL: https://github.com/apache/zookeeper/pull/895#issuecomment-489669851 @enixon maybe change the QuorumCnxManager to use the timeout passed in is the right way to do here? ---

[jira] [Updated] (ZOOKEEPER-3373) need change description for "Single System Image" guarantee in document

[ https://issues.apache.org/jira/browse/ZOOKEEPER-3373?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated ZOOKEEPER-3373: -- Labels: pull-request-available (was: ) > need change description for "Single Syste

[GitHub] [zookeeper] kabike opened a new pull request #931: ZOOKEEPER-3373:need change description for "Single System Image" guarantee in document

kabike opened a new pull request #931: ZOOKEEPER-3373:need change description for "Single System Image" guarantee in document URL: https://github.com/apache/zookeeper/pull/931 In website, "Single System Image" is "A client will see the same view of the service regardless of the server that

[GitHub] [zookeeper] szepet commented on issue #930: ZOOKEEPER-1425:add version command to the zookeeper client shell

szepet commented on issue #930: ZOOKEEPER-1425:add version command to the zookeeper client shell URL: https://github.com/apache/zookeeper/pull/930#issuecomment-489604998 LGTM, still a nice patch! Thanks for the administration! :)

[GitHub] [zookeeper] anmolnar commented on a change in pull request #929: ZOOKEEPER-3361: Add multi version of getChildren request

anmolnar commented on a change in pull request #929: ZOOKEEPER-3361: Add multi version of getChildren request URL: https://github.com/apache/zookeeper/pull/929#discussion_r281147841 ## File path: zookeeper-server/src/test/java/org/apache/zookeeper/test/MultiTransactionTest.java ##

[GitHub] [zookeeper] anmolnar commented on a change in pull request #929: ZOOKEEPER-3361: Add multi version of getChildren request

anmolnar commented on a change in pull request #929: ZOOKEEPER-3361: Add multi version of getChildren request URL: https://github.com/apache/zookeeper/pull/929#discussion_r281146207 ## File path: zookeeper-server/src/main/java/org/apache/zookeeper/server/DataTree.java ##

[GitHub] [zookeeper] anmolnar commented on a change in pull request #929: ZOOKEEPER-3361: Add multi version of getChildren request

anmolnar commented on a change in pull request #929: ZOOKEEPER-3361: Add multi version of getChildren request URL: https://github.com/apache/zookeeper/pull/929#discussion_r281148025 ## File path: zookeeper-server/src/test/java/org/apache/zookeeper/test/MultiTransactionTest.java ##

[GitHub] [zookeeper] szepet edited a comment on issue #922: ZOOKEEPER-3361: Add multi version of getChildren request

szepet edited a comment on issue #922: ZOOKEEPER-3361: Add multi version of getChildren request URL: https://github.com/apache/zookeeper/pull/922#issuecomment-489543573 @anmolnar For the version where this functionality is integrated in the multi operation, see PR-913

[GitHub] [zookeeper] szepet commented on issue #922: ZOOKEEPER-3361: Add multi version of getChildren request

szepet commented on issue #922: ZOOKEEPER-3361: Add multi version of getChildren request URL: https://github.com/apache/zookeeper/pull/922#issuecomment-489543573 For the version where this functionality is integrated in the multi operation, see PR-913 -