Re: PostCommit- CI job ? Where it is ?

2019-06-13 Thread Enrico Olivelli
Il ven 14 giu 2019, 00:50 Michael Han ha scritto: > I see now. This was a job I set up long time ago for my own testing purpose > only; it was not intended to be part of official commit workflow. I am not > sure how this job becomes the official post commit job though. If we have > daily builds (

Re: PostCommit- CI job ? Where it is ?

2019-06-13 Thread Michael Han
I see now. This was a job I set up long time ago for my own testing purpose only; it was not intended to be part of official commit workflow. I am not sure how this job becomes the official post commit job though. If we have daily builds (do we) - then probably we don't need this. Though keep it do

Re: [DISCUSS] Voting on pull requests

2019-06-13 Thread Patrick Hunt
On Thu, Jun 13, 2019 at 11:08 AM Fangmin Lv wrote: > Agree to not commit if there is a -1, and we should align with that rule. > > I'm not sure if "request to change" is equal to -1 though, in theory all > comments may require to change something. It would be great for the > reviewers who provide

Re: [DISCUSS] Voting on pull requests

2019-06-13 Thread Fangmin Lv
Agree to not commit if there is a -1, and we should align with that rule. I'm not sure if "request to change" is equal to -1 though, in theory all comments may require to change something. It would be great for the reviewers who provided opinions to review again, but it seems to me if it's not a c

Re: contributor permission apply

2019-06-13 Thread leesf
Thank Enrico and Patrick. A PR opened https://github.com/apache/zookeeper/pull/988 Best, Leesf Patrick Hunt 于2019年6月12日周三 下午10:46写道： > Some good "how to contribute" docs here: > https://cwiki.apache.org/confluence/display/ZOOKEEPER/HowToContribute > > Regards, > > Patrick > > On Wed, Jun 12, 2

Build failed in Jenkins: ZooKeeper-trunk-owasp #395

2019-06-13 Thread Apache Jenkins Server
See -- [...truncated 28.43 KB...] [ivy:retrieve] [SUCCESSFUL ] org.owasp#dependency-check-utils;4.0.2!dependency-check-utils.jar (44ms) [ivy:retrieve] downloading https://repo1.mav

[jira] [Created] (ZOOKEEPER-3429) Flaky test test:org.apache.zookeeper.test.DisconnectedWatcherTest.testManyChildWatchersAutoReset

2019-06-13 Thread maoling (JIRA)
maoling created ZOOKEEPER-3429: -- Summary: Flaky test test:org.apache.zookeeper.test.DisconnectedWatcherTest.testManyChildWatchersAutoReset Key: ZOOKEEPER-3429 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3429