Re: [DISCUSS][PROPOSAL] Require JDK 11 to build for 3.7

2020-10-16 Thread Enrico Olivelli
Christopher I appreciate your idea and I also moved lots of my projects to work the way you are suggesting. We must run tests using real jdk8 to test the Zookeeper client. We must ensure that Zookeeper works well, especially while dealing with security stuff. Currently the client is in the same m

[DISCUSS][PROPOSAL] Require JDK 11 to build for 3.7

2020-10-16 Thread Christopher
Hi ZK Devs, With recent advancements in Java (since Java 9), it is now generally no longer necessary to require that software be developed on an older JDK in order to have confidence that it will run on the older version of Java. This is because, as of Java 9, all JDK releases have better support

[jira] [Created] (ZOOKEEPER-3975) Zookeeper crashes: Unable to load database on disk java.io.IOException: Unreasonable length

2020-10-16 Thread Jira
Diego Lucas Jiménez created ZOOKEEPER-3975: -- Summary: Zookeeper crashes: Unable to load database on disk java.io.IOException: Unreasonable length Key: ZOOKEEPER-3975 URL: https://issues.apache.org/jira/br

Re: Question about checkstyle execution

2020-10-16 Thread Enrico Olivelli
Il giorno ven 16 ott 2020 alle ore 16:07 Christopher ha scritto: > Since rat runs fairly quickly, and because it enforces license header > requirements that are mandated by ASF policy I find it very useful. > > However, I just ran into > https://issues.apache.org/jira/browse/ZOOKEEPER-3974, so ra

Re: Question about checkstyle execution

2020-10-16 Thread Christopher
Since rat runs fairly quickly, and because it enforces license header requirements that are mandated by ASF policy I find it very useful. However, I just ran into https://issues.apache.org/jira/browse/ZOOKEEPER-3974, so rat check only works on a clean checkout... and only before the generate-sourc

[jira] [Created] (ZOOKEEPER-3974) Generated build files from zookeeper-client-c should be in target/ directory

2020-10-16 Thread Christopher Tubbs (Jira)
Christopher Tubbs created ZOOKEEPER-3974: Summary: Generated build files from zookeeper-client-c should be in target/ directory Key: ZOOKEEPER-3974 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3974

Re: Question about checkstyle execution

2020-10-16 Thread Enrico Olivelli
Spotbugs is too heavy so I prefer to have it disabled by default. Rat is not very useful so it is a no for me Enrico Il Ven 16 Ott 2020, 15:35 Christopher ha scritto: > What about apache-rat and spotbugs? Should those execute by default also? > > On Fri, Oct 16, 2020 at 9:29 AM Enrico Olivelli

Re: Question about checkstyle execution

2020-10-16 Thread Christopher
What about apache-rat and spotbugs? Should those execute by default also? On Fri, Oct 16, 2020 at 9:29 AM Enrico Olivelli wrote: > > Christopher, > I think it is only a leftover of the adoption of checkstyle. > > Feel free to send a patch and activate it by default > > > Enrico > > Il Ven 16 Ott

Re: Question about checkstyle execution

2020-10-16 Thread Enrico Olivelli
Christopher, I think it is only a leftover of the adoption of checkstyle. Feel free to send a patch and activate it by default Enrico Il Ven 16 Ott 2020, 15:25 Christopher ha scritto: > Hi ZK Devs, > > I am working on ZOOKEEPER-3973 and I noticed the existing Travis CI > job executes `checkst

Question about checkstyle execution

2020-10-16 Thread Christopher
Hi ZK Devs, I am working on ZOOKEEPER-3973 and I noticed the existing Travis CI job executes `checkstyle:check` on the command line. I checked the pom.xml files and there is an execution defined in the `` section of the main pom.xml and another one in the zookeeper-contrib/pom.xml. However, neithe

[jira] [Created] (ZOOKEEPER-3973) Create configuration files GitHub Actions CI builds

2020-10-16 Thread Christopher Tubbs (Jira)
Christopher Tubbs created ZOOKEEPER-3973: Summary: Create configuration files GitHub Actions CI builds Key: ZOOKEEPER-3973 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3973 Project: Zoo