Re: [DISCUSS] Voting on pull requests

2019-06-06 Thread Andor Molnár
Exactly. On 2019. 06. 06. 14:51, Flavio Junqueira wrote: > That's covered in the project bylaws, right? > > https://zookeeper.apache.org/bylaws.html > > > -Flavio > >> On 6 Jun 2019, at 13:49, Enrico Olivelli wrote: >> >> Il gio 6 giu 2019, 12:44

Re: Maven release findings

2019-05-20 Thread Andor Molnár
Answers inline. On 5/20/19 20:15, Enrico Olivelli wrote: > Il lun 20 mag 2019, 19:59 Andor Molnar ha > scritto: > >> Hi team, >> >> We're looking pretty good, I've updated the Maven release page with >> experiences of this release: >> >>

Re: [VOTE] Separate mailing lists for Jira and Github/Gitbox notifications

2019-05-12 Thread Andor Molnár
Vote cancelled, because the discussion is still ongoing. Please follow-up on the other thread. Andor On 5/12/19 18:10, Patrick Hunt wrote: > For some reason the vote was started at the very same time as the discuss. > Andor can you cancel this vote thread until the discussion happens? We >

Re: Crypto Policy (was: Re: [VOTE] Apache ZooKeeper release 3.5.5 candidate 5)

2019-05-01 Thread Andor Molnár
Yes, I'll will create a new RC soon based on Enrico's -1. Andor On 4/30/19 23:34, Flavio Junqueira wrote: > Thanks for the input, Andor and Norbert. I managed to get it to work. Using > "hostname -f" like in the instructions was not working for me. I tried adding > names to /etc/hosts, but

Re: Raise the Quality of ZooKeeper Docs with Google Season of Docs Project

2019-04-24 Thread Andor Molnár
Hi Fangmin, This is great stuff, I like the idea and happy to attend if I gonna be still around in the next season. ;-) Regards, Andor On 4/23/19 18:42, Fangmin Lv wrote: > Hi guy, > > Raise here to see if we have interest to participant in the Google Season > of Docs or not. > > (The

Re: [VOTE] Apache ZooKeeper release 3.5.5 candidate 3

2019-04-09 Thread Andor Molnár
Thanks Enrico for testing. I think both checks are valid and should be added to the release verification procedure. None of the issues are showstopper for the RC, but let's fix them to get a clean sheet. - Spotbugs issue can be ignored - null-check is valid when the version has qualifier: e.g.

Re: Test failure on branch-3.4 Java 11 build

2019-02-19 Thread Andor Molnár
The build was successful (red, but different error) on H31 again without any modification. Now what? :) Andor On 2/18/19 11:40, Andor Molnar wrote: > Infra ticket raised: > > https://issues.apache.org/jira/browse/INFRA-17866 > > I'll continue with the release procedure, since the build

Re: Pull requests validation - Maven is active - heads up!

2019-02-03 Thread Andor Molnár
Great work, thanks Enrico! Are u planning to enable C++ tests too? Andor On 2/2/19 10:32, Enrico Olivelli wrote: > Hi ZooKeepers, > I have enabled validation of Pull Requests with Maven. > > In order to trigger the tests with ANT add a comment with: > retest ant build > > In order to trigger

Re: JAVA 11 build is broken on 3.5

2019-01-09 Thread Andor Molnár
port bundle: >>>> >>>> ZOOKEEPER-3131 org.apache.zookeeper.server.WatchManager resource leak >>>> >>>> Our experience with Netty has been positive so far though I don't >> think we >>>> have enough info to declare it is stable. It makes a l

Re: JAVA 11 build is broken on 3.5

2019-01-04 Thread Andor Molnár
I got another one: ZOOKEEPER-3163 Use session map to improve the performance when closing session in Netty So, that doesn't seem too many. We can talk about backporting them, but I don't think they're super critical for the first stable release. Regarding 3.4, I need to validate the embedded

Re: Migrating ZooKeeper to GitBox

2018-12-17 Thread Andor Molnár
Keeper/> > > Andor > > > >> On 2018. Dec 16., at 21:14, Andor Molnár wrote: >> >> I don't get it either, something was said about git.apache.org would >> stop working. Perhaps that's how they meant that. :) >> >> Anyway, looks like trunk

Re: ZooKeeper 3.5 blocker issues

2018-12-17 Thread Andor Molnár
t;>>> upstream it part by part, but I don't expect it's being merged in >>> the >>>>>>> next >>>>>>>>> few weeks. So yes, it's a nice to have, but definitely not a block >>> for >>>>>>> 3.5. >>>>

Re: Migrating ZooKeeper to GitBox

2018-12-16 Thread Andor Molnár
he.org/>. >> >> I started to migrate the build configs to gitbox, first starting with >> 'ZooKeeper-trunk' for testing. >> >> Andor >> >> >> >> >> >>> On 2018. Dec 15., at 7:12, Andor Molnár wrote: >>> >>> C

Re: Migrating ZooKeeper to GitBox

2018-12-14 Thread Andor Molnár
ion. > > You'll want to use git remote set-url to update your remote url. > > I'll update the Jenkins jobs now. > > Patrick > > On Fri, Dec 14, 2018 at 12:17 PM Andor Molnár wrote: > >> Here you are: >> >> >> https://issues.apache.org/jira/browse/INFRA

Re: Migrating ZooKeeper to GitBox

2018-12-14 Thread Andor Molnár
Here you are: https://issues.apache.org/jira/browse/INFRA-17446 Andor On 12/14/18 07:11, Fangmin Lv wrote: > +1 for proactive move. Is there a Jira to track this? > > Best, > Fangmin > > On Thu, Dec 13, 2018 at 6:41 PM Norbert Kalmar > wrote: > >> +1 (non-binding) for early voluntarily

Re: Cannot find doap file: http://zookeeper.apache.org/doap.rdf

2018-12-10 Thread Andor Molnár
What's the original location where it needs to be restored? asf-site/content/..? Tamaas, doap.rdf is still at the root of 'website' branch. I think we have to adjust pom.xml to copy it to the right place. Regards, Andor On 12/10/18 18:48, Patrick Hunt wrote: > Andor I believe you modified

Re: Findbugs issue on master?

2018-11-19 Thread Andor Molnár
the build failure was masked > by a flaky test...). > > On Mon, Nov 19, 2018 at 11:44 AM Enrico Olivelli > wrote: > >> Il lun 19 nov 2018, 20:41 Andor Molnár ha scritto: >> >>> Hi, >>> >>> >>> It seems we have a findbugs issue on mast

Findbugs issue on master?

2018-11-19 Thread Andor Molnár
Hi, It seems we have a findbugs issue on master and as a consequence PR builds cannot be green. Regards, Andor

Re: ZOOKEEPER-3183

2018-11-01 Thread Andor Molnár
Hi Tumati! Of course. Your contribution is much appreciated. Would you please open a github pull request, when you're ready with code change to let the community review it? Thanks, Andor On 10/28/18 07:17, Tumati Venky wrote: > Hi Team, > > I see some improvement in WatcherCleaner worker

Re: Decrease number of threads in Jenkins builds to reduce flakyness

2018-10-22 Thread Andor Molnár
Thanks Bogdan, so far so good. testNodeDataChanged is an old beast, I've a possible fix for that from @afine: https://github.com/apache/zookeeper/pull/300 Would be great if we could review it and get rid of this flaky. Andor On 10/20/18 06:41, Bogdan Kanivets wrote: > I think the argument

Re: Zookeeper at Twitter by Micheal

2018-10-14 Thread Andor Molnár
Great stuff Michael! Andor On 10/14/2018 12:26 AM, Enrico Olivelli wrote: > Hi Michael, > I just stepped into this very interesting post ! > > https://blog.twitter.com/engineering/en_us/topics/infrastructure/2018/zookeeper-at-twitter.html > > Thank you > Enrico

Re: New precommit job 'retest this please' trick

2018-09-24 Thread Andor Molnár
Awesome! On 09/24/2018 06:27 PM, Michael Han wrote: >>> How the new process any different from that? > Jenkins job triggered by "Rebuild" button can't write back the job result > to github, leading to a yellow pending check status even after the job > finished; while "test this please" does not

Re: ZooKeeper 3.5 blocker issues

2018-09-11 Thread Andor Molnár
Hi Jeelani, Thanks for letting me know. I'm happy to remove it from the list to get closer to a stable release. :) What's the feature which can be disabled to avoid data inconsistency? Andor On 09/10/2018 11:33 PM, Mohamed Jeelani wrote: > Thanks Andor for compiling this. Should we be

Re: Trying to find pattern in Flaky Tests

2018-07-19 Thread Andor Molnár
Thanks Pat for fixing the report. Very useful. I think it was unable to retrieve the test report, because there was no test report available for those builds at the time it was running. We might want to expose the error code in the below logs, but if you take a look at #104 and #100: test report

Re: Trying to find pattern in Flaky Tests

2018-07-19 Thread Andor Molnár
Thanks Bogdan. Your analysis is much appreciated. According to your findings, it looks like it must be an infrastructure issue. But that doesn't explain why the test is a lot more stable on the 3.4 branch. I'd like to setup new jenkins jobs on a private infrastructure (other than Apache) on