i found an interesting issue when merging PR 1444: an unintended
icloud email popped up. (it looks like the simple retrigger commits
were done with that email.) i thought i could override it with the
author prompt but that only adds authors. i ended up modifying the
script slightly to account for i
thank you for figuring this out! two questions:
1) is there a daily test build still running? if so, where can we see
its status?
2) what is the easiest way to retrigger tests? (sorry, i know i've
asked this before :'( )
ben
On Wed, Feb 10, 2021 at 2:18 AM Szalay-Bekő Máté
wrote:
>
> > For puni
i would really like to get ZOOKEEPER-3922 but it needs to be rebased
and retested. is there a nice way to do that on github? or does the
pull requestor need to do that?
happy new year,
ben
Benjamin Reed created ZOOKEEPER-3922:
Summary: Add support for two server ZooKeeper with hardware oracle
Key: ZOOKEEPER-3922
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3922
Project
great thanx! i've put a reference to this page at the top of the other
page. (i'm glad we have a script!!!)
thanx
ben
On Thu, Apr 16, 2020 at 11:05 AM Enrico Olivelli wrote:
>
> Il Gio 16 Apr 2020, 19:39 Benjamin Reed ha scritto:
>
> > i want to start getting chris
i want to start getting christopher's maven changes in! starting with
https://github.com/apache/zookeeper/pull/1313 it's been a while since
I've actually pushed. i wanted to make sure
https://cwiki.apache.org/confluence/display/ZOOKEEPER/Committing+changes
is still update before i followed the inst
did you mean to mention the c client in the list of things to move to
another repo? it's not in contribs right now.
i think it would be nice to clean the contrib a bit. i don't really
support moving it to a separate repo. the nice thing about keeping it
in the same repo is that when there is a cha
i think the unique port assignment (d) is more problematic than it
appears. there is a race between finding a free port and actually
grabbing it. i think that contributes to the flakiness.
ben
On Fri, Oct 12, 2018 at 8:50 AM Andor Molnar wrote:
>
> That is a completely valid point. I started to i
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16615566#comment-16615566
]
Benjamin Reed commented on ZOOKEEPER-3108:
--
the reason we kept myid ou
we stop reading the socket once we hit max buffer size so we don't
overflow memory. it was put in when a buggy client cause the server to
think it was getting a 1G packet and ran out of memory trying to
allocate memory for it. in theory we could read in the data and just
drop it on the floor. this
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3104?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Benjamin Reed resolved ZOOKEEPER-3104.
--
Resolution: Fixed
Fix Version/s: 3.6.0
Issue resolved by pull request 583
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3036?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16561968#comment-16561968
]
Benjamin Reed commented on ZOOKEEPER-3036:
--
can you give a bit more de
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3095?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Benjamin Reed resolved ZOOKEEPER-3095.
--
Resolution: Fixed
Issue resolved by pull request 579
[https://github.com/apache
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3072?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Benjamin Reed resolved ZOOKEEPER-3072.
--
Resolution: Fixed
> Race condition in throttl
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3072?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Benjamin Reed updated ZOOKEEPER-3072:
-
Fix Version/s: 3.5.4
3.6.0
> Race condition in throttl
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3061?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Benjamin Reed resolved ZOOKEEPER-3061.
--
Resolution: Fixed
Fix Version/s: 3.6.0
Issue resolved by pull request 555
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3073?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Benjamin Reed resolved ZOOKEEPER-3073.
--
Resolution: Fixed
> fix couple of ty
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3078?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Benjamin Reed resolved ZOOKEEPER-3078.
--
Resolution: Fixed
> Remove unused print_completion_queue funct
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3079?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Benjamin Reed resolved ZOOKEEPER-3079.
--
Resolution: Fixed
> Fix unsafe use of sprintf(3) for creating IP address stri
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2886?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Benjamin Reed resolved ZOOKEEPER-2886.
--
Resolution: Fixed
> Permanent session moved error in multi-op only connecti
is there a button on jenkins somewhere that we can push to rerun a test?
thanx
ben
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16508441#comment-16508441
]
Benjamin Reed commented on ZOOKEEPER-3056:
--
how are you getting in a s
is there still going to be a meetup tomorrow? i don't see an
announcement anywhere.
ben
On Fri, Oct 13, 2017 at 12:02 PM, Jordan Zimmerman
wrote:
> Damn - I'm in Germany - that's 2 in the morning. Can't make it. If it's the
> week after, though, I can do it.
>
> -Jordan
>
>> On Oct 13, 2017, at
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2772?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Benjamin Reed resolved ZOOKEEPER-2772.
--
Resolution: Not A Bug
> Delete node command does not honor Acl pol
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16009215#comment-16009215
]
Benjamin Reed commented on ZOOKEEPER-2772:
--
this appears to
from patrick's response: "My intent at this point is not to replace
anything, just to add the ability to build with buck." this isn't to
move to a boutique build system. patrick is just suggesting that he
can make available the build files we use inside facebook for others
to try.
ben
On Mon, May
part of the reason we haven't moved to maven (this is supposition
since i have not been involved in the decision at all) is that it
doesn't buy that much over ant. both maven and ant are complex and
slow. the one thing maven has is the repository for dependencies.
i have been using buck for a whil
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15964730#comment-15964730
]
Benjamin Reed commented on ZOOKEEPER-2748:
--
we do this using the
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15929091#comment-15929091
]
Benjamin Reed commented on ZOOKEEPER-2693:
--
can someone put a good lin
Curator that has a cool new Java 8
> DSL: http://curator.apache.org/curator-x-async/index.html
> <http://curator.apache.org/curator-x-async/index.html>
>
> -JZ
>
>> On Mar 6, 2017, at 2:17 PM, Benjamin Reed wrote:
>>
>> have people given thought about movin
have people given thought about moving to java8? i'm really not that
excited about moving to java8, but we are running into libraries that
we want to use that are compiled with java8.
ben
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15873747#comment-15873747
]
Benjamin Reed commented on ZOOKEEPER-2184:
--
another option would be to
[
https://issues.apache.org/jira/browse/ZOOKEEPER-27?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Benjamin Reed reassigned ZOOKEEPER-27:
--
Assignee: (was: Mahadev konar)
Fix Version/s: (was: 3.0.0
[
https://issues.apache.org/jira/browse/ZOOKEEPER-27?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15854717#comment-15854717
]
Benjamin Reed commented on ZOOKEEPER-27:
had the joy of running into
[
https://issues.apache.org/jira/browse/ZOOKEEPER-27?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Benjamin Reed updated ZOOKEEPER-27:
---
Description:
Moved from SourceForge to Apache.
http://sourceforge.net/tracker/index.php
2017 at 3:47 PM, Benjamin Reed wrote:
>
>> i committed ZOOKEEPER-261 pull request to apache git using the perl
>> script. my .netrc wasn't setup properly and then i had a problem
>> trying to rerun with the failed branches in place. then i started
>> getting very wei
i committed ZOOKEEPER-261 pull request to apache git using the perl
script. my .netrc wasn't setup properly and then i had a problem
trying to rerun with the failed branches in place. then i started
getting very weird errors at the last step of the script and realized
that the patch had already bee
[
https://issues.apache.org/jira/browse/ZOOKEEPER-261?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Benjamin Reed resolved ZOOKEEPER-261.
-
Resolution: Fixed
committed to master
> Reinitialized servers should not particip
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15752196#comment-15752196
]
Benjamin Reed commented on ZOOKEEPER-2325:
--
[~rgs] can you commit this
Benjamin Reed created ZOOKEEPER-2640:
Summary: fix test coverage for single threaded C-API
Key: ZOOKEEPER-2640
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2640
Project: ZooKeeper
> right before generating the first rc for a release and create blocker jiras
> in the case there is any issue.
>
> -Flavio
>
>> On 30 Nov 2016, at 23:12, Benjamin Reed wrote:
>>
>> yeah, that's a deeper question. pat or flavio can correct me on this,
>
Jordan
>
>> On Nov 30, 2016, at 11:23 PM, Benjamin Reed wrote:
>>
>> when we commit pull requests with doc changes, i think we should
>> commit the generated doc as a separate commit. what do you all think?
>> i would like to do that to keep the change from the contributors
>> pristine :) and i think it simplifies things a bit.
>>
>> ben
>
when we commit pull requests with doc changes, i think we should
commit the generated doc as a separate commit. what do you all think?
i would like to do that to keep the change from the contributors
pristine :) and i think it simplifies things a bit.
ben
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15706785#comment-15706785
]
Benjamin Reed commented on ZOOKEEPER-2325:
--
hey andrew, i've merge
looks good!
On Wed, Nov 16, 2016 at 2:20 PM, Patrick Hunt wrote:
> Hi folks. Ben asked me to give a quick 5-10 minute overview at the meetup
> tomorrow giving insight into progress over the last year. Please see the
> linked slides that I put together. If you have any comments or thoughts wrt
> t
sorry for the late notice, but we have found out from security that we
will need an email and phone number to get you in without the usual
visitor NDA. if you are coming, please send an email to acon...@fb.com
with that information by tonight.
if you forget to do this or decide to come at the last
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15645962#comment-15645962
]
Benjamin Reed commented on ZOOKEEPER-2014:
--
shall i commit it or ar
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15635265#comment-15635265
]
Benjamin Reed commented on ZOOKEEPER-2014:
--
ah that makes sense. i di
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15634422#comment-15634422
]
Benjamin Reed commented on ZOOKEEPER-2014:
--
just a curious observer: why
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15632820#comment-15632820
]
Benjamin Reed commented on ZOOKEEPER-2619:
--
i would love to see ZOOKEEPE
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15632811#comment-15632811
]
Benjamin Reed commented on ZOOKEEPER-2619:
--
multi will handle some of
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15632776#comment-15632776
]
Benjamin Reed commented on ZOOKEEPER-2623:
--
i agree that we should ha
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2592?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15632763#comment-15632763
]
Benjamin Reed commented on ZOOKEEPER-2592:
--
it sounds like we should c
this is just a reminder that we have a zookeeper meetup at facebook on
november 17. note that usually you have to sign an NDA to get into
facebook, but for the meetup we are giving security a list of people
for the event so that they can get in without an NDA. that's why we
need you to mark you are
i also pushed a new version for
https://issues.apache.org/jira/browse/ZOOKEEPER-761 although that one might
be tricky since there are attached patches and a pr. should the pr still be
qaed?
On Thu, Oct 27, 2016 at 12:04 PM, Michael Han wrote:
> Created PR94 to ZOOKEEPER-2014. It's been 2 hours,
[
https://issues.apache.org/jira/browse/ZOOKEEPER-761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15612002#comment-15612002
]
Benjamin Reed commented on ZOOKEEPER-761:
-
not yet, i have a mac and t
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15607124#comment-15607124
]
Benjamin Reed commented on ZOOKEEPER-2597:
--
btw thanx for the script ed
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2597?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Benjamin Reed resolved ZOOKEEPER-2597.
--
Resolution: Fixed
> Add script to merge PR from Apache git repo to Git
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15607121#comment-15607121
]
Benjamin Reed commented on ZOOKEEPER-2597:
--
i used the script to commit
[
https://issues.apache.org/jira/browse/ZOOKEEPER-761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15605468#comment-15605468
]
Benjamin Reed commented on ZOOKEEPER-761:
-
for some reason my comments/cha
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15605414#comment-15605414
]
Benjamin Reed commented on ZOOKEEPER-2597:
--
i'll commit at end of d
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15605408#comment-15605408
]
Benjamin Reed commented on ZOOKEEPER-2597:
--
for some reason my comments
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15604093#comment-15604093
]
Benjamin Reed commented on ZOOKEEPER-2619:
--
thanx diego, you did exp
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15598842#comment-15598842
]
Benjamin Reed commented on ZOOKEEPER-2619:
--
i think it's a goo
; > patch or at least describe the issue?
> >
> > -Flavio
> >
> > > On 19 Oct 2016, at 18:25, Benjamin Reed wrote:
> > >
> > > build.xml still has some svn stuff in it. can someone fix? pat?
> > >
> > > thanx
> > > ben
> >
> >
>
build.xml still has some svn stuff in it. can someone fix? pat?
thanx
ben
[
https://issues.apache.org/jira/browse/ZOOKEEPER-761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15586819#comment-15586819
]
Benjamin Reed commented on ZOOKEEPER-761:
-
this is a pretty good patch to
yes. we'll put up streaming information on the event page when the time
gets closer.
On Tue, Oct 18, 2016 at 5:10 AM, Edward Ribeiro
wrote:
> There will be live streaming? :)
>
> Thanks,
> Edward
>
> On Tue, Oct 18, 2016 at 2:51 AM, Benjamin Reed wrote:
>
> > we
we would like to invite you all to a zookeeper meetup at the facebook
campus on november 17, 2016 starting at 5pm.
please use the following link to the facebook event to get details and rsvp.
https://www.facebook.com/events/1228722650504268
we need you to rsvp to make sure we plan appropriately
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15567516#comment-15567516
]
Benjamin Reed commented on ZOOKEEPER-2597:
--
cool i opened an infra jir
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15567338#comment-15567338
]
Benjamin Reed commented on ZOOKEEPER-2597:
--
are you still working on
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15559081#comment-15559081
]
Benjamin Reed edited comment on ZOOKEEPER-2597 at 10/9/16 2:1
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15559081#comment-15559081
]
Benjamin Reed commented on ZOOKEEPER-2597:
--
no problem. i made some rev
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15558730#comment-15558730
]
Benjamin Reed commented on ZOOKEEPER-2597:
--
did you put up the pull req
>>>
> > > > >>> For now, we do need to upload patches and converge using jira.
> > > > >>>
> > > > >>> I think Eddie has been looking at this process trying to
> replicate
> > > the
> > >
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15556598#comment-15556598
]
Benjamin Reed commented on ZOOKEEPER-2597:
--
great thanx! i have a coupl
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15552617#comment-15552617
]
Benjamin Reed commented on ZOOKEEPER-2597:
--
i'm just starting t
nworks.net>
>
> wrote:
>
>
> +1 (probably bringing along some people from Pinterest as well).
>
> -rgs
>
> On Sep 30, 2016 2:26 PM, "Marshall McMullen" <
>
> marshall.mcmul...@gmail.com>
>
> wrote:
>
> +1. I would love to attend a
did we bump the protocol version when we added the new errors? the server
could do the conversion when it responds to older clients.
On Mon, Oct 3, 2016 at 3:05 AM, Flavio Junqueira wrote:
> Hi Arshad,
>
> It makes sense to me. What if we convert unknown server errors to
> KeeperException.System
yes, vitalii is correct. the ping is a mutual test of health, so we want it
to go through the full pipeline.
On Mon, Oct 3, 2016 at 5:26 AM, Vitalii Tymchyshyn wrote:
> Hi.
>
> I think this would break ordering guarantie, would not it?
> Also ping is supposed to test health and I am not sure why
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2600?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Benjamin Reed resolved ZOOKEEPER-2600.
--
Resolution: Cannot Reproduce
> dangling ephemerals on overloaded server with lo
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15518765#comment-15518765
]
Benjamin Reed commented on ZOOKEEPER-2600:
--
i investigated this further
Benjamin Reed created ZOOKEEPER-2600:
Summary: dangling ephemerals on overloaded server with local
sessions
Key: ZOOKEEPER-2600
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2600
Project
> separate thread - Chris do you want to implement that change now that we've
> moved to git?
>
> Patrick
>
> On Wed, Sep 14, 2016 at 9:01 PM, Benjamin Reed wrote:
>
>> > 1) actually in the previous step that was just adding new files. you
>>> still
>&g
>
> > 1) actually in the previous step that was just adding new files. you
> still
> > need the commit -a for the rest of the changes. that's my normal
> workflow.
>
> I think that will be confusing for most folks. They typically stage
> all the changes and then commit or don't stage and use -a.
>
quot; from that same wiki page. I recommend you add back the
> --no-prefix until we are able to address (also impacts any pending
> patches created using the old style)
>
> Patrick
>
> On Mon, Sep 12, 2016 at 10:13 PM, Benjamin Reed wrote:
> > i've updated the contributing
tunity to learn a bit more about the
> moving parts of an Apache project if you consider becoming a ZK committer
> eventually.
>
> -Flavio
>
> > On 13 Sep 2016, at 06:13, Benjamin Reed wrote:
> >
> > i've updated the contributing to zookeeper wiki:
> > https:/
i've updated the contributing to zookeeper wiki:
https://cwiki.apache.org/confluence/display/ZOOKEEPER/HowToContribute
there are many ways to do things in git, so if others feel that there is a
better way please updated.
i think it would be cool to adopt a github based submission like other
proje
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15485391#comment-15485391
]
Benjamin Reed commented on ZOOKEEPER-2465:
--
the last time a similar i
do the svn->git migration although our repo isn't that
> large,
> > > > likely less. INFRA can do it, for example, on Saturday around
> 18:00 UTC.
> > > > Any concerns with such an approach?
> > > >
> > > > Patrick
> >
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15469376#comment-15469376
]
Benjamin Reed commented on ZOOKEEPER-2169:
--
can't you just do a sta
ep 1, 2016 at 3:44 AM, Jordan Zimmerman <
> > > jor...@jordanzimmerman.com
> > > >> wrote:
> > > >
> > > >> +1 (non binding)
> > > >>
> > > >>> On Aug 31, 2016, at 8:29 PM, Benjamin Reed
> wrote:
> > > &g
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15457459#comment-15457459
]
Benjamin Reed commented on ZOOKEEPER-2536:
--
BTW i think the patch is
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15457457#comment-15457457
]
Benjamin Reed commented on ZOOKEEPER-2537:
--
isn't this the same as
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15457447#comment-15457447
]
Benjamin Reed commented on ZOOKEEPER-2536:
--
+1 LGTM
> When provide p
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15457427#comment-15457427
]
Benjamin Reed commented on ZOOKEEPER-2539:
--
+1 looks good, just a format
gt; close upon IOException, which is exactly the behavior you mention you
> > >> should have.
> > >>
> > >> I'm thinking that in this case, if the channel is closed and it is
> null,
> > >> we throw IOException. I'm trying to understand wh
hopefully today). Either we should not
> bubble up any exception by IOException or ZK server should be stopped, as
> it is really hard to figure out without turning on tracing what really
> happened.
> ThanksYuliya
>
> From: Benjamin Reed
> To: Patrick Hunt
> Cc: D
if i remember correctly the case in sendResponse where it is catching the
IOException is due to the fact that we are opportunistically trying to send
something on a non-blocking channel. if it works, ok, but if we can't send
because we are blocked then we will just send later.
in the case of NIOSe
flip the switch to git and update the relevant scripts and docs.
i couldn't figure out which timeframe this falls under in the voting
procedure table, but i think it's safe to go with 3 days, so the vote will
close on Saturday, September 3 at 6:30pm pdt.
+1 from me
1 - 100 of 657 matches
Mail list logo
