I'm trying to attack some of the waiting patches, and I'm a bit perplexed about
ZOOKEEPER-1100.
The patch is to address the case where somehow a runtime exception causes the
SendThread to escape the while loop inside of the run method, and the thread
then dies. Why don't we change the state to C
mber 01, 2011 1:32 PM
To: dev@zookeeper.apache.org
Cc: tho...@koch.ro; Benjamin Reed
Subject: Re: cleanup and subjective patches
On Tue, Nov 1, 2011 at 9:51 AM, Fournier, Camille F.
wrote:
> Thomas, we all agree that you have done useful work. But right now it seems
> that you are mo
Hunt [mailto:ph...@apache.org]
Sent: Tuesday, November 01, 2011 1:15 PM
To: dev@zookeeper.apache.org
Cc: tho...@koch.ro; Benjamin Reed
Subject: Re: cleanup and subjective patches
On Tue, Nov 1, 2011 at 9:51 AM, Fournier, Camille F.
wrote:
> Committers, this checking in of code without tests has
d report for no new tests. Don't take it lightly.
C
-Original Message-
From: Thomas Koch [mailto:tho...@koch.ro]
Sent: Tuesday, November 01, 2011 12:12 PM
To: dev@zookeeper.apache.org
Cc: Fournier, Camille F. [Tech]; 'Benjamin Reed'
Subject: Re: cleanup and subjective
I also like mockito. It has some limitations but generally can be very useful.
However, I'm also very much a fan of fixing our code base to be more testable
against real servers. I actually like the fact that we use a lot of
"integration" testing in our automated build. You do catch things that
k on this build box?
Thanks,
Camille
-Original Message-
From: Patrick Hunt [mailto:ph...@apache.org]
Sent: Tuesday, November 01, 2011 11:56 AM
To: dev@zookeeper.apache.org
Subject: Re: ZooKeeper-trunk-WinVS2008 - Build # 61 - Still Failing
bui...@apache.org
On Tue, Nov 1, 2011 at 7:26 AM,
These are due to space issues, it looks like. Does anyone know who to contact
about disk space on the windows build box?
C
-Original Message-
From: Apache Jenkins Server [mailto:jenk...@builds.apache.org]
Sent: Tuesday, November 01, 2011 10:25 AM
To: dev@zookeeper.apache.org
Subject: Z
Any changes coming in without tests should really be meaningfully untestable. I
completely agree with the suggestion to require a testing uplift if you want to
add refactorings unless you know the refactored code has 90+% test coverage.
Personally, I have no problems with refactorings, but we se
It would be great if you could write some tests that illustrate these bugs.
Thanks,
C
-Original Message-
From: Thomas Koch [mailto:tho...@koch.ro]
Sent: Friday, October 28, 2011 11:04 AM
To: dev@zookeeper.apache.org
Subject: Possible failure scenarios with deserialization + multi?
Hi,
Let's get this baby out the door guys, this release has been lingering for a
long time.
On the list of blockers:
I have moved https://issues.apache.org/jira/browse/ZOOKEEPER-1159 from a
blocker for 3.4 to 3.5, since we never found a reproducible test for the code
or a reason for the reported bug
We have finally gotten a windows compile check automated build running here:
https://builds.apache.org/job/ZooKeeper-trunk-WinVS2008/
Note that this build does not run any tests (the cpp unit tests are not yet
ported to windows).
This will run nightly. Changes to the c client library need to pas
understand, and we don't
have any explanation of the issue that makes sense yet.
C
-Original Message-
From: Mahadev Konar [mailto:maha...@hortonworks.com]
Sent: Thursday, September 29, 2011 4:10 AM
To: dev@zookeeper.apache.org
Cc: ph...@apache.org; mspyc...@ebay.com; Fournier, C
I think it's great to encourage people to use it if they feel the need or
desire. Certainly for longer patches (new features especially) where you have a
lot of comments to make, reviewboard is useful. However, everyone has their own
workflow. For me, I always download every patch I review and i
This is expected. In cases where the network becomes unstable, it is the
responsibility of the client writer to handle disconnected events appropriately
and check to verify whether nodes they tried to write around the time of these
events did or did not succeed. It makes writing a "Generic" clie
;test timeouts are too small"
https://issues.apache.org/jira/browse/ZOOKEEPER-1160
Patrick
On Tue, Sep 20, 2011 at 6:54 AM, Fournier, Camille F.
wrote:
> Can someone kick this build? I'm investigating these test failures but they
> appear to be transient.
>
> -Original
Can someone kick this build? I'm investigating these test failures but they
appear to be transient.
-Original Message-
From: Apache Jenkins Server [mailto:jenk...@builds.apache.org]
Sent: Monday, September 19, 2011 5:48 AM
To: dev@zookeeper.apache.org
Subject: ZooKeeper_branch_3_3 - Buil
Session timeout is negotiated though eh? So if only the clients that need the
long GC session expiration time set their client session timeout to MAX_INT,
other clients can keep it at a lower number and not have a problem. That's how
we have resolved the issue. It does mean that if you have clie
On https://issues.apache.org/jira/browse/ZOOKEEPER-1159, I haven't heard back
from the original reporter on this issue. Does anyone else want to take a look?
This might be a bug but I've never been able to reproduce it and I don't think
the fix suggested in the ticket is the right one for reason
I think the major conventions are listed on the wiki:
https://cwiki.apache.org/confluence/display/ZOOKEEPER/HowToContribute
Mostly just indentation, and follow the style of the class you are modifying.
I personally do not like to see checkins to merely fix indentation issues, as
they muddy the c
FWIW, I pored over this and the NIO code a bit yesterday and couldn't find
anything obviously wrong, but NIO is a tricky beast. Is it possible that
because the channel never gets connected, and so we never call select, the
selector never cleans up the cancelledKeys and therefore hangs on to the
I had a user hit 1159, I will take on that one.
C
-Original Message-
From: Mahadev Konar [mailto:maha...@hortonworks.com]
Sent: Friday, September 02, 2011 1:54 PM
To: dev@zookeeper.apache.org
Cc: Fournier, Camille F. [Tech]; Benjamin Reed; Eugene Koontz; Vishal Kher
Subject: Re: 3.4
I have 1154 and 1156 I believe.
C
- Original Message -
From: Mahadev Konar
To: dev@zookeeper.apache.org
Cc: Fournier, Camille F. [Tech]; Benjamin Reed ; Eugene
Koontz ; Vishal Kher
Sent: Fri Sep 02 13:54:01 2011
Subject: Re: 3.4 update.
Thanks Alex for pointing out. A minor update
Hi Thomas,
Here's my feedback:
1. For any useful fixes you find here, please follow the normal procedures of
raising a ticket and attaching a patch. In my experience, static analysis tools
often carry with them a lot of irrelevant noise, but as long as the changes you
propose are clean and do
Did anyone ever check resetting watches at client reconnect on a client with a
chroot? Looking at the code, we store the watches associated with the
non-chroot path, but they are set by the original request prepending chroot to
the request. However, it looks like the SetWatches request on reconn
when AuthenticationProvider throws an exception
Probably should have caught up with all my email first... did you find
a resolution for this?
On Fri, Aug 12, 2011 at 11:00 AM, Fournier, Camille F.
wrote:
> Hi guys,
>
> So debugging some fun issues in my dev cluster, I discovered that due
Any status updates on getting this fixed?
Thanks,
C
-Original Message-
From: Apache Jenkins Server [mailto:jenk...@builds.apache.org]
Sent: Wednesday, August 24, 2011 6:54 AM
To: dev@zookeeper.apache.org
Subject: ZooKeeper-trunk - Build # 1274 - Still Failing
See https://builds.apache.
Anyone looking at this?
C
- Original Message -
From: Apache Jenkins Server
To: dev@zookeeper.apache.org
Sent: Fri Aug 19 06:54:08 2011
Subject: ZooKeeper-trunk - Build # 1270 - Still Failing
See https://builds.apache.org/job/ZooKeeper-trunk/1270/
#
The hammer tests always seem to fail for me too. I've started ignoring them,
which is probably not a good thing.
-Original Message-
From: Vishal Kathuria [mailto:vishal.kathu...@fb.com]
Sent: Thursday, August 18, 2011 4:11 PM
To: dev@zookeeper.apache.org
Subject: Question on test timeout
Hi guys,
So debugging some fun issues in my dev cluster, I discovered that due to some
bad user data, my AuthenticationProvider was throwing a null pointer exception
inside the handleAuthentication call. This call is made inside of
NIOServerCnxn.readRequest, and there is no try catch block. So
Anyone know what's up with this clover problem? Is this something the Jenkins
maintainers need to deal with?
C
-Original Message-
From: Apache Jenkins Server [mailto:jenk...@builds.apache.org]
Sent: Thursday, August 11, 2011 2:08 PM
To: dev@zookeeper.apache.org
Subject: ZooKeeper-trunk
You're looking to port the server-side code to C#? Why?
NHiberate/Hiberate is a client to a database, not a database (which is why it
makes sense to have both in the appropriate languages). But we could use a good
.NET client as part of the officially-supported project. I know that there has
bee
I might have time this weekend to look at some of this. If I do, I will keep
you guys in the loop.
C
-Original Message-
From: Eugene Koontz [mailto:ekoo...@hiro-tan.org]
Sent: Friday, August 05, 2011 2:02 PM
To: dev@zookeeper.apache.org
Subject: Re: 3.4 Release.
On 8/4/11 4:48 PM, Vish
7;ve moved to a dev discussion)
C
-Original Message-
From: Fournier, Camille F. [Tech]
Sent: Friday, August 05, 2011 11:57 AM
To: 'u...@zookeeper.apache.org'
Subject: RE: devops/admin/client question: What do you do when you rollback?
Hmmm. I thought I had another way around th
---
Hi,
On Mon, Aug 1, 2011 at 10:49 PM, Mahadev Konar wrote:
> Looks like jenkins is still having issues. Until then we can fix the
> Open issues we have:
>
> ZOOKEEPER-1125: Intermittent java core test failures
> Vishal do you want to take this up?
>
>
Sure. Am I the only one seeing this failur
Any updates on this? Do we have a date for this release yet?
Thanks,
C
-Original Message-
From: Mahadev Konar [mailto:maha...@apache.org]
Sent: Monday, June 20, 2011 3:57 PM
To: dev@zookeeper.apache.org
Subject: 3.4.0 release.
Hi all,
I have done a little bit of jira scrubbing to move
I see that this has failed a few precommit builds now, and someone reported it
failing in their local env regularly. Do we think this is just a general
transient test, or was there a change checked in recently that might related to
this code and its new transient failures? Perhaps it is just the
I don't have access to do that.
C
-Original Message-
From: Patrick Hunt [mailto:ph...@apache.org]
Sent: Wednesday, June 08, 2011 5:54 PM
To: dev@zookeeper.apache.org
Subject: Re: Released versions in jira
https://issues.apache.org/jira/browse/ZOOKEEPER
Click on "versions" on the left, t
Well the follower would get a full SNAP in that case, leaving a weird log
state. Would be useful though to list the series of events that would cause
such a scenario within the bounds of otherwise normal operating behavior (ie,
all machine logs were created by members of this cluster during the
I would recommend that you spend some time making sure that your guess about
the cause is correct before trying to design solutions to the problem. Can you
provide us some hard numbers, logs, and configuration information? It's always
possible that some aspect of your configuration that you hadn
All,
Is there some reason setACL doesn't update the mtime of a node? Seems like acl
modification is still a modification. Or is this just really intended to
indicate last modification of data?
Thanks,
Camille
I'm trying to look at the latest diff for ZOOKEEPER-702, and every time I click
view diff on the review I get some python error.
https://reviews.apache.org/r/483/
Do we have someone that can fix this, or is it unfixable?
Thanks,
C
IDATE requests
and we won't accept connections ourselves (so clients can't connect to us to
revalidate their session). So I think we are ok.
C
From: Fournier, Camille F. [Tech]
Sent: Monday, March 28, 2011 3:34 PM
To: 'dev@zookeeper.apache.org'
Subject: RE: send UPTODATE to f
Looking at the code it looks like we don't need a synched quorum to accept a
new client session, just a quorum in the process of synching, so I don't think
the session handling will solve this. I suppose it's a warning that correctness
for n=3 doesn't extend to all possible cluster sizes of N.
D
OK, thanks. Let me know what you think of 922. If there's any help I can
provide for 3.4 let me know.
C
-Original Message-
From: Mahadev Konar [mailto:maha...@apache.org]
Sent: Tuesday, March 22, 2011 2:35 AM
To: dev@zookeeper.apache.org
Cc: Fournier, Camille F. [Tech]
Subjec
Hi all,
I haven't heard anything back from my questions on
https://issues.apache.org/jira/browse/ZOOKEEPER-922 in a while. We are very
keen to have this functionality here because our users really do not understand
why data sticks around for a while after their connections are killed. I'd like
I'd really love to do something with 922 if I could get some more feedback on
the design. This is a very desirable feature for our users and I should be able
to knock something out in the 3.4 timeframe.
Thanks,
Camille
-Original Message-
From: Mahadev Konar [mailto:maha...@apache.org]
ll pass on
unix.
What are you doing for build env? Native VS project files?
Patrick
On Fri, Feb 4, 2011 at 7:20 AM, Fournier, Camille F. [Tech]
wrote:
> Hi all,
>
> We have created a windows native port for the C ZK client. We've done our own
> testing and it all seems to w
I strongly second this.
-Original Message-
From: Benjamin Reed [mailto:br...@yahoo-inc.com]
Sent: Thursday, February 17, 2011 12:34 PM
To: maha...@apache.org; dev@zookeeper.apache.org
Subject: Re: [VOTE] Release plan for 3.3.3
in the plan I proposed we would get a release out this week.
b 4, 2011 at 7:20 AM, Fournier, Camille F. [Tech]
wrote:
> Hi all,
>
> We have created a windows native port for the C ZK client. We've done our own
> testing and it all seems to work, and we'd like to contribute it back to the
> community. However, porting the existing unit te
Hi all,
We have created a windows native port for the C ZK client. We've done our own
testing and it all seems to work, and we'd like to contribute it back to the
community. However, porting the existing unit tests to windows has proven to be
incredibly difficult. It's not clear that we have th
I would really like to see 962 fix released asap as well.
C
-Original Message-
From: Benjamin Reed [mailto:br...@yahoo-inc.com]
Sent: Tuesday, January 25, 2011 2:27 PM
To: dev@zookeeper.apache.org
Subject: 3.3.3 release
the 962 bug we fixed was pretty severe. i would like to get a relea
Is the code somewhere we can look at it right now?
C
-Original Message-
From: Avery Ching [mailto:ach...@yahoo-inc.com]
Sent: Tuesday, January 11, 2011 2:02 PM
To: dev@zookeeper.apache.org
Subject: Discussion - Clusterlib as a subproject for ZooKeeper
Hello,
We have been working on Clu
zxid sent,
otherwise we end up sending duplicates.
thanx for catching this camille!
ben
On 12/20/2010 03:17 PM, Fournier, Camille F. [Tech] wrote:
> Oh, I did not articulate myself well. I mean the sync when a follower starts
> up ("syncWithLeader" as it were), which doesn
eader determines the ordering.
ok, that was a rather long simple answer :)
ben
On 12/20/2010 11:22 AM, Fournier, Camille F. [Tech] wrote:
> Hi everyone,
>
> A simple question with a possibly not simple answer:
> For transactions that happen and are committed on the leader/in the clust
Hi everyone,
A simple question with a possibly not simple answer:
For transactions that happen and are committed on the leader/in the cluster
(given a cluster with quorum already) during the time in which a new follower
is being synced (sending diffs, sync, etc), what mechanism is it that ensure
55 matches
Mail list logo
