Any changes coming in without tests should really be meaningfully untestable. I
completely agree with the suggestion to require a testing uplift if you want to
add refactorings unless you know the refactored code has 90+% test coverage.
Personally, I have no problems with refactorings, but we
These are due to space issues, it looks like. Does anyone know who to contact
about disk space on the windows build box?
C
-Original Message-
From: Apache Jenkins Server [mailto:jenk...@builds.apache.org]
Sent: Tuesday, November 01, 2011 10:25 AM
To: dev@zookeeper.apache.org
Subject:
?
Thanks,
Camille
-Original Message-
From: Patrick Hunt [mailto:ph...@apache.org]
Sent: Tuesday, November 01, 2011 11:56 AM
To: dev@zookeeper.apache.org
Subject: Re: ZooKeeper-trunk-WinVS2008 - Build # 61 - Still Failing
bui...@apache.org
On Tue, Nov 1, 2011 at 7:26 AM, Fournier, Camille F
I also like mockito. It has some limitations but generally can be very useful.
However, I'm also very much a fan of fixing our code base to be more testable
against real servers. I actually like the fact that we use a lot of
integration testing in our automated build. You do catch things that
it lightly.
C
-Original Message-
From: Thomas Koch [mailto:tho...@koch.ro]
Sent: Tuesday, November 01, 2011 12:12 PM
To: dev@zookeeper.apache.org
Cc: Fournier, Camille F. [Tech]; 'Benjamin Reed'
Subject: Re: cleanup and subjective patches
Fournier, Camille F.:
Any changes coming in without
...@apache.org]
Sent: Tuesday, November 01, 2011 1:15 PM
To: dev@zookeeper.apache.org
Cc: tho...@koch.ro; Benjamin Reed
Subject: Re: cleanup and subjective patches
On Tue, Nov 1, 2011 at 9:51 AM, Fournier, Camille F.
camille.fourn...@gs.com wrote:
Committers, this checking in of code without tests has got
It would be great if you could write some tests that illustrate these bugs.
Thanks,
C
-Original Message-
From: Thomas Koch [mailto:tho...@koch.ro]
Sent: Friday, October 28, 2011 11:04 AM
To: dev@zookeeper.apache.org
Subject: Possible failure scenarios with deserialization + multi?
Hi,
Let's get this baby out the door guys, this release has been lingering for a
long time.
On the list of blockers:
I have moved https://issues.apache.org/jira/browse/ZOOKEEPER-1159 from a
blocker for 3.4 to 3.5, since we never found a reproducible test for the code
or a reason for the reported
We have finally gotten a windows compile check automated build running here:
https://builds.apache.org/job/ZooKeeper-trunk-WinVS2008/
Note that this build does not run any tests (the cpp unit tests are not yet
ported to windows).
This will run nightly. Changes to the c client library need to
explanation of the issue that makes sense yet.
C
-Original Message-
From: Mahadev Konar [mailto:maha...@hortonworks.com]
Sent: Thursday, September 29, 2011 4:10 AM
To: dev@zookeeper.apache.org
Cc: ph...@apache.org; mspyc...@ebay.com; Fournier, Camille F. [Tech]; Benjamin
Reed
Subject
I think it's great to encourage people to use it if they feel the need or
desire. Certainly for longer patches (new features especially) where you have a
lot of comments to make, reviewboard is useful. However, everyone has their own
workflow. For me, I always download every patch I review and
This is expected. In cases where the network becomes unstable, it is the
responsibility of the client writer to handle disconnected events appropriately
and check to verify whether nodes they tried to write around the time of these
events did or did not succeed. It makes writing a Generic
Can someone kick this build? I'm investigating these test failures but they
appear to be transient.
-Original Message-
From: Apache Jenkins Server [mailto:jenk...@builds.apache.org]
Sent: Monday, September 19, 2011 5:48 AM
To: dev@zookeeper.apache.org
Subject: ZooKeeper_branch_3_3 -
it
only went to 3.4/trunk.
test timeouts are too small
https://issues.apache.org/jira/browse/ZOOKEEPER-1160
Patrick
On Tue, Sep 20, 2011 at 6:54 AM, Fournier, Camille F.
camille.fourn...@gs.com wrote:
Can someone kick this build? I'm investigating these test failures but they
appear
On https://issues.apache.org/jira/browse/ZOOKEEPER-1159, I haven't heard back
from the original reporter on this issue. Does anyone else want to take a look?
This might be a bug but I've never been able to reproduce it and I don't think
the fix suggested in the ticket is the right one for
I think the major conventions are listed on the wiki:
https://cwiki.apache.org/confluence/display/ZOOKEEPER/HowToContribute
Mostly just indentation, and follow the style of the class you are modifying.
I personally do not like to see checkins to merely fix indentation issues, as
they muddy the
FWIW, I pored over this and the NIO code a bit yesterday and couldn't find
anything obviously wrong, but NIO is a tricky beast. Is it possible that
because the channel never gets connected, and so we never call select, the
selector never cleans up the cancelledKeys and therefore hangs on to the
Hi Thomas,
Here's my feedback:
1. For any useful fixes you find here, please follow the normal procedures of
raising a ticket and attaching a patch. In my experience, static analysis tools
often carry with them a lot of irrelevant noise, but as long as the changes you
propose are clean and
I have 1154 and 1156 I believe.
C
- Original Message -
From: Mahadev Konar maha...@hortonworks.com
To: dev@zookeeper.apache.org dev@zookeeper.apache.org
Cc: Fournier, Camille F. [Tech]; Benjamin Reed br...@yahoo-inc.com; Eugene
Koontz ekoo...@hiro-tan.org; Vishal Kher vishalm
I had a user hit 1159, I will take on that one.
C
-Original Message-
From: Mahadev Konar [mailto:maha...@hortonworks.com]
Sent: Friday, September 02, 2011 1:54 PM
To: dev@zookeeper.apache.org
Cc: Fournier, Camille F. [Tech]; Benjamin Reed; Eugene Koontz; Vishal Kher
Subject: Re: 3.4
Did anyone ever check resetting watches at client reconnect on a client with a
chroot? Looking at the code, we store the watches associated with the
non-chroot path, but they are set by the original request prepending chroot to
the request. However, it looks like the SetWatches request on
AuthenticationProvider throws an exception
Probably should have caught up with all my email first... did you find
a resolution for this?
On Fri, Aug 12, 2011 at 11:00 AM, Fournier, Camille F.
camille.fourn...@gs.com wrote:
Hi guys,
So debugging some fun issues in my dev cluster, I discovered
Any status updates on getting this fixed?
Thanks,
C
-Original Message-
From: Apache Jenkins Server [mailto:jenk...@builds.apache.org]
Sent: Wednesday, August 24, 2011 6:54 AM
To: dev@zookeeper.apache.org
Subject: ZooKeeper-trunk - Build # 1274 - Still Failing
See
Anyone looking at this?
C
- Original Message -
From: Apache Jenkins Server jenk...@builds.apache.org
To: dev@zookeeper.apache.org dev@zookeeper.apache.org
Sent: Fri Aug 19 06:54:08 2011
Subject: ZooKeeper-trunk - Build # 1270 - Still Failing
See
The hammer tests always seem to fail for me too. I've started ignoring them,
which is probably not a good thing.
-Original Message-
From: Vishal Kathuria [mailto:vishal.kathu...@fb.com]
Sent: Thursday, August 18, 2011 4:11 PM
To: dev@zookeeper.apache.org
Subject: Question on test
You're looking to port the server-side code to C#? Why?
NHiberate/Hiberate is a client to a database, not a database (which is why it
makes sense to have both in the appropriate languages). But we could use a good
.NET client as part of the officially-supported project. I know that there has
---
Hi,
On Mon, Aug 1, 2011 at 10:49 PM, Mahadev Konar maha...@hortonworks.comwrote:
Looks like jenkins is still having issues. Until then we can fix the
Open issues we have:
ZOOKEEPER-1125: Intermittent java core test failures
Vishal do you want to take this up?
Sure. Am I the only one
I see that this has failed a few precommit builds now, and someone reported it
failing in their local env regularly. Do we think this is just a general
transient test, or was there a change checked in recently that might related to
this code and its new transient failures? Perhaps it is just
Well the follower would get a full SNAP in that case, leaving a weird log
state. Would be useful though to list the series of events that would cause
such a scenario within the bounds of otherwise normal operating behavior (ie,
all machine logs were created by members of this cluster during the
I would recommend that you spend some time making sure that your guess about
the cause is correct before trying to design solutions to the problem. Can you
provide us some hard numbers, logs, and configuration information? It's always
possible that some aspect of your configuration that you
I'm trying to look at the latest diff for ZOOKEEPER-702, and every time I click
view diff on the review I get some python error.
https://reviews.apache.org/r/483/
Do we have someone that can fix this, or is it unfixable?
Thanks,
C
Hi all,
I haven't heard anything back from my questions on
https://issues.apache.org/jira/browse/ZOOKEEPER-922 in a while. We are very
keen to have this functionality here because our users really do not understand
why data sticks around for a while after their connections are killed. I'd like
I'd really love to do something with 922 if I could get some more feedback on
the design. This is a very desirable feature for our users and I should be able
to knock something out in the 3.4 timeframe.
Thanks,
Camille
-Original Message-
From: Mahadev Konar [mailto:maha...@apache.org]
Hi all,
We have created a windows native port for the C ZK client. We've done our own
testing and it all seems to work, and we'd like to contribute it back to the
community. However, porting the existing unit tests to windows has proven to be
incredibly difficult. It's not clear that we have
I would really like to see 962 fix released asap as well.
C
-Original Message-
From: Benjamin Reed [mailto:br...@yahoo-inc.com]
Sent: Tuesday, January 25, 2011 2:27 PM
To: dev@zookeeper.apache.org
Subject: 3.3.3 release
the 962 bug we fixed was pretty severe. i would like to get a
Is the code somewhere we can look at it right now?
C
-Original Message-
From: Avery Ching [mailto:ach...@yahoo-inc.com]
Sent: Tuesday, January 11, 2011 2:02 PM
To: dev@zookeeper.apache.org
Subject: Discussion - Clusterlib as a subproject for ZooKeeper
Hello,
We have been working on
Hi everyone,
A simple question with a possibly not simple answer:
For transactions that happen and are committed on the leader/in the cluster
(given a cluster with quorum already) during the time in which a new follower
is being synced (sending diffs, sync, etc), what mechanism is it that
11:22 AM, Fournier, Camille F. [Tech] wrote:
Hi everyone,
A simple question with a possibly not simple answer:
For transactions that happen and are committed on the leader/in the cluster
(given a cluster with quorum already) during the time in which a new follower
is being synced (sending
38 matches
Mail list logo
