GitHub user arankin-irl opened a pull request:
https://github.com/apache/zookeeper/pull/654
ZOOKEEPER-3160: Custom User SSLContext
The Zookeeper libraries currently allow you to set up your SSL Context via
system properties such as "zookeeper.ssl.keyStore.location&qu
Github user arankin-irl commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/654#discussion_r222028424
--- Diff: src/java/main/org/apache/zookeeper/common/X509Util.java ---
@@ -85,60 +85,73 @@ public static SSLContext createSSLContext() throws
Github user arankin-irl commented on the issue:
https://github.com/apache/zookeeper/pull/654
Merged the latest 3.5 branch in - looks like there was a significant
structure rework, along with some changes to the ZKConfig properties - moved
the additional property in with the others in
Github user arankin-irl commented on the issue:
https://github.com/apache/zookeeper/pull/654
Updated again to resolve merge conflicts.
---
Github user arankin-irl commented on the issue:
https://github.com/apache/zookeeper/pull/654
@eolivelli - looks like the Jenkins build is failing due to the audit
warnings, but I get a 404 when attempting to view the audit findings file.
---
Github user arankin-irl commented on the issue:
https://github.com/apache/zookeeper/pull/654
Thanks @nkalmar - found the [audit
problems](https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2645/artifact/patchprocess/patchReleaseAuditProblems.txt)
file and resolved the
Github user arankin-irl commented on the issue:
https://github.com/apache/zookeeper/pull/654
Addressed merge conflicts.
@nkalmar - Just wondering if there's anything else I can do to help this
get merged?
---
Github user arankin-irl commented on the issue:
https://github.com/apache/zookeeper/pull/654
Ah, I hadn't realised that 3.5 was closed for stabilisation. So I should
recreate this PR for the master branch then?
---
Github user arankin-irl commented on the issue:
https://github.com/apache/zookeeper/pull/654
That's grand then. I'll close this PR and reopen a new one for master then
ð
---
Github user arankin-irl closed the pull request at:
https://github.com/apache/zookeeper/pull/654
---
GitHub user arankin-irl opened a pull request:
https://github.com/apache/zookeeper/pull/728
ZOOKEEPER-3160: Custom User SSLContext
This is a master branch version of:
https://github.com/apache/zookeeper/pull/654
The previous PR was for branch 3.5, and couldn't be merg
Github user arankin-irl closed the pull request at:
https://github.com/apache/zookeeper/pull/728
---
GitHub user arankin-irl reopened a pull request:
https://github.com/apache/zookeeper/pull/728
ZOOKEEPER-3160: Custom User SSLContext
This is a master branch version of:
https://github.com/apache/zookeeper/pull/654
The previous PR was for branch 3.5, and couldn't be m
GitHub user arankin-irl reopened a pull request:
https://github.com/apache/zookeeper/pull/728
ZOOKEEPER-3160: Custom User SSLContext
This is a master branch version of:
https://github.com/apache/zookeeper/pull/654
The previous PR was for branch 3.5, and couldn't be m
Github user arankin-irl closed the pull request at:
https://github.com/apache/zookeeper/pull/728
---
GitHub user arankin-irl reopened a pull request:
https://github.com/apache/zookeeper/pull/728
ZOOKEEPER-3160: Custom User SSLContext
This is a master branch version of:
https://github.com/apache/zookeeper/pull/654
The previous PR was for branch 3.5, and couldn't be m
Github user arankin-irl closed the pull request at:
https://github.com/apache/zookeeper/pull/728
---
Github user arankin-irl commented on the issue:
https://github.com/apache/zookeeper/pull/728
@nkalmar - just drawing your attention to this after our discussion on
https://github.com/apache/zookeeper/pull/654
---
Github user arankin-irl commented on the issue:
https://github.com/apache/zookeeper/pull/728
> One tiny suggestion: instead of wrapping the original behaviour in an
if-else branch, I'd rather create a new class which implements your interface
ZKClientSSLContext and cal
Github user arankin-irl commented on the issue:
https://github.com/apache/zookeeper/pull/728
@anmolnar - I've updated the PR with the extracted method.
---
20 matches
Mail list logo