[GitHub] zookeeper issue #482: ZOOKEEPER-2962 - Removed Unused method.

Github user asutosh936 commented on the issue: https://github.com/apache/zookeeper/pull/482 Code Merged, closing PR. ---

[GitHub] zookeeper pull request #482: ZOOKEEPER-2962 - Removed Unused method.

Github user asutosh936 closed the pull request at: https://github.com/apache/zookeeper/pull/482 ---

[GitHub] zookeeper issue #488: ZOOKEEPER-2993 - Removed 'generated' line from .gitign...

Github user asutosh936 commented on the issue: https://github.com/apache/zookeeper/pull/488 @afine - Currently there is a folder named 'generated' at below location. https://github.com/apache/zookeeper/tree/master/src/java/main/org/apache/jute/compiler/generated As per

[GitHub] zookeeper issue #488: ZOOKEEPER-2993 - Removed 'generated' line from .gitign...

Github user asutosh936 commented on the issue: https://github.com/apache/zookeeper/pull/488 @anmolnar @afine - Thank You for the review comments. The change is to remove 'generated' keyword from .gitignore because it prevents the dir and files under generated dir to be added

[GitHub] zookeeper issue #488: ZOOKEEPER-2993 - Removed 'generated' line from .gitign...

Github user asutosh936 commented on the issue: https://github.com/apache/zookeeper/pull/488 @anmolnar - Please review ---

[GitHub] zookeeper pull request #488: ZOOKEEPER-2993 - Removed 'generated' line from ...

GitHub user asutosh936 opened a pull request: https://github.com/apache/zookeeper/pull/488 ZOOKEEPER-2993 - Removed 'generated' line from .gitignore You can merge this pull request into a Git repository by running: $ git pull https://github.com/asutosh936/zookeeper ZOOKEEPER

[GitHub] zookeeper pull request #482: ZOOKEEPER-2962 - Removed Unused method.

GitHub user asutosh936 opened a pull request: https://github.com/apache/zookeeper/pull/482 ZOOKEEPER-2962 - Removed Unused method. You can merge this pull request into a Git repository by running: $ git pull https://github.com/asutosh936/zookeeper branch-3.4 Alternatively

[GitHub] zookeeper issue #473: ZOOKEEPER-2936 - Removed duplicate code

Github user asutosh936 commented on the issue: https://github.com/apache/zookeeper/pull/473 @anmolnar - Could You or someone from Your team please merge this PR? ---

[GitHub] zookeeper issue #473: ZOOKEEPER-2936 - Removed duplicate code

Github user asutosh936 commented on the issue: https://github.com/apache/zookeeper/pull/473 @anmolnar - Thanks for the Review. The issue is about having duplicate keys for ROLLINGFILE layout and conversion pattern. The fix is to remove the duplicate keys from the file

[GitHub] zookeeper issue #473: ZOOKEEPER-2936 - Removed duplicate code

Github user asutosh936 commented on the issue: https://github.com/apache/zookeeper/pull/473 Can someone please review and merge this PR. ---

[GitHub] zookeeper pull request #473: ZOOKEEPER-2936 - Removed duplicate code

GitHub user asutosh936 opened a pull request: https://github.com/apache/zookeeper/pull/473 ZOOKEEPER-2936 - Removed duplicate code You can merge this pull request into a Git repository by running: $ git pull https://github.com/asutosh936/zookeeper master Alternatively you