[GitHub] zookeeper issue #47: Update zookeeperOver.html

2018-07-27 Thread cpoerschke
Github user cpoerschke commented on the issue: https://github.com/apache/zookeeper/pull/47 Ah, oops, @ghost is indeed a ghost! Hmm, so is it unclear then how or who this pull request could be closed by then? Except perhaps the customary "Closes #47" in a co

[GitHub] zookeeper issue #47: Update zookeeperOver.html

2018-07-27 Thread cpoerschke
Github user cpoerschke commented on the issue: https://github.com/apache/zookeeper/pull/47 @phunt looks like i don't have the necessary privileges to close this pull request. @ghost as creator of the pull request, would you have a moment perhaps to close it? thank you. ---

[GitHub] zookeeper issue #566: ZOOKEEPER-3062: mention fsync.warningthresholdms in Fi...

2018-07-27 Thread cpoerschke
Github user cpoerschke commented on the issue: https://github.com/apache/zookeeper/pull/566 Thanks everyone for your feedback! > ... are you ok with removing the extra words in the log message? Hmm, ok, done. Should I update the pull request and ht

[GitHub] zookeeper pull request #566: ZOOKEEPER-3062: mention fsync.warningthresholdm...

2018-07-11 Thread cpoerschke
GitHub user cpoerschke opened a pull request: https://github.com/apache/zookeeper/pull/566 ZOOKEEPER-3062: mention fsync.warningthresholdms in FileTxnLog LOG.warn message https://issues.apache.org/jira/browse/ZOOKEEPER-3062 You can merge this pull request into a Git repository

[GitHub] zookeeper pull request #555: ZOOKEEPER-3061: add more details to 'Unhandled ...

2018-06-29 Thread cpoerschke
GitHub user cpoerschke opened a pull request: https://github.com/apache/zookeeper/pull/555 ZOOKEEPER-3061: add more details to 'Unhandled scenario for peer' log.warn message You can merge this pull request into a Git repository by running: $ git pull https://github.com

[GitHub] zookeeper issue #350: fix comment type error.

2018-06-29 Thread cpoerschke
Github user cpoerschke commented on the issue: https://github.com/apache/zookeeper/pull/350 Hi. Just to say I've included this pull request's change(s) in my #554 pull request. ---

[GitHub] zookeeper issue #71: fix typo of comment in PathTrie

2018-06-29 Thread cpoerschke
Github user cpoerschke commented on the issue: https://github.com/apache/zookeeper/pull/71 Hi. Just to say I've included this pull request's change(s) in my #554 pull request. ---

[GitHub] zookeeper issue #54: Add space between word and number in Exception.

2018-06-29 Thread cpoerschke
Github user cpoerschke commented on the issue: https://github.com/apache/zookeeper/pull/54 Hi. Just to say I've included this pull request's change(s) in my #554 pull request. ---

[GitHub] zookeeper issue #51: fix typo of java docs in OutputArchive.java

2018-06-29 Thread cpoerschke
Github user cpoerschke commented on the issue: https://github.com/apache/zookeeper/pull/51 Hi. Just to say I've included this pull request's change(s) in my #554 pull request. ---

[GitHub] zookeeper pull request #554: ZOOKEEPER-3073: fix couple of typos

2018-06-29 Thread cpoerschke
GitHub user cpoerschke opened a pull request: https://github.com/apache/zookeeper/pull/554 ZOOKEEPER-3073: fix couple of typos You can merge this pull request into a Git repository by running: $ git pull https://github.com/cpoerschke/zookeeper master-ZOOKEEPER-3073

[GitHub] zookeeper pull request #15: Fix spelling errors

2018-06-29 Thread cpoerschke
Github user cpoerschke commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/15#discussion_r199213590 --- Diff: docs/zookeeperAdmin.html --- @@ -1943,7 +1943,7 @@ Things to Avoid Best Practices For best results, take note of the following list

[GitHub] zookeeper issue #47: Update zookeeperOver.html

2018-06-29 Thread cpoerschke
Github user cpoerschke commented on the issue: https://github.com/apache/zookeeper/pull/47 Hi. Looks like @phunt's https://github.com/apache/zookeeper/commit/c76b4e37fd76cf976ac598ac56fcb0139249f1af#diff-e9e2a1561945fe99d293423a6fee690f included equivalents of this change here and so

[GitHub] zookeeper issue #53: Small grammar changes in zookeeperOver.html

2018-06-29 Thread cpoerschke
Github user cpoerschke commented on the issue: https://github.com/apache/zookeeper/pull/53 Hi. Looks like @phunt's https://github.com/apache/zookeeper/commit/c76b4e37fd76cf976ac598ac56fcb0139249f1af#diff-e9e2a1561945fe99d293423a6fee690f included equivalents of these changes here