Github user fr0stbyte commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/427#discussion_r156860284
--- Diff: src/c/configure.ac ---
@@ -130,18 +130,66 @@ main()
else
exit(0);
}
-], AC_MSG_RESULT(yes)
- ipv6=yes
Github user fr0stbyte commented on the issue:
https://github.com/apache/zookeeper/pull/427
@phunt thanks, will keep that in mind.
---
Github user fr0stbyte commented on the issue:
https://github.com/apache/zookeeper/pull/427
@phunt @mfenes updated the initial comment of this PR. Let me know if you
need me to move it into a separate comment
---
Github user fr0stbyte commented on the issue:
https://github.com/apache/zookeeper/pull/427
@anmolnar sorry, my editor is configured to strip the trailing white spaces
. Do you need me to disable that?
---
GitHub user fr0stbyte opened a pull request:
https://github.com/apache/zookeeper/pull/427
[ZOOKEEPER-2338] - set SOCK_CLOEXEC on socket if defined
@phunt @anmolnar
PR for 3.4 branch.
You can merge this pull request into a Git repository by running:
$ git pull https
Github user fr0stbyte commented on the issue:
https://github.com/apache/zookeeper/pull/410
@phunt @anmolnar any suggestion on changes or does this look good ?
---
Github user fr0stbyte commented on the issue:
https://github.com/apache/zookeeper/pull/410
@phunt Let me know if the changes are inline with what you've had in mind.
Once we clear that, I will add the changes for 3.6
---
Github user fr0stbyte commented on the issue:
https://github.com/apache/zookeeper/pull/410
@phunt both options seem fine to me. I think would prefer the first one,
that way if the library remains ABI compatible, the clients won't need to
recompile.
---
Github user fr0stbyte commented on the issue:
https://github.com/apache/zookeeper/pull/410
@phunt I'd have no problem making in backward compatible, but I am not sure
how. Can you offer some guidance here ?
@anmolnar In the description of MESOS-4065 you can see 2 processes
Github user fr0stbyte commented on the issue:
https://github.com/apache/zookeeper/pull/410
@afine Thanks for looking at the PR
Here is the bug tracked on Mesos side :
https://issues.apache.org/jira/browse/MESOS-4065
---
GitHub user fr0stbyte opened a pull request:
https://github.com/apache/zookeeper/pull/410
[ZOOKEEPER-2338] - set SOCK_CLOEXEC on socket if defined
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/fr0stbyte/zookeeper ZOOKEEPER
Github user fr0stbyte closed the pull request at:
https://github.com/apache/zookeeper/pull/407
---
GitHub user fr0stbyte opened a pull request:
https://github.com/apache/zookeeper/pull/407
[ZOOKEEPER-2338] - set SOCK_CLOEXEC on socket if defined
This addresses the issue in
https://issues.apache.org/jira/browse/ZOOKEEPER-2338 preventing the sockets to
leak into the forked
13 matches
Mail list logo
