Github user jtuple commented on the issue:
https://github.com/apache/zookeeper/pull/580
Rebased to resolve merge conflict.
---
Github user jtuple commented on the issue:
https://github.com/apache/zookeeper/pull/580
Sorry for the delay, August was a super busy month.
I've rebased onto latest master + added basic unit tests for
`AvgMinMaxCounter` and `SimpleCounter`. I also resolved the findbugs issue
Github user jtuple commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/580#discussion_r216112301
--- Diff: src/java/main/org/apache/zookeeper/server/ServerMetrics.java ---
@@ -0,0 +1,103 @@
+/**
+ * Licensed to the Apache Software Foundation
Github user jtuple commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/580#discussion_r216049921
--- Diff: src/java/main/org/apache/zookeeper/server/ServerStats.java ---
@@ -33,17 +34,17 @@
public class ServerStats {
private static final
Github user jtuple commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/580#discussion_r216047184
--- Diff: src/java/main/org/apache/zookeeper/server/ServerStats.java ---
@@ -127,36 +129,45 @@ public String toString(){
sb.append("
Github user jtuple commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/580#discussion_r207633573
--- Diff: src/java/main/org/apache/zookeeper/server/NettyServerCnxn.java ---
@@ -271,7 +271,7 @@ private boolean checkFourLetterWord(final Channel
channel
Github user jtuple commented on the issue:
https://github.com/apache/zookeeper/pull/580
I'm happy to add tests for `AvgMinMaxCounter` and `SimpleCounter`, will go
ahead and update this PR today to include that for completeness. Since it's
easy change to make while we discuss any
GitHub user jtuple opened a pull request:
https://github.com/apache/zookeeper/pull/580
ZOOKEEPER-3098: Add additional server metrics
This patch adds several new server-side metrics as well as makes it easier
to add new metrics in the future. This patch also includes a handful
