[GitHub] zookeeper issue #490: ZOOKEEPER-3000: Use error-prone compiler

Github user leventov commented on the issue: https://github.com/apache/zookeeper/pull/490 Yes. ---

[GitHub] zookeeper issue #490: ZOOKEEPER-3000: Use error-prone compiler

Github user leventov commented on the issue: https://github.com/apache/zookeeper/pull/490 @anmolnar if you try to run `ant test` while the test are not compiled yet (i. e. they have to be compiled), and Ant uses Java 7 which is installed on your machine for compilation, yes, this is

[GitHub] zookeeper issue #490: ZOOKEEPER-3000: Use error-prone compiler

Github user leventov commented on the issue: https://github.com/apache/zookeeper/pull/490 Yes, Java 8 is required for the build, but the produced bytecode could target Java 6 or 7. Here is a citation from http://errorprone.info/docs/installation: > Our goal is to make

[GitHub] zookeeper issue #490: ZOOKEEPER-3000: Use error-prone compiler

Github user leventov commented on the issue: https://github.com/apache/zookeeper/pull/490 I didn't have time to consider your latest questions yet ---

[GitHub] zookeeper issue #490: ZOOKEEPER-3000: Use error-prone compiler

Github user leventov commented on the issue: https://github.com/apache/zookeeper/pull/490 @anmolnar see http://errorprone.info/docs/installation, the first paragraph: "Please note that Error Prone must be run on JDK 8 or newer. It can be used to build Java 6 or 7 code by settin

[GitHub] zookeeper pull request #490: ZOOKEEPER-3000: Use error-prone compiler

Github user leventov commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/490#discussion_r177043995 --- Diff: src/java/test/org/apache/zookeeper/test/AsyncHammerTest.java --- @@ -61,6 +61,7 @@ protected void restart() throws Exception

[GitHub] zookeeper pull request #490: ZOOKEEPER-3000: Use error-prone compiler

Github user leventov commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/490#discussion_r175777029 --- Diff: src/java/test/org/apache/zookeeper/test/AsyncHammerTest.java --- @@ -61,6 +61,7 @@ protected void restart() throws Exception

[GitHub] zookeeper pull request #490: ZOOKEEPER-3000: Use error-prone compiler

Github user leventov commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/490#discussion_r175569277 --- Diff: src/java/test/org/apache/zookeeper/test/AsyncHammerTest.java --- @@ -61,6 +61,7 @@ protected void restart() throws Exception

[GitHub] zookeeper pull request #490: ZOOKEEPER-3000: Use error-prone compiler

Github user leventov commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/490#discussion_r17748 --- Diff: src/java/test/org/apache/zookeeper/test/ZooKeeperTestClient.java --- @@ -71,13 +71,14 @@ private void deleteZKDir(ZooKeeper zk, String

[GitHub] zookeeper issue #490: ZOOKEEPER-3000: Use error-prone compiler

Github user leventov commented on the issue: https://github.com/apache/zookeeper/pull/490 > However we already integrated findbugs tool in our build process, don't you think it would be better to replace that instead of using two similar tools side-by-side? @anm

[GitHub] zookeeper pull request #490: ZOOKEEPER-3000: Use error-prone compiler

GitHub user leventov opened a pull request: https://github.com/apache/zookeeper/pull/490 ZOOKEEPER-3000: Use error-prone compiler Fix some bugs in tests. You can merge this pull request into a Git repository by running: $ git pull https://github.com/leventov/zookeeper error

[jira] [Created] (ZOOKEEPER-3000) Use error-prone compiler

Roman Leventov created ZOOKEEPER-3000: - Summary: Use error-prone compiler Key: ZOOKEEPER-3000 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3000 Project: ZooKeeper Issue Type