anmolnar commented on a change in pull request #898: ZOOKEEPER-3353: Admin
commands for showing initial settings
URL: https://github.com/apache/zookeeper/pull/898#discussion_r283848928
##########
File path:
zookeeper-server/src/main/java/org/apache/zookeeper/server/admin/Commands.java
##########
@@ -62,13 +64,17 @@
/** Maps command names to Command instances */
private static Map<String, Command> commands = new HashMap<String,
Command>();
private static Set<String> primaryNames = new HashSet<String>();
+ private static Set<String> commandsAvailableBeforePeerSync = new
HashSet<String>();
/**
* Registers the given command. Registered commands can be run by passing
* any of their names to runCommand.
*/
- public static void registerCommand(Command command) {
+ public static void registerCommand(Command command, boolean
enabledBeforePeerSync) {
Review comment:
nit: You can overload the constructor to avoid modifying the signature at so
many places.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
