[GitHub] [zookeeper] enixon commented on issue #863: ZOOKEEPER-3320: Leader election port stop listen when hostname unresolvable for some time

2019-03-28 Thread GitBox
enixon commented on issue #863: ZOOKEEPER-3320: Leader election port stop listen when hostname unresolvable for some time URL: https://github.com/apache/zookeeper/pull/863#issuecomment-477804567 Good find @maoling ! I don't see any discussion in ZOOKEEPER-602 about criteria for what should

[GitHub] [zookeeper] enixon commented on issue #863: ZOOKEEPER-3320: Leader election port stop listen when hostname unresolvable for some time

2019-03-27 Thread GitBox
enixon commented on issue #863: ZOOKEEPER-3320: Leader election port stop listen when hostname unresolvable for some time URL: https://github.com/apache/zookeeper/pull/863#issuecomment-477303890 Thanks for the new test. :) ---

[GitHub] [zookeeper] enixon commented on issue #863: ZOOKEEPER-3320: Leader election port stop listen when hostname unresolvable for some time

2019-03-25 Thread GitBox
enixon commented on issue #863: ZOOKEEPER-3320: Leader election port stop listen when hostname unresolvable for some time URL: https://github.com/apache/zookeeper/pull/863#issuecomment-476324387 Thanks for adding docs! I'm wary of adding an infinite loop for the same reasons that I'

[GitHub] [zookeeper] enixon commented on issue #863: ZOOKEEPER-3320: Leader election port stop listen when hostname unresolvable for some time

2019-03-22 Thread GitBox
enixon commented on issue #863: ZOOKEEPER-3320: Leader election port stop listen when hostname unresolvable for some time URL: https://github.com/apache/zookeeper/pull/863#issuecomment-475741434 Some thing is wrong with JenkinsMaven here. :(

[GitHub] [zookeeper] enixon commented on issue #863: ZOOKEEPER-3320: Leader election port stop listen when hostname unresolvable for some time

2019-03-22 Thread GitBox
enixon commented on issue #863: ZOOKEEPER-3320: Leader election port stop listen when hostname unresolvable for some time URL: https://github.com/apache/zookeeper/pull/863#issuecomment-475707431 LGTM! The test failure (NonRecoverableErrorTest::testZooKeeperServiceAvailableOnLeader) looks