[GitHub] [zookeeper] enixon commented on issue #895: ZOOKEEPER-3349: QuorumCnxManager socketTimeout unused

2019-05-20 Thread GitBox
enixon commented on issue #895: ZOOKEEPER-3349: QuorumCnxManager socketTimeout unused URL: https://github.com/apache/zookeeper/pull/895#issuecomment-494180419 Closing as obviated by #932. I'll close the backing ticket as well.

[GitHub] [zookeeper] enixon commented on issue #895: ZOOKEEPER-3349: QuorumCnxManager socketTimeout unused

2019-05-07 Thread GitBox
enixon commented on issue #895: ZOOKEEPER-3349: QuorumCnxManager socketTimeout unused URL: https://github.com/apache/zookeeper/pull/895#issuecomment-490261605 This change could be obviated by #932 , if that pr is accepted then this one should be closed.

[GitHub] [zookeeper] enixon commented on issue #895: ZOOKEEPER-3349: QuorumCnxManager socketTimeout unused

2019-05-06 Thread GitBox
enixon commented on issue #895: ZOOKEEPER-3349: QuorumCnxManager socketTimeout unused URL: https://github.com/apache/zookeeper/pull/895#issuecomment-489711179 @lvfangmin I considered that as an option but, since the sync limit can be changed by jmx, I think it's better for the

[GitHub] [zookeeper] enixon commented on issue #895: ZOOKEEPER-3349: QuorumCnxManager socketTimeout unused

2019-05-02 Thread GitBox
enixon commented on issue #895: ZOOKEEPER-3349: QuorumCnxManager socketTimeout unused URL: https://github.com/apache/zookeeper/pull/895#issuecomment-488853062 Any objections to merging code clean-up? This is an automated

[GitHub] [zookeeper] enixon commented on issue #895: ZOOKEEPER-3349: QuorumCnxManager socketTimeout unused

2019-04-07 Thread GitBox
enixon commented on issue #895: ZOOKEEPER-3349: QuorumCnxManager socketTimeout unused URL: https://github.com/apache/zookeeper/pull/895#issuecomment-480651858 Tests pass locally and the code being removed is unconnected to anything functional. I'm going to close/reopen to see if that

[GitHub] [zookeeper] enixon commented on issue #895: ZOOKEEPER-3349: QuorumCnxManager socketTimeout unused

2019-04-05 Thread GitBox
enixon commented on issue #895: ZOOKEEPER-3349: QuorumCnxManager socketTimeout unused URL: https://github.com/apache/zookeeper/pull/895#issuecomment-480394809 retest ant build This is an automated message from the Apache Git