eolivelli commented on issue #918: ZOOKEEPER-3366: Pluggable metrics system for
ZooKeeper - move remaining metrics to MetricsProvider
URL: https://github.com/apache/zookeeper/pull/918#issuecomment-486420283
@enixon @lvfangmin @anmolnar this is the last patch for the migration of
metrics to
eolivelli commented on issue #918: ZOOKEEPER-3366: Pluggable metrics system for
ZooKeeper - move remaining metrics to MetricsProvider
URL: https://github.com/apache/zookeeper/pull/918#issuecomment-487198257
There are failing tests (ObserverMasterTest and CommandsTest.
I am digging into,
eolivelli commented on issue #918: ZOOKEEPER-3366: Pluggable metrics system for
ZooKeeper - move remaining metrics to MetricsProvider
URL: https://github.com/apache/zookeeper/pull/918#issuecomment-487324879
@enixon I have reworked the test about 'synced_observers' in order to make
it work.
eolivelli commented on issue #918: ZOOKEEPER-3366: Pluggable metrics system for
ZooKeeper - move remaining metrics to MetricsProvider
URL: https://github.com/apache/zookeeper/pull/918#issuecomment-489309614
@lvfangmin can you also take a look and possibly merge this patch ?
your collegue
eolivelli commented on issue #918: ZOOKEEPER-3366: Pluggable metrics system for
ZooKeeper - move remaining metrics to MetricsProvider
URL: https://github.com/apache/zookeeper/pull/918#issuecomment-491241680
@anmolnar build is green now for this patch.
I know @lvfangmin is already taking
eolivelli commented on issue #918: ZOOKEEPER-3366: Pluggable metrics system for
ZooKeeper - move remaining metrics to MetricsProvider
URL: https://github.com/apache/zookeeper/pull/918#issuecomment-491546030
@lvfangmin I have introduced "unregisterGauge" (it looks better, thanks for
the sug
eolivelli commented on issue #918: ZOOKEEPER-3366: Pluggable metrics system for
ZooKeeper - move remaining metrics to MetricsProvider
URL: https://github.com/apache/zookeeper/pull/918#issuecomment-493170070
@lvfangmin do you have time to finish your review?
Thanks
--
eolivelli commented on issue #918: ZOOKEEPER-3366: Pluggable metrics system for
ZooKeeper - move remaining metrics to MetricsProvider
URL: https://github.com/apache/zookeeper/pull/918#issuecomment-494956812
Gently pinging @lvfangmin
-
eolivelli commented on issue #918: ZOOKEEPER-3366: Pluggable metrics system for
ZooKeeper - move remaining metrics to MetricsProvider
URL: https://github.com/apache/zookeeper/pull/918#issuecomment-495332110
retest maven build
eolivelli commented on issue #918: ZOOKEEPER-3366: Pluggable metrics system for
ZooKeeper - move remaining metrics to MetricsProvider
URL: https://github.com/apache/zookeeper/pull/918#issuecomment-495332236
@anmolnar I will rebase this patch now.
---
eolivelli commented on issue #918: ZOOKEEPER-3366: Pluggable metrics system for
ZooKeeper - move remaining metrics to MetricsProvider
URL: https://github.com/apache/zookeeper/pull/918#issuecomment-495335839
@lvfangmin rebased to latest master.
I hope to be able to commit this patch soon,
eolivelli commented on issue #918: ZOOKEEPER-3366: Pluggable metrics system for
ZooKeeper - move remaining metrics to MetricsProvider
URL: https://github.com/apache/zookeeper/pull/918#issuecomment-495989214
retest ant build
T
eolivelli commented on issue #918: ZOOKEEPER-3366: Pluggable metrics system for
ZooKeeper - move remaining metrics to MetricsProvider
URL: https://github.com/apache/zookeeper/pull/918#issuecomment-496008413
retest ant build
T
eolivelli commented on issue #918: ZOOKEEPER-3366: Pluggable metrics system for
ZooKeeper - move remaining metrics to MetricsProvider
URL: https://github.com/apache/zookeeper/pull/918#issuecomment-496014349
retest ant build
T
eolivelli commented on issue #918: ZOOKEEPER-3366: Pluggable metrics system for
ZooKeeper - move remaining metrics to MetricsProvider
URL: https://github.com/apache/zookeeper/pull/918#issuecomment-496307959
@lvfangmin please help me move forward this patch :-)
cc @anmolnar @nkalmar
15 matches
Mail list logo