anmolnar commented on a change in pull request #742: ZOOKEEPER-3223: Configure
Spotbugs
URL: https://github.com/apache/zookeeper/pull/742#discussion_r245008359
##
File path: zookeeper-server/src/main/java/org/apache/zookeeper/ClientCnxn.java
##
@@ -18,6 +18,7 @@
package
anmolnar commented on a change in pull request #742: ZOOKEEPER-3223: Configure
Spotbugs
URL: https://github.com/apache/zookeeper/pull/742#discussion_r245004005
##
File path: excludeFindBugsFilter.xml
##
@@ -0,0 +1,14 @@
+
+
+
Review comment:
Leave it, I'm fine with t
anmolnar commented on a change in pull request #742: ZOOKEEPER-3223: Configure
Spotbugs
URL: https://github.com/apache/zookeeper/pull/742#discussion_r244963646
##
File path:
zookeeper-server/src/main/java/org/apache/zookeeper/server/persistence/FileTxnLog.java
##
@@ -180,
anmolnar commented on a change in pull request #742: ZOOKEEPER-3223: Configure
Spotbugs
URL: https://github.com/apache/zookeeper/pull/742#discussion_r244962944
##
File path: excludeFindBugsFilter.xml
##
@@ -0,0 +1,14 @@
+
+
+
Review comment:
Naming is a little bit co
anmolnar commented on a change in pull request #742: ZOOKEEPER-3223: Configure
Spotbugs
URL: https://github.com/apache/zookeeper/pull/742#discussion_r244963490
##
File path:
zookeeper-server/src/main/java/org/apache/zookeeper/server/EphemeralType.java
##
@@ -212,7 +212,8
anmolnar commented on a change in pull request #742: ZOOKEEPER-3223: Configure
Spotbugs
URL: https://github.com/apache/zookeeper/pull/742#discussion_r244963240
##
File path: zookeeper-server/src/main/java/org/apache/zookeeper/ClientCnxn.java
##
@@ -18,6 +18,7 @@
package
