[GitHub] ivmaykov commented on issue #809: ZOOKEEPER-3272: Clean up netty4 code per Norman Maurer's review comments

2019-02-11 Thread GitBox
ivmaykov commented on issue #809: ZOOKEEPER-3272: Clean up netty4 code per Norman Maurer's review comments URL: https://github.com/apache/zookeeper/pull/809#issuecomment-462546183 Flaky test failure is unrelated ... can we just merge this? --

[GitHub] ivmaykov commented on issue #809: ZOOKEEPER-3272: Clean up netty4 code per Norman Maurer's review comments

2019-02-07 Thread GitBox
ivmaykov commented on issue #809: ZOOKEEPER-3272: Clean up netty4 code per Norman Maurer's review comments URL: https://github.com/apache/zookeeper/pull/809#issuecomment-461590368 @anmolnar I'm not sure why Jenkins is failing. Can you help debug? ---

[GitHub] ivmaykov commented on issue #809: ZOOKEEPER-3272: Clean up netty4 code per Norman Maurer's review comments

2019-02-07 Thread GitBox
ivmaykov commented on issue #809: ZOOKEEPER-3272: Clean up netty4 code per Norman Maurer's review comments URL: https://github.com/apache/zookeeper/pull/809#issuecomment-461572787 Closing / reopening to trigger re-test. This

[GitHub] ivmaykov commented on issue #809: ZOOKEEPER-3272: Clean up netty4 code per Norman Maurer's review comments

2019-02-06 Thread GitBox
ivmaykov commented on issue #809: ZOOKEEPER-3272: Clean up netty4 code per Norman Maurer's review comments URL: https://github.com/apache/zookeeper/pull/809#issuecomment-461224526 @anmolnar @normanmaurer please take a look Th