Github user hanm commented on the issue:
https://github.com/apache/zookeeper/pull/122
Please also update the reconfig documentation about deprecating old API and
about the new API in ZooKeeperAdmin:
https://github.com/apache/zookeeper/blob/master/src/docs/src/documentation/content
Github user fpj commented on the issue:
https://github.com/apache/zookeeper/pull/122
Just so that I understand, when are we going to be removing this methods,
in trunk? I'm asking this for two reasons:
1. So that users know in which version these methods are going away
2.
Github user hanm commented on the issue:
https://github.com/apache/zookeeper/pull/122
>> when are we going to be removing these deprecated methods, in trunk
Maybe when we get a stable release of 3.5?
>> it sounds like we don't need to bring back the old reconfig method
Github user hanm commented on the issue:
https://github.com/apache/zookeeper/pull/122
I think this patch is ready to land... @fpj What do you think?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user fpj commented on the issue:
https://github.com/apache/zookeeper/pull/122
@Randgalt
>> when are we going to be removing these deprecated methods, in trunk
> Maybe when we get a stable release of 3.5?
Are you OK with us removing the deprecated methods when 3.
Github user Randgalt commented on the issue:
https://github.com/apache/zookeeper/pull/122
> Are you OK with us removing the deprecated methods when 3.5 becomes GA?
No. I'd vote against that. Breaking changes should be in a 3.6 version.
That was the genesis of this issue to begin wi
Github user hanm commented on the issue:
https://github.com/apache/zookeeper/pull/122
>> Breaking changes should be in a 3.6 version.
Sounds OK to me.
>> We need to either create a new issue or have a different pull request
for 3.5 under this same issue
I thi
Github user fpj commented on the issue:
https://github.com/apache/zookeeper/pull/122
@hanm @Randgalt sounds like a plan, let's follow the steps that Michael
lined up above.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user Randgalt commented on the issue:
https://github.com/apache/zookeeper/pull/122
Will do
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user Randgalt commented on the issue:
https://github.com/apache/zookeeper/pull/122
See #151
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if th
Github user Randgalt commented on the issue:
https://github.com/apache/zookeeper/pull/122
Do we need a separate issue for the 3.6 change?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user hanm commented on the issue:
https://github.com/apache/zookeeper/pull/122
>> Do we need a separate issue for the 3.6 change?
No we don't (what @fpj prefers wrapping both PR in one shot under
ZOOKEEPER-2642).
@Randgalt Do you mind update the current PR
(h
Github user Randgalt commented on the issue:
https://github.com/apache/zookeeper/pull/122
OK - to be clear, I have PR #151 which applies the legacy API to
branch-3.5. Then, I'll rework _this_ PR (against master) to only have the Admin
API, right?
---
If your project is set up for it
Github user hanm commented on the issue:
https://github.com/apache/zookeeper/pull/122
@Randgalt Exactly. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishe
Github user hanm commented on the issue:
https://github.com/apache/zookeeper/pull/122
Just to close the loop here:
The PR for master branch is now:
https://github.com/apache/zookeeper/pull/152
The PR for branch-3.5 is now: https://github.com/apache/zookeeper/pull/151
---
15 matches
Mail list logo
