Github user hanm commented on the issue:
https://github.com/apache/zookeeper/pull/173
PR merged, please close this @JiangJiafu
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user hanm commented on the issue:
https://github.com/apache/zookeeper/pull/173
Thanks for updates, @JiangJiafu. Patch looks good to me, will merge soon.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user JiangJiafu commented on the issue:
https://github.com/apache/zookeeper/pull/173
Please have a look to the new code, thank you.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user JiangJiafu commented on the issue:
https://github.com/apache/zookeeper/pull/173
@hanm I have changed the document, please review the code and document,
thank you.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user hanm commented on the issue:
https://github.com/apache/zookeeper/pull/173
I'll review later, but a quick answer to your question on how to update
doc: no don't modify the html directly. Instead only modify the source of the
docs. The sources are in folder
Github user JiangJiafu commented on the issue:
https://github.com/apache/zookeeper/pull/173
@hanm Hi, I have modified the code according to your advices except the
second one:
"Documentation (see Abe's comment)"
---
If your project is set up for it, you can reply to this email
Github user JiangJiafu commented on the issue:
https://github.com/apache/zookeeper/pull/173
Eh, sorry for asking this question, but how to update the documentation?
Should I modify the html files in docs directory?
---
If your project is set up for it, you can reply to this email
Github user hanm commented on the issue:
https://github.com/apache/zookeeper/pull/173
@JiangJiafu Apologize for lagging on code review. I think this patch still
needs a little bit work to get it merged:
* Provide a way to use old address creation function by checking the sys
Github user JiangJiafu commented on the issue:
https://github.com/apache/zookeeper/pull/173
@hanm Hi, May I ask when will this problem be fixed? And will it be fixed
on 3.4.X(stable) version? Thanks.
---
If your project is set up for it, you can reply to this email and have your
Github user eribeiro commented on the issue:
https://github.com/apache/zookeeper/pull/173
@JiangJiafu @rakeshadr @hanm @fpj Guys, does my considerations on this
comment https://github.com/apache/zookeeper/pull/173#discussion_r101845264 make
any sense? Probably it's just me being
Github user eribeiro commented on the issue:
https://github.com/apache/zookeeper/pull/173
@jiangjiafu glad to help. :) Thanks for driving this change. Great work.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user rakeshadr commented on the issue:
https://github.com/apache/zookeeper/pull/173
I'm really sorry, I didn't get much time on this work. I could see very
good discussions about this and I'm thinking you all are reaching to a pretty
good solution. My previous comment was to
Github user JiangJiafu commented on the issue:
https://github.com/apache/zookeeper/pull/173
@rakeshadr Thank you for your respond.
If you have decided how to fix this problem, please let me know.
---
If your project is set up for it, you can reply to this email and have your
Github user rakeshadr commented on the issue:
https://github.com/apache/zookeeper/pull/173
Thanks a lot @JiangJiafu for the effort in driving this.
I'm not sure whether this is a blocker for 3.4.10 release. Is it good if
we just release 3.4.10 without this and make it a
Github user JiangJiafu commented on the issue:
https://github.com/apache/zookeeper/pull/173
@hanm Yes, I hope this PR can be solved in 3.4.10~ Since 3.5.X is still in
alpha state now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user JiangJiafu commented on the issue:
https://github.com/apache/zookeeper/pull/173
@eribeiro Thank you for your review.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user hanm commented on the issue:
https://github.com/apache/zookeeper/pull/173
@JiangJiafu What I meant is we can solve the problem (sharing code between
this issue and ZOOKEEPER-2181) later, after both issues are merged in. We can
make things progress by doing one step at a
Github user JiangJiafu commented on the issue:
https://github.com/apache/zookeeper/pull/173
Hi, @hanm , do you mean that you will merge ZOOKEEPER-2691 and
ZOOKEEPER-2184 to solve the problem later? If so, may I ask will the problem be
solved in version zokkeper 3.4.10?
---
If your
Github user afine commented on the issue:
https://github.com/apache/zookeeper/pull/173
nit: would this change be worth documenting?
Otherwise, +1.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user afine commented on the issue:
https://github.com/apache/zookeeper/pull/173
sure, one is on the client and one is on the server but I do not think that
means the problem is inherently different.
I think it would be fair to say that both pr's revolve around what to
Github user hanm commented on the issue:
https://github.com/apache/zookeeper/pull/173
>> on the surface this pr reminds me of ZOOKEEPER-2184, wondering if some
of the logic can be shared?
I had a chat with @afine offline again about this and I think Abe had a
good point of
Github user hanm commented on the issue:
https://github.com/apache/zookeeper/pull/173
Thanks for updates, @JiangJiafu.
Patch looks good, and I agree that this patch is solving a different
problem than ZOOKEEPER-2184. I'll give a few more days in case anyone has
addition
Github user afine commented on the issue:
https://github.com/apache/zookeeper/pull/173
on the surface this pr reminds me of ZOOKEEPER-2184, wondering if some of
the logic can be shared? we seem to be solving the same problem of dns
resolutions not giving the "best" answers in more
Github user JiangJiafu commented on the issue:
https://github.com/apache/zookeeper/pull/173
I have modified the source code according to your advise, please review the
code. @hanm
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
24 matches
Mail list logo
