Github user rakeshadr commented on the issue:
https://github.com/apache/zookeeper/pull/239
Merged, please close the PR, @afine
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user rakeshadr commented on the issue:
https://github.com/apache/zookeeper/pull/239
Thanks @afine for the updates.
+1, changes looks pretty good. I will merge this shortly.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user afine commented on the issue:
https://github.com/apache/zookeeper/pull/239
@rakeshadr this should be rebased and ready to be merged.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user rakeshadr commented on the issue:
https://github.com/apache/zookeeper/pull/239
+1 LGTM.
@afine, could you please rebase the patch on latest branch-3.4 code, there
are few conflicts due to `ZOOKEEPER-2732` commits.
---
If your project is set up for it, you can
Github user afine commented on the issue:
https://github.com/apache/zookeeper/pull/239
Done, thanks for the review @rakeshadr
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature