Github user arshadmohammad commented on the issue:
https://github.com/apache/zookeeper/pull/254
This PR can be merged to master and branch-3.5 only. I will raise another
pull request for branch-3.4
---
If your project is set up for it, you can reply to this email and have your
reply
Github user rakeshrapache commented on the issue:
https://github.com/apache/zookeeper/pull/254
>> SASL login will never succeed
Yes, agreed. You guys are correct. I got confused with the server behavior
of continue connection to Zookeeper server without SASL auth. I was thinki
Github user hanm commented on the issue:
https://github.com/apache/zookeeper/pull/254
>> Will this results in any consistency issues later?
I guess the previous behavior was problematic and the fact
tunnelAuthInProgress always return false once a login failed (even after a new
Github user hanm commented on the issue:
https://github.com/apache/zookeeper/pull/254
lgtm.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the featu
Github user hanm commented on the issue:
https://github.com/apache/zookeeper/pull/254
>> So I think we can not do above change.
Correct - I was looking to consolidate unnecessary variables used to encode
states but looks like we do need saslLoginFailed.
lgtm just with
Github user arshadmohammad commented on the issue:
https://github.com/apache/zookeeper/pull/254
Thanks @afine @hanm for the reviews. Addressed the comments, Please have a
look.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as w
Github user arshadmohammad commented on the issue:
https://github.com/apache/zookeeper/pull/254
zooKeeperSaslClient == null is already used in tunnelAuthInProgress()
which is quite different from saslLoginFailed being false. So I think we can
not do above change.
---
If your projec
Github user hanm commented on the issue:
https://github.com/apache/zookeeper/pull/254
How about removing saslLoginFailed and use zooKeeperSaslClient to track the
state of sasl login? The invariant would be:
* sasl login failed: zooKeeperSaslClient == null
* sasl login succeeded
