Github user andschwa commented on the issue:
https://github.com/apache/zookeeper/pull/311
Thank you!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user hanm commented on the issue:
https://github.com/apache/zookeeper/pull/311
Committed to 3.5. Thanks for the work, and please close the pull request.
@andschwa
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user hanm commented on the issue:
https://github.com/apache/zookeeper/pull/311
LGTM. The failing precommit test is not relevant to this patch and should
already be fixed by commit 837b37636201ee9aca4cbbb962d18a7883e14c1b.
---
If your project is set up for it, you can reply
Github user andschwa commented on the issue:
https://github.com/apache/zookeeper/pull/311
`branch-3.5` has ZOOKEEPER-1643, so this patch should just be good to go.
It was integration tested.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user andschwa commented on the issue:
https://github.com/apache/zookeeper/pull/311
@hanm oh.. good to know! Okay I'll give it another whack, thanks :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user hanm commented on the issue:
https://github.com/apache/zookeeper/pull/311
@andschwa branch-3.4 is the stable branch that we actually ship - I assume
your use case (Mesos on windows?) will integrate with that version as well.
---
If your project is set up for it, you can
Github user andschwa commented on the issue:
https://github.com/apache/zookeeper/pull/311
Hm... it might not backport so easily to `branch-3.4`. Let me know how
badly it's wanted.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user andschwa commented on the issue:
https://github.com/apache/zookeeper/pull/311
@hanm this backports #306 to `branch-3.5`. I rebuilt and retested, all
looks good. Since original branch came from `master` the version was already
what I believe to be correct at `3.5.3`.
---
