Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/353
@breed sure, go ahead please
---
Github user breed commented on the issue:
https://github.com/apache/zookeeper/pull/353
ok, with two +1s i'll be committing this one.
---
Github user hanm commented on the issue:
https://github.com/apache/zookeeper/pull/353
@breed it's ok to vote here and the comments are bridged over to JIRA. In
this case, check https://issues.apache.org/jira/browse/ZOOKEEPER-2886. Note you
need to select the "Work Log" tab instead of
Github user breed commented on the issue:
https://github.com/apache/zookeeper/pull/353
quick question, is it ok that the voting happens here rather than the jira?
i thought comments would be bridged over, but that doesn't seem to be
happening...
---
Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/353
@phunt Would you like to take a quick look?
You worked on the patch for ZOOKEEPER-710.
---
Github user breed commented on the issue:
https://github.com/apache/zookeeper/pull/353
+1
thanx @lvfangmin ! this looks good to me. are you okay with this @anmolnar ?
---
Github user lvfangmin commented on the issue:
https://github.com/apache/zookeeper/pull/353
@anmolnar thanks for reviewing, the testNoLogBeforeLeaderEstablishment was
introduced by mistake during rebase, and for the confusion. I've fixed the
other test to catch the issue I'm trying to
