[GitHub] zookeeper issue #409: ZOOKEEPER-2924: Refactor tests of LoadFromLogTest.java

2017-12-12 Thread phunt
Github user phunt commented on the issue: https://github.com/apache/zookeeper/pull/409 +1 thanks Andor. I committed this to branch-3.4 - you'll need to close this PR manually. ---

[GitHub] zookeeper issue #409: ZOOKEEPER-2924: Refactor tests of LoadFromLogTest.java

2017-12-11 Thread anmolnar
Github user anmolnar commented on the issue: https://github.com/apache/zookeeper/pull/409 @phunt Build is green now. Please review & commit if you have a chance. ---

[GitHub] zookeeper issue #409: ZOOKEEPER-2924: Refactor tests of LoadFromLogTest.java

2017-12-08 Thread anmolnar
Github user anmolnar commented on the issue: https://github.com/apache/zookeeper/pull/409 @phunt Patch has been updated with the trunk review changes. Please take a look. ---

[GitHub] zookeeper issue #409: ZOOKEEPER-2924: Refactor tests of LoadFromLogTest.java

2017-12-07 Thread anmolnar
Github user anmolnar commented on the issue: https://github.com/apache/zookeeper/pull/409 @phunt Yes, I'm working on it. ---

[GitHub] zookeeper issue #409: ZOOKEEPER-2924: Refactor tests of LoadFromLogTest.java

2017-12-06 Thread phunt
Github user phunt commented on the issue: https://github.com/apache/zookeeper/pull/409 @anmolnar does this need to be updated to reflect the changes in #420 ? (looks that way to me...) ---

[GitHub] zookeeper issue #409: ZOOKEEPER-2924: Refactor tests of LoadFromLogTest.java

2017-11-27 Thread phunt
Github user phunt commented on the issue: https://github.com/apache/zookeeper/pull/409 Same comments as in #420 ---

[GitHub] zookeeper issue #409: ZOOKEEPER-2924: Refactor tests of LoadFromLogTest.java

2017-11-08 Thread anmolnar
Github user anmolnar commented on the issue: https://github.com/apache/zookeeper/pull/409 @phunt Do you think we can merge this now into branch-3.4? ---

[GitHub] zookeeper issue #409: ZOOKEEPER-2924: Refactor tests of LoadFromLogTest.java

2017-11-01 Thread anmolnar
Github user anmolnar commented on the issue: https://github.com/apache/zookeeper/pull/409 @phunt would you please kindly commit this patch? ---

[GitHub] zookeeper issue #409: ZOOKEEPER-2924: Refactor tests of LoadFromLogTest.java

2017-10-30 Thread anmolnar
Github user anmolnar commented on the issue: https://github.com/apache/zookeeper/pull/409 Thanks @afine . I've updated the PR. ---