[GitHub] zookeeper issue #473: ZOOKEEPER-2936 - Removed duplicate code

2018-03-02 Thread afine
Github user afine commented on the issue: https://github.com/apache/zookeeper/pull/473 Thanks @asutosh936! ---

[GitHub] zookeeper issue #473: ZOOKEEPER-2936 - Removed duplicate code

2018-03-01 Thread anmolnar
Github user anmolnar commented on the issue: https://github.com/apache/zookeeper/pull/473 @afine please take a look, I think this is ready to commit. thanks. ---

[GitHub] zookeeper issue #473: ZOOKEEPER-2936 - Removed duplicate code

2018-03-01 Thread asutosh936
Github user asutosh936 commented on the issue: https://github.com/apache/zookeeper/pull/473 @anmolnar - Could You or someone from Your team please merge this PR? ---

[GitHub] zookeeper issue #473: ZOOKEEPER-2936 - Removed duplicate code

2018-02-28 Thread asutosh936
Github user asutosh936 commented on the issue: https://github.com/apache/zookeeper/pull/473 @anmolnar - Thanks for the Review. The issue is about having duplicate keys for ROLLINGFILE layout and conversion pattern. The fix is to remove the duplicate keys from the file. As rig

[GitHub] zookeeper issue #473: ZOOKEEPER-2936 - Removed duplicate code

2018-02-27 Thread asutosh936
Github user asutosh936 commented on the issue: https://github.com/apache/zookeeper/pull/473 Can someone please review and merge this PR. ---