[GitHub] zookeeper issue #475: Fixed PurgeTxnLog params order in the zkCleanup.sh

2018-03-05 Thread hamsterready
Github user hamsterready commented on the issue: https://github.com/apache/zookeeper/pull/475 Closing this one. Thank you for letting me know. Cheers ---

[GitHub] zookeeper issue #475: Fixed PurgeTxnLog params order in the zkCleanup.sh

2018-03-05 Thread hamsterready
Github user hamsterready commented on the issue: https://github.com/apache/zookeeper/pull/475 Makes sense. Thank you for this. ---

[GitHub] zookeeper issue #475: Fixed PurgeTxnLog params order in the zkCleanup.sh

2018-03-01 Thread anmolnar
Github user anmolnar commented on the issue: https://github.com/apache/zookeeper/pull/475 I know what the problem is. 3.4.11 has a bug that swaps dataDir and dataLogDir from config file. Sorry, it's only mentioned briefly on the release page:

[GitHub] zookeeper issue #475: Fixed PurgeTxnLog params order in the zkCleanup.sh

2018-03-01 Thread anmolnar
Github user anmolnar commented on the issue: https://github.com/apache/zookeeper/pull/475 How does your ZooKeeper config file look like? ---

[GitHub] zookeeper issue #475: Fixed PurgeTxnLog params order in the zkCleanup.sh

2018-03-01 Thread hamsterready
Github user hamsterready commented on the issue: https://github.com/apache/zookeeper/pull/475 See report here: https://github.com/31z4/zookeeper-docker/issues/30 Original version: ``` bash-4.4# ./bin/zkCleanup.sh Usage: PurgeTxnLog dataLogDir [snapDir] -n

[GitHub] zookeeper issue #475: Fixed PurgeTxnLog params order in the zkCleanup.sh

2018-03-01 Thread anmolnar
Github user anmolnar commented on the issue: https://github.com/apache/zookeeper/pull/475 I had a look at the code and it seems to me that previous ordering of parameters was right. `FileTxnSnapLog` class is instantiated from `PurgeTxnLog` by parsing the 0. cli arg to

[GitHub] zookeeper issue #475: Fixed PurgeTxnLog params order in the zkCleanup.sh

2018-02-28 Thread hamsterready
Github user hamsterready commented on the issue: https://github.com/apache/zookeeper/pull/475 https://issues.apache.org/jira/browse/ZOOKEEPER-2987 ---

[GitHub] zookeeper issue #475: Fixed PurgeTxnLog params order in the zkCleanup.sh

2018-02-28 Thread hamsterready
Github user hamsterready commented on the issue: https://github.com/apache/zookeeper/pull/475 Hehe... and I was wondering how do you handle github/jira issues ... now got an answer. ---

[GitHub] zookeeper issue #475: Fixed PurgeTxnLog params order in the zkCleanup.sh

2018-02-28 Thread anmolnar
Github user anmolnar commented on the issue: https://github.com/apache/zookeeper/pull/475 @hamsterready Thanks for the contribution. Would you please kindly create a jira for this? I'll take a look at it soon. ---