Github user andschwa commented on the issue:
https://github.com/apache/zookeeper/pull/486
@phunt This replaces #386.
---
Github user andschwa commented on the issue:
https://github.com/apache/zookeeper/pull/486
@proller I cherry-picked and kept your authorship ð
---
Github user andschwa commented on the issue:
https://github.com/apache/zookeeper/pull/486
[JIRA: ZOOKEEPER-2999](https://issues.apache.org/jira/browse/ZOOKEEPER-2999)
---
Github user andschwa commented on the issue:
https://github.com/apache/zookeeper/pull/486
CI failures look spurious...
---
Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/486
@andschwa try to trigger another build with amend commit
Those are probably just flaky tests.
---
Github user andschwa commented on the issue:
https://github.com/apache/zookeeper/pull/486
@anmolnar Here goes...
---
Github user andschwa commented on the issue:
https://github.com/apache/zookeeper/pull/486
FWIW I was able to build and run tests using CMake just fine. That said,
this was failing
```
1: Zookeeper_simpleSystem::testAsyncWatcherAutoResetterminate called after
throwing an i
Github user andschwa commented on the issue:
https://github.com/apache/zookeeper/pull/486
@anmolnar So here's what failed on Jenkins, but it makes no sense because
Jenkins doesn't even use CMake. It can't be related:
```
[exec] [exec]
/home/jenkins/jenkins-slave
Github user andschwa commented on the issue:
https://github.com/apache/zookeeper/pull/486
@anmolnar Same here. The changes made in this PR are not executed in the
Jenkins build; but the tests are quite flaky.
---
Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/486
@andschwa I always get confused with these cpp unit tests. They're flaky
for sure, but can't really tell why.
I tested your changes and was able to build the client successfully with
CMa
Github user andschwa commented on the issue:
https://github.com/apache/zookeeper/pull/486
@anmolnar Yay! Flaky tests passed CI.
---
Github user andschwa commented on the issue:
https://github.com/apache/zookeeper/pull/486
Thanks @hanm!
---
12 matches
Mail list logo
