[GitHub] zookeeper issue #508: ZOOKEEPER-2994 Tool required to recover log and snapsh...

2018-04-25 Thread phunt
Github user phunt commented on the issue: https://github.com/apache/zookeeper/pull/508 @anmolnar you will have to close this manually as it's not master branch. ---

[GitHub] zookeeper issue #508: ZOOKEEPER-2994 Tool required to recover log and snapsh...

2018-04-25 Thread phunt
Github user phunt commented on the issue: https://github.com/apache/zookeeper/pull/508 +1. Great. Thanks @anmolnar . I've committed for 3.4.13. ---

[GitHub] zookeeper issue #508: ZOOKEEPER-2994 Tool required to recover log and snapsh...

2018-04-25 Thread anmolnar
Github user anmolnar commented on the issue: https://github.com/apache/zookeeper/pull/508 @phunt Done. Now it's using a custom parser and no additional dependency requirement. ---

[GitHub] zookeeper issue #508: ZOOKEEPER-2994 Tool required to recover log and snapsh...

2018-04-25 Thread anmolnar
Github user anmolnar commented on the issue: https://github.com/apache/zookeeper/pull/508 I will rather remove the dependency and change the implementation to behave similarly without it, so that we can merge this safely. ---

[GitHub] zookeeper issue #508: ZOOKEEPER-2994 Tool required to recover log and snapsh...

2018-04-24 Thread phunt
Github user phunt commented on the issue: https://github.com/apache/zookeeper/pull/508 tbh would rather not. Given it's available here as a patch for anyone that needs it why don't we just include it in 3.5+ . Anyone that wants it can apply themselves and use it using what you've prov