Github user enixon commented on the issue:
https://github.com/apache/zookeeper/pull/545
lgtm :)
---
Github user hanm commented on the issue:
https://github.com/apache/zookeeper/pull/545
thanks @anmolnar , merged to master.
---
Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/545
@hanm One more addition: I extended the output of cons command to display
non-secure and secure connections separately. I think the interface is more
obvious this way.
---
Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/545
@hanm Done.
---
Github user hanm commented on the issue:
https://github.com/apache/zookeeper/pull/545
I suggest we move test refactoring part of this patch to a separate JIRA /
PR. My main concern is mix these will create confusions for those who check the
commit history of this patch and wondering w
Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/545
@hanm @enixon Back to the roots: created separate getter for the secure
server cnxn factory and fixed the logic of Cons command handler.
Additionally some unit test refactor (move FileTxn
Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/545
Oops! Nice catch @enixon , thanks for the heads-up. Maybe we've gone too
far with this patch. Thanks for the heads-up!
---
Github user enixon commented on the issue:
https://github.com/apache/zookeeper/pull/545
@anmolnar quick question - my understanding of secure client connections
is that the QuorumPeer maintains two ports simultaneously so that clients can
be slowly migrated from one to the other. Thi
Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/545
@hanm If you approve the change, please commit it. I don't want to commit
my PR. Thanks!
---
Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/545
@hanm @breed Would you please take a look at my recent commits?
Still having concerns?
---
Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/545
No worries, let's go down this road, I think we're on the right track and
this is good refactoring. I'll make the necessary changes today.
---
Github user hanm commented on the issue:
https://github.com/apache/zookeeper/pull/545
>> We could keep the original API and setting the secure field appropriate
to stay on the safe side, but that won't satisfy your suggestion.
I think we can do this. Later when we can break co
Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/545
@hanm Trying to make the API consistent by keeping one setter and getter
for the property. It escalated a bunch of other changes which I think are good
improvements and made the code simpler: e.g
Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/545
@hanm ? @breed ? @phunt ?
---
Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/545
Did anyone else have a chance to take a look?
---
15 matches
Mail list logo
