[GitHub] zookeeper issue #553: continue can be replaced with break

Github user maoling commented on the issue: https://github.com/apache/zookeeper/pull/553 @a470577391 it's useful and enough to change `continue` to `break`,especially when call `getLogFiles(logDir.listFiles(), 0)` It's better to create a

[GitHub] zookeeper issue #553: continue can be replaced with break

Github user anmolnar commented on the issue: https://github.com/apache/zookeeper/pull/553 @a470577391 Thanks for the contribution. As others requested already would you please create a Jira for this issue describing what exactly would like to change and why. Additionally, I

[GitHub] zookeeper issue #553: continue can be replaced with break

Github user maoling commented on the issue: https://github.com/apache/zookeeper/pull/553 IMHO: If the file are sorted,can we use binary search ,find the index then subList? Should we call `Util.getZxidFromName ` twice? ---

[GitHub] zookeeper issue #553: continue can be replaced with break

Github user nkalmar commented on the issue: https://github.com/apache/zookeeper/pull/553 Thanks @a470577391 , possibly OK, but please create a jira for this PR on https://issues.apache.org/jira/projects/ZOOKEEPER/ And make sure the jira number is in the commit message. ---