[GitHub] zookeeper issue #563: ZOOKEEPER-3072: Throttle race condition fix

2018-07-27 Thread breed
Github user breed commented on the issue: https://github.com/apache/zookeeper/pull/563 thank you @bothejjms ! ---

[GitHub] zookeeper issue #563: ZOOKEEPER-3072: Throttle race condition fix

2018-07-27 Thread bothejjms
Github user bothejjms commented on the issue: https://github.com/apache/zookeeper/pull/563 I have refactored the branches as suggested. ---

[GitHub] zookeeper issue #563: ZOOKEEPER-3072: Throttle race condition fix

2018-07-19 Thread anmolnar
Github user anmolnar commented on the issue: https://github.com/apache/zookeeper/pull/563 Thanks @bothejjms . I think the patch can be accepted now without the test. We need at least one more committer to approve. @hanm @phunt ? ---

[GitHub] zookeeper issue #563: ZOOKEEPER-3072: Throttle race condition fix

2018-07-18 Thread bothejjms
Github user bothejjms commented on the issue: https://github.com/apache/zookeeper/pull/563 I have removed the test for now as I don't have a good way to test this race condition. I can be reproduced easily by starting a server where the globalOutstandingLimit is 1 and sending a lot ex