Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/565
Committed to master branch.
Thanks @jpeach !
---
Github user breed commented on the issue:
https://github.com/apache/zookeeper/pull/565
+1 let's make this happen
---
Github user jpeach commented on the issue:
https://github.com/apache/zookeeper/pull/565
Is this ready to merge?
---
Github user jpeach commented on the issue:
https://github.com/apache/zookeeper/pull/565
Unrelated test failure
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1936/testReport/org.apache.zookeeper.server.quorum/QuorumPeerMainTest/testFailedTxnAsPartOfQuorumLoss/
---
Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/565
@jpeach Issue was on master, but it's already fixed.
Please trigger another build by amending your latest commit.
---
Github user jpeach commented on the issue:
https://github.com/apache/zookeeper/pull/565
AFAICT the test failure is from findbugs, which shouldn't have been
affected in this commit. I couldn't find what it was happy about in the test
output.
---
Github user jpeach commented on the issue:
https://github.com/apache/zookeeper/pull/565
Added a test. I needed the following patch to get the tests to build on
Fedora 28:
```
diff --git a/src/c/Makefile.am b/src/c/Makefile.am
index a81e3da2..0230419b 100644
---
Github user lvfangmin commented on the issue:
https://github.com/apache/zookeeper/pull/565
The code looks good to me, the default behavior is the same as before.
---
Github user jpeach commented on the issue:
https://github.com/apache/zookeeper/pull/565
Looks like CI failed on
`org.apache.zookeeper.test.FLETest.testTripleElection`. That seems like it
should be unrelated to this change.
---
