Github user lvfangmin commented on the issue:
https://github.com/apache/zookeeper/pull/583
Thanks @breed, the conflict is resolved.
---
Github user breed commented on the issue:
https://github.com/apache/zookeeper/pull/583
ok @lvfangmin i'll commit this once the conflict is resolved.
---
Github user nkalmar commented on the issue:
https://github.com/apache/zookeeper/pull/583
It's not a blocker for me, I agree it would be nice to have a unified
format, but that's pretty hard to achieve on an Apache I think :(
Anyway, that's why I wrote a "comment" review, not
Github user breed commented on the issue:
https://github.com/apache/zookeeper/pull/583
@nkalmar i think fixing whitespace is good if it is in proximity of the
code you are changing, which i think is the case in this diff.
the logic looks good to me! thanx @lvfangmin !
Github user maoling commented on the issue:
https://github.com/apache/zookeeper/pull/583
@lvfangmin discard your vim,embrace IEDA(smirk)
---
Github user lvfangmin commented on the issue:
https://github.com/apache/zookeeper/pull/583
@nkalmar I can remove the white space in this diff, it do looks much
cleaner after we remove the space though.
Do you know how often we need to ask people to format their code (remove
