Github user enixon commented on the issue:
https://github.com/apache/zookeeper/pull/615
@hanm it sounds like @anmolnar was okay with the form of my TxnLogToolkit
patch. I'll add it on top of this pull request and then will consider it ready
to merge.
---
Github user hanm commented on the issue:
https://github.com/apache/zookeeper/pull/615
@enixon Do you plan to update this PR with your trial integration branch,
or you prefer the patch land as is?
---
Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/615
@enixon Thanks for looking into the integration.
Code sharing is not so important. TxnLogToolkit is intended to be a
collection of all cli tools related to ZooKeeper transaction logs. So it's
Github user enixon commented on the issue:
https://github.com/apache/zookeeper/pull/615
@anmolnar , you can find a trial integration of the chop function with
TxnLogToolkit at
https://github.com/enixon/zookeeper/commit/b71ce04f70873f590c6cf5c24a691a1f1af82f48
. It's not the cleanest
Github user hanm commented on the issue:
https://github.com/apache/zookeeper/pull/615
Integrate into TxnLogToolkit is a good idea. I did not mention it as I
thought that might require a separate JIRA, because LogFormatter can also be
integrated (it's the least powerful tool of the thr
Github user enixon commented on the issue:
https://github.com/apache/zookeeper/pull/615
@hanm, I've made your recommended changes with the exception noted in my
comment.
@anmolnar , looking at TxnLogToolkit now - I think this should be easy to
integrate :)
---
Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/615
@enixon Your patch looks good, this is going to be a useful tool for
ZooKeeper.
Have you considered adding this functionality to `TxnLogToolkit` (a tool
developed by me :), instead of creatin
Github user enixon commented on the issue:
https://github.com/apache/zookeeper/pull/615
Sample usage is something like:
`java -cp build/zookeeper-3.6.0-SNAPSHOT.jar:build/lib/*
org.apache.zookeeper.server.util.LogChopper 0x3350003 log.333000b
shorterlog.333000b`
