[GitHub] zookeeper issue #639: ZOOKEEPER-2122: add openssl to zookeeper c client to s...

2018-09-21 Thread asfgit
Github user asfgit commented on the issue: https://github.com/apache/zookeeper/pull/639 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2227/ ---

[GitHub] zookeeper issue #639: ZOOKEEPER-2122: add openssl to zookeeper c client to s...

2018-09-21 Thread asfgit
Github user asfgit commented on the issue: https://github.com/apache/zookeeper/pull/639 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2228/ ---

[GitHub] zookeeper issue #639: ZOOKEEPER-2122: add openssl to zookeeper c client to s...

2018-09-21 Thread hanm
Github user hanm commented on the issue: https://github.com/apache/zookeeper/pull/639 thanks for update, @roodkcab . will take a look at this. quick question, looks like you had prove it working [here](https://github.com/apache/zookeeper/pull/625#issuecomment-421330923). Do y

[GitHub] zookeeper issue #639: ZOOKEEPER-2122: add openssl to zookeeper c client to s...

2018-09-21 Thread roodkcab
Github user roodkcab commented on the issue: https://github.com/apache/zookeeper/pull/639 @hanm no problem, I'll have a check later. I did find testKeyStore.jks and testTrustStore.jks in java's test directory, but I didn't find root.ca for both of them. I'd like to commit a tool for m

[GitHub] zookeeper issue #639: ZOOKEEPER-2122: add openssl to zookeeper c client to s...

2018-09-21 Thread roodkcab
Github user roodkcab commented on the issue: https://github.com/apache/zookeeper/pull/639 P.S. u have to compile openssl from source before u can do `cmake -DWITH_OPENSSL=$OPENSSL_INSTALL_DIRECTORY ../`. I tried to make openssl as a git submodule and let cmake to find it using find_pa

[GitHub] zookeeper issue #639: ZOOKEEPER-2122: add openssl to zookeeper c client to s...

2018-09-24 Thread roodkcab
Github user roodkcab commented on the issue: https://github.com/apache/zookeeper/pull/639 ![image](https://user-images.githubusercontent.com/1700820/45940893-3705c400-c00e-11e8-8c0e-c0566bef9fd2.png) @hanm unit test for ssl added. ---

[GitHub] zookeeper issue #639: ZOOKEEPER-2122: add openssl to zookeeper c client to s...

2018-09-24 Thread asfgit
Github user asfgit commented on the issue: https://github.com/apache/zookeeper/pull/639 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2245/ ---

[GitHub] zookeeper issue #639: ZOOKEEPER-2122: add openssl to zookeeper c client to s...

2018-09-24 Thread hanm
Github user hanm commented on the issue: https://github.com/apache/zookeeper/pull/639 test this please ---

[GitHub] zookeeper issue #639: ZOOKEEPER-2122: add openssl to zookeeper c client to s...

2018-09-24 Thread eolivelli
Github user eolivelli commented on the issue: https://github.com/apache/zookeeper/pull/639 retest this please ---

[GitHub] zookeeper issue #639: ZOOKEEPER-2122: add openssl to zookeeper c client to s...

2018-09-24 Thread eolivelli
Github user eolivelli commented on the issue: https://github.com/apache/zookeeper/pull/639 @hanm your phrase was wrong ---

[GitHub] zookeeper issue #639: ZOOKEEPER-2122: add openssl to zookeeper c client to s...

2018-09-24 Thread asfgit
Github user asfgit commented on the issue: https://github.com/apache/zookeeper/pull/639 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2247/ ---

[GitHub] zookeeper issue #639: ZOOKEEPER-2122: add openssl to zookeeper c client to s...

2018-09-24 Thread hanm
Github user hanm commented on the issue: https://github.com/apache/zookeeper/pull/639 @eolivelli maybe, but it works. i think the trigger phrase was looking for a substring match only. ---

[GitHub] zookeeper issue #639: ZOOKEEPER-2122: add openssl to zookeeper c client to s...

2018-09-24 Thread hanm
Github user hanm commented on the issue: https://github.com/apache/zookeeper/pull/639 @roodkcab Some new files are missing apache license header, which leads to release audit failure: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2245/artifact/patchprocess/patc

[GitHub] zookeeper issue #639: ZOOKEEPER-2122: add openssl to zookeeper c client to s...

2018-09-24 Thread asfgit
Github user asfgit commented on the issue: https://github.com/apache/zookeeper/pull/639 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2248/ ---

[GitHub] zookeeper issue #639: ZOOKEEPER-2122: add openssl to zookeeper c client to s...

2018-09-24 Thread roodkcab
Github user roodkcab commented on the issue: https://github.com/apache/zookeeper/pull/639 @hanm no problem, I’ll add Apache license headers to zoo.cfg and cert_creator.sh, .crt and .csr and .pkcs12 files are certificate files, which should not add license headers, May I add a README

[GitHub] zookeeper issue #639: ZOOKEEPER-2122: add openssl to zookeeper c client to s...

2018-09-24 Thread roodkcab
Github user roodkcab commented on the issue: https://github.com/apache/zookeeper/pull/639 seems Jenkins says No... I’ll have a check on java’s test cert files later ---

[GitHub] zookeeper issue #639: ZOOKEEPER-2122: add openssl to zookeeper c client to s...

2018-09-24 Thread hanm
Github user hanm commented on the issue: https://github.com/apache/zookeeper/pull/639 @roodkcab we could exclude some of the files for `releaseaudit` target such as cert files (or even zoo.cfg) where adding Apache License header does not make any sense. See [here](https://github.com/

[GitHub] zookeeper issue #639: ZOOKEEPER-2122: add openssl to zookeeper c client to s...

2018-09-24 Thread roodkcab
Github user roodkcab commented on the issue: https://github.com/apache/zookeeper/pull/639 @hanm license header added for cert_creator.sh and ignore all others ---

[GitHub] zookeeper issue #639: ZOOKEEPER-2122: add openssl to zookeeper c client to s...

2018-09-24 Thread asfgit
Github user asfgit commented on the issue: https://github.com/apache/zookeeper/pull/639 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2257/ ---

[GitHub] zookeeper issue #639: ZOOKEEPER-2122: add openssl to zookeeper c client to s...

2018-09-25 Thread anmolnar
Github user anmolnar commented on the issue: https://github.com/apache/zookeeper/pull/639 retest this please ---

[GitHub] zookeeper issue #639: ZOOKEEPER-2122: add openssl to zookeeper c client to s...

2018-09-25 Thread asfgit
Github user asfgit commented on the issue: https://github.com/apache/zookeeper/pull/639 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2258/ ---

[GitHub] zookeeper issue #639: ZOOKEEPER-2122: add openssl to zookeeper c client to s...

2018-09-25 Thread asfgit
Github user asfgit commented on the issue: https://github.com/apache/zookeeper/pull/639 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2262/ ---

[GitHub] zookeeper issue #639: ZOOKEEPER-2122: add openssl to zookeeper c client to s...

2018-09-25 Thread roodkcab
Github user roodkcab commented on the issue: https://github.com/apache/zookeeper/pull/639 a problem is when the network get disconnect, the client will enter into two state, one is ZOO_EXPIRED_SESSION_STATE, the other is ZOO_CONNECTING_STATE, the problem is the client didn't reconnect

[GitHub] zookeeper issue #639: ZOOKEEPER-2122: add openssl to zookeeper c client to s...

2018-09-26 Thread roodkcab
Github user roodkcab commented on the issue: https://github.com/apache/zookeeper/pull/639 problem solved, I've already push the latest code into a new branch and will run more test cases until I can confirm it works. ---

[GitHub] zookeeper issue #639: ZOOKEEPER-2122: add openssl to zookeeper c client to s...

2018-09-27 Thread roodkcab
Github user roodkcab commented on the issue: https://github.com/apache/zookeeper/pull/639 the early approach of adding ssl to the client uses a while loop to accomplish the certificate process between server and client, but it didn't check the connectivity, so when the client get a di

[GitHub] zookeeper issue #639: ZOOKEEPER-2122: add openssl to zookeeper c client to s...

2018-09-27 Thread asfgit
Github user asfgit commented on the issue: https://github.com/apache/zookeeper/pull/639 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2274/ ---